Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Lynne <dev@lynne.ee>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] fate: add various FFv1 tests for 1024 slices
Date: Wed, 16 Apr 2025 12:39:02 +0200
Message-ID: <3fc03208-8353-4f55-b5bb-2d3a5aee37e1@lynne.ee> (raw)
In-Reply-To: <GV1P250MB073722AFD2D5F371896B876B8FBD2@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>


[-- Attachment #1.1.1.1: Type: text/plain, Size: 4564 bytes --]

On 16/04/2025 12:22, Andreas Rheinhardt wrote:
> Lynne:
>> This lets us test features that were broken earlier, as well as
>> test the hardware decoder by using the HWACCEL=vulkan option.
> 
> Can't you just adjust some of vsynth FFV1 tests to use this many slices?
> (Can one even use 1024 slices for such a low resolution?)

I'd rather not. vsynth is the AVCodecContext of tests.
It's a good point to clean up, IMO.

>> ---
>>   tests/Makefile                      |  1 +
>>   tests/fate/ffv1.mak                 | 53 +++++++++++++++++++++++++++++
>>   tests/ref/fate/ffv1-s1024-bgra      |  4 +++
>>   tests/ref/fate/ffv1-s1024-bgra-r    |  4 +++
>>   tests/ref/fate/ffv1-s1024-gbrp16    |  4 +++
>>   tests/ref/fate/ffv1-s1024-gray8     |  4 +++
>>   tests/ref/fate/ffv1-s1024-gray8-r   |  4 +++
>>   tests/ref/fate/ffv1-s1024-yuv444p   |  4 +++
>>   tests/ref/fate/ffv1-s1024-yuv444p-r |  4 +++
>>   9 files changed, 82 insertions(+)
>>   create mode 100644 tests/fate/ffv1.mak
>>   create mode 100644 tests/ref/fate/ffv1-s1024-bgra
>>   create mode 100644 tests/ref/fate/ffv1-s1024-bgra-r
>>   create mode 100644 tests/ref/fate/ffv1-s1024-gbrp16
>>   create mode 100644 tests/ref/fate/ffv1-s1024-gray8
>>   create mode 100644 tests/ref/fate/ffv1-s1024-gray8-r
>>   create mode 100644 tests/ref/fate/ffv1-s1024-yuv444p
>>   create mode 100644 tests/ref/fate/ffv1-s1024-yuv444p-r
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index f9f5fc07f3..b2386febd7 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -180,6 +180,7 @@ include $(SRC_PATH)/tests/fate/enc_external.mak
>>   # Must be included after lavf-video.mak
>>   include $(SRC_PATH)/tests/fate/ffmpeg.mak
>>   include $(SRC_PATH)/tests/fate/ffprobe.mak
>> +include $(SRC_PATH)/tests/fate/ffv1.mak
>>   include $(SRC_PATH)/tests/fate/fifo-muxer.mak
>>   include $(SRC_PATH)/tests/fate/filter-audio.mak
>>   # Must be included after vcodec.mak
>> diff --git a/tests/fate/ffv1.mak b/tests/fate/ffv1.mak
>> new file mode 100644
>> index 0000000000..16660b5ac2
>> --- /dev/null
>> +++ b/tests/fate/ffv1.mak
>> @@ -0,0 +1,53 @@
>> +FATE_FFV1 += fate-ffv1-s1024-gray8
>> +fate-ffv1-s1024-gray8: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-gray8: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt gray8" tests/data/vsynth1.yuv \
> 
> Seems like you are treating the input file as gray8 (as opposed to
> converting it to gray8). Is this intended? Can't this cause problems
> because the size of the input file is not necessarily a multiple of the
> size expected for a 352x288 gray8 frame?

Shouldn't really cause an issue.
Do you have a better suggestion on how to handle this?

>> +  nut "-c ffv1 -g 1 -slices 1024 -coder ac" \
>> +  framecrc "" ""
>> +
>> +FATE_FFV1 += fate-ffv1-s1024-gray8-r
>> +fate-ffv1-s1024-gray8-r: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-gray8-r: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt gray8" tests/data/vsynth1.yuv \
>> +  nut "-c ffv1 -g 1 -slices 1024 -coder rice" \
>> +  framecrc "" ""
>> +
>> +FATE_FFV1 += fate-ffv1-s1024-yuv444p
>> +fate-ffv1-s1024-yuv444p: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-yuv444p: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt yuv444p" tests/data/vsynth1.yuv \
>> +  nut "-c ffv1 -g 1 -slices 1024 -coder ac" \
>> +  framecrc "" ""
>> +
>> +FATE_FFV1 += fate-ffv1-s1024-yuv444p-r
>> +fate-ffv1-s1024-yuv444p-r: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-yuv444p-r: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt yuv444p" tests/data/vsynth1.yuv \
>> +  nut "-c ffv1 -g 1 -slices 1024 -coder rice" \
>> +  framecrc "" ""
>> +
>> +FATE_FFV1 += fate-ffv1-s1024-bgra
>> +fate-ffv1-s1024-bgra: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-bgra: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt bgra" tests/data/vsynth1.yuv \
>> +  nut "-c ffv1 -g 1 -slices 1024 -coder ac" \
>> +  framecrc "" ""
>> +
>> +FATE_FFV1 += fate-ffv1-s1024-bgra-r
>> +fate-ffv1-s1024-bgra-r: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-bgra-r: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt bgra" tests/data/vsynth1.yuv \
>> +  nut "-c ffv1 -g 1 -slices 1024 -coder rice" \
>> +  framecrc "" ""
>> +
>> +FATE_FFV1 += fate-ffv1-s1024-gbrp16
>> +fate-ffv1-s1024-gbrp16: tests/data/vsynth1.yuv
>> +fate-ffv1-s1024-gbrp16: CMD = enc_dec \
>> +  "rawvideo -s 352x288 -pix_fmt gbrp16" tests/data/vsynth1.yuv \
>> +  nut "-c ffv1 -g 1 -slices 1024 -coder ac" \
>> +  framecrc "" ""
> 
> Won't this test cause issues on BE?

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-04-16 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16  9:55 Lynne
2025-04-16 10:22 ` Andreas Rheinhardt
2025-04-16 10:39   ` Lynne [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fc03208-8353-4f55-b5bb-2d3a5aee37e1@lynne.ee \
    --to=dev@lynne.ee \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git