From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id D264444BE2
	for <ffmpegdev@gitmailbox.com>; Tue,  8 Nov 2022 17:21:57 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 83C0368BC3B;
	Tue,  8 Nov 2022 19:21:54 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F5CE68BC12
 for <ffmpeg-devel@ffmpeg.org>; Tue,  8 Nov 2022 19:21:48 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 2A8HLk7q022801-2A8HLk7r022801
 for <ffmpeg-devel@ffmpeg.org>; Tue, 8 Nov 2022 19:21:46 +0200
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 3E8E3A1407
 for <ffmpeg-devel@ffmpeg.org>; Tue,  8 Nov 2022 19:21:46 +0200 (EET)
Date: Tue, 8 Nov 2022 19:21:44 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20221108170828.14483-1-jamrial@gmail.com>
Message-ID: <3f7cccae-41c4-7bfc-bcf-59d68b7e1f74@martin.st>
References: <20221108170828.14483-1-jamrial@gmail.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] avutil/tx: use llrintf() to convert a
 float into a 64 bit integer
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3f7cccae-41c4-7bfc-bcf-59d68b7e1f74@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Tue, 8 Nov 2022, James Almer wrote:

> Should fix fate failures on Windowx x86 targets, where long is 32 bits.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavutil/tx_priv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/tx_priv.h b/libavutil/tx_priv.h
> index 3195cb51b2..fb61119009 100644
> --- a/libavutil/tx_priv.h
> +++ b/libavutil/tx_priv.h
> @@ -124,7 +124,7 @@ typedef void TXComplex;
>     } while (0)
>
> #define UNSCALE(x) ((double)(x)/2147483648.0)
> -#define RESCALE(x) (av_clip64(lrintf((x) * 2147483648.0), INT32_MIN, INT32_MAX))
> +#define RESCALE(x) (av_clip64(llrintf((x) * 2147483648.0), INT32_MIN, INT32_MAX))

LGTM, thanks! This does seem to fix the test failures in my configs.

// Martin


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".