From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7196D46563 for ; Thu, 20 Jul 2023 19:39:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0875268C3F0; Thu, 20 Jul 2023 22:39:39 +0300 (EEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 64A0D68BF66 for ; Thu, 20 Jul 2023 22:39:32 +0300 (EEST) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1b05d63080cso846707fac.2 for ; Thu, 20 Jul 2023 12:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689881970; x=1690486770; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vImW+ikqvgjDsPt8QxVIrZiByOYCj97xGPm5nqJ8DDw=; b=iKUT5Qmmjh4tOOH3xVkc+CkIMK0oHGGr23pxZyuVUunYJBCNGpwryBINUhb27D88Be XgFJOttPM6zATD2Hc84q8Onf35avBcehegjnB9r7PIkT4DJ7EAFM5vwPAIOK4uGZR7Ia wtjslMaSeUENbEUTIUYpo3dFN1rNe5AYaWNg4fIIhpLdmR7YkoyBBDJ3t/Bbh/d4OzcI 82KKngs8dorjybCi/JUnEE2J84OLuO/LI8PIv73TzAFYll0GpYSHWBG/SHSy4l6EC4yl PAucmqjQ4heKhpE24ecoNHxzREvvLZyS4zQCj2mEBoihOTPcIalAOawqMIjxr3LCItyA vxsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689881970; x=1690486770; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vImW+ikqvgjDsPt8QxVIrZiByOYCj97xGPm5nqJ8DDw=; b=Es84jqKooArc7weBATMmlGAZMA33qrh+fGRosjvz7VQtMdyeueVLIpRvIWdCHfT6eH Kd0MWaUXsq0U+R7L65t5FQx8KtwpCDxQHdslOz2TDK00wzggU4UhLR9fa5SyvmeRrYvU JXJvBU5YXMWh3OXh8rcsZSox0voiYlnt9jsMWFFyJceWxe+gyLtgfY/A9SC5suLOrKkT TyIetNdd9JGvvfgG2OSubjDwH1z2p9dnao5VN6/t6UJzLuzdeZXpXAjlKeJGmck9kpGU Q1BlY2GIgmxYQ50uVKGGRCFik02mBlev5iloOw4nRGCdRWNIelMo/dM+ulECZtJXnagj 3Rsw== X-Gm-Message-State: ABy/qLYzokrQVjpxKUVwp1AAWB30fQ03/3FRwZ14Y+KojNpqbSaUSe7M fpzYiqhmiqnXjBw7NiF7KrbS6X7NJQ0= X-Google-Smtp-Source: APBJJlGARwJQjFI0I2xLe8nkhlglMtDVugZ9fbQdFafcrqZTwm+pIl9bcAyobGStoZ0kXHxYpO/pRA== X-Received: by 2002:a05:6870:1610:b0:1b7:24b0:ac6e with SMTP id b16-20020a056870161000b001b724b0ac6emr442984oae.9.1689881970487; Thu, 20 Jul 2023 12:39:30 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id e3-20020a056870944300b001b04434d934sm818774oal.34.2023.07.20.12.39.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Jul 2023 12:39:30 -0700 (PDT) Message-ID: <3f77889e-3f52-f4a5-6693-229d0dfd732e@gmail.com> Date: Thu, 20 Jul 2023 16:39:36 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230719222043.59743-1-jamrial@gmail.com> <20230719222043.59743-5-jamrial@gmail.com> <168988010396.27367.2360099703316632165@lain.khirnov.net> <9b585e44-0f10-9d38-2a84-ca6f2173ad89@gmail.com> <168988151888.27367.15238642284616060989@lain.khirnov.net> From: James Almer In-Reply-To: <168988151888.27367.15238642284616060989@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 5/5] fftools/ffmpeg: support applying container level cropping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/20/2023 4:31 PM, Anton Khirnov wrote: > Quoting James Almer (2023-07-20 21:25:02) >> On 7/20/2023 4:08 PM, Anton Khirnov wrote: >>> Quoting James Almer (2023-07-20 00:20:43) >>>> diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c >>>> index 8b750de4e5..3cf29c8b2c 100644 >>>> --- a/fftools/ffmpeg_enc.c >>>> +++ b/fftools/ffmpeg_enc.c >>>> @@ -441,14 +441,16 @@ int enc_open(OutputStream *ost, AVFrame *frame) >>>> int i; >>>> for (i = 0; i < ist->st->nb_side_data; i++) { >>>> AVPacketSideData *sd = &ist->st->side_data[i]; >>>> - if (sd->type != AV_PKT_DATA_CPB_PROPERTIES) { >>>> + if (sd->type == AV_PKT_DATA_CPB_PROPERTIES) >>>> + continue; >>>> + if (ist->apply_cropping && sd->type == AV_PKT_DATA_FRAME_CROPPING) >>>> + continue; >>> >>> I'm very much not a fan of the encoder doing anything based on decoder >>> options. >> >> Right now, all input stream side data (save for CPB) is copied to the >> output stream. > > I think it's wrong for transcoding. Side data should be propagated > through the decoder My other set will introduce this, so at least the first step towards this will be done. I'll send it in a few. > and the filtergraph and then be processed by the > encoder. It however doesn't touch lavfi. > Just blindly copying whatever is in the input is bound to > produce inaccurate information. Agree, but that's outside the scope of this set. I don't think lavfi can even take global side data right now. Only on a frame basis. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".