From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2A13C4287F for ; Tue, 5 Apr 2022 12:20:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8909068B1A5; Tue, 5 Apr 2022 15:20:49 +0300 (EEST) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5B69968B167 for ; Tue, 5 Apr 2022 15:20:43 +0300 (EEST) Received: by mail-oi1-f182.google.com with SMTP id q129so13201298oif.4 for ; Tue, 05 Apr 2022 05:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=FUNCwktcc/naQFbXLkwkXTScrQ3UGXQ1XfCrM9XZnGU=; b=HxM0sGAfmznG8755ns/tEF5+89yKpB2a/vORn+ui5WvLRoWtla+MYtrXZvPGqon7Yn /zylEX2gk8wNeLpq5F5hRPdWzWmfZsWhJ6IWDNpekrPTHWgi2NmImKGKQT/atgklg4Ij VDCPODmwP6b2g1R2eEksnMGh9wzIOsLwJQ460SKLUIdbJr2DdXmNQ7sf4dCWuldtjN+H 2Z9Bq9sRMhL0a1P4kopxhZ7WV3lKV9V5NS/Zo3wjIFELFA9x/CZysXOfDK9eeAp21R8Q F2b6I1BO+eulwS5vIy2W9Wa0qYNgDuTK03ApURa4oRnf4Jwbm8iNfnPYV0icjj05Bj6G mAIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=FUNCwktcc/naQFbXLkwkXTScrQ3UGXQ1XfCrM9XZnGU=; b=tFbpxh1hZ+K0ryo8UgoEQbrkht5AjjwAj+mye4opwgux0SnfPLVW6QIZYqcv4qniOf QSpC0epGMoVEqcfkXTOR9mzztPyhW4bpfN+UTa94ozxXrymvYYCu/RuGdJXqj5hWcMY/ 3fWTlod1j1DqvHWPR6KPamA1MrdP6Z+efCZmFLklgBB3sJ6cmdS5TGRG/+yUSHMzEYGZ iiDxes/aENDAMt71nHVGIiQ5zXOQdBD1L01Wn0AcV3GcnKzUJ8jEIbycLTT/mGi/VuZR +5TlFxcbi1rVD31OAkAtR9fXqGgztVCRm9ISvW3ZS3fhSlbQre3C8RfHzbznehHc9QoN w4cA== X-Gm-Message-State: AOAM531ksuKtMMVLmSS+AlYsq6k7G01wLqlbHSc1G5Sv4vtrSpsTy+mr z/sMKpxPlw0UC3d62TLEAV+Eq9+8HmDRdA== X-Google-Smtp-Source: ABdhPJynfo+TuQx+smvAnLF0MjuOYcEDCxKW7riX5g1W71iA0kG4Gk8TNKcvVc+O3O9CPp0RQLknzA== X-Received: by 2002:a05:6808:148a:b0:2f9:35b6:8865 with SMTP id e10-20020a056808148a00b002f935b68865mr1234794oiw.123.1649161241333; Tue, 05 Apr 2022 05:20:41 -0700 (PDT) Received: from [192.168.0.12] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id q83-20020aca5c56000000b002f94910a053sm5217913oib.56.2022.04.05.05.20.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 05:20:40 -0700 (PDT) Message-ID: <3e9ee4e7-7b42-c4a4-054a-6f99a5001072@gmail.com> Date: Tue, 5 Apr 2022 09:20:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20220328232453.54773-1-jamrial@gmail.com> In-Reply-To: <20220328232453.54773-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: rename mov_get_channel_label() to better reflect its purpose X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/28/2022 8:24 PM, James Almer wrote: > This function turns a mov channel label into a lavf native bitmask. > > Signed-off-by: James Almer > --- > libavformat/mov_chan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c > index f52239d347..4607540297 100644 > --- a/libavformat/mov_chan.c > +++ b/libavformat/mov_chan.c > @@ -485,7 +485,7 @@ static uint64_t mov_get_channel_layout(uint32_t tag, uint32_t bitmap) > return layout_map[i].layout; > } > > -static uint32_t mov_get_channel_label(uint32_t label) > +static uint32_t mov_get_channel_mask(uint32_t label) > { > if (label == 0) > return 0; > @@ -590,7 +590,7 @@ int ff_mov_read_chan(AVFormatContext *s, AVIOContext *pb, AVStream *st, > avio_rl32(pb); // mCoordinates[2] > size -= 20; > if (layout_tag == 0) { > - uint32_t mask_incr = mov_get_channel_label(label); > + uint32_t mask_incr = mov_get_channel_mask(label); > if (mask_incr == 0) { > label_mask = 0; > break; Will apply set. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".