From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 86AA045432
	for <ffmpegdev@gitmailbox.com>; Thu, 28 Sep 2023 17:27:43 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 837FA68CB8E;
	Thu, 28 Sep 2023 20:27:40 +0300 (EEST)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 55D3368CA6F
 for <ffmpeg-devel@ffmpeg.org>; Thu, 28 Sep 2023 20:27:34 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 8814A175CC2
 for <ffmpeg-devel@ffmpeg.org>; Thu, 28 Sep 2023 19:27:33 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1695922053;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=CGwkev+OIQXgq52W6JKZSxFMMgO3vmpb0M/cB5rtQ58=;
 b=P+8so0/abU5CjvAQTjge7FubQ9WgiXbUE7t4F9E2R5LBIzasSGat6OLd8B9Mox6omnCTPU
 WUO/oT6/4sr6+OFeWZmbXruukPuPwYPn+q35wioFKuGoNzHOI9oh7bGH+sbTBHnaU9LMB6
 yUJw/Y3LmVx5UPrf3Ld67l6otqXltT8amXG7hBeUaPCFLjZ3813YpEAVbK5EFQD+pJ3EE3
 1eENTjrgqRS1UCU7pzsiLt4N2/QjKV4lbHds94zJzCAUMjSr2c7r/OLRorAo6VmNqjgKK+
 OkU8TynKCVpVGaDtfjQ8LtZg5cpdn7mASCULBZAmoEQiJn5N4r3Z732C0RhnGQ==
Message-ID: <3e9e73cc-52c8-426e-804d-4649b110f90d@rothenpieler.org>
Date: Thu, 28 Sep 2023 19:27:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <CAJZRZVnobJQ6wqhBn61mkAtUjsQSOwOg8EyWC_qf_6UnuMKdyA@mail.gmail.com>
 <169470019868.20400.10524960200868191992@lain.khirnov.net>
 <CAJZRZVm1yM0n5ri-X7FZq1A+X2E1GmpsdDu6hQN5t3wpjbY6=A@mail.gmail.com>
 <7984201b-83b4-4d51-9d5b-d70e958bf399@rothenpieler.org>
 <CAJZRZVmj-oPYMQ0Ko1BSXj8J5kdCv8J8Mvqix8TsqwY+XTQOhQ@mail.gmail.com>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <CAJZRZVmj-oPYMQ0Ko1BSXj8J5kdCv8J8Mvqix8TsqwY+XTQOhQ@mail.gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option
 to use current CUDA context
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3e9e73cc-52c8-426e-804d-4649b110f90d@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 14.09.2023 18:52, Roman Arzumanyan wrote:
> Got it, thanks.
> Please find the patches in attachment.
> 
> Just for my own understanding - could you please explain how this magic
> works in the configure script? I mean this section:
> 
> if ! disabled ffnvcodec; then
> 
>      ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h ffnvcodec/dynlink_cuda.h
> ffnvcodec/dynlink_cuviddec.h ffnvcodec/dynlink_nvcuvid.h"
> 
>      check_pkg_config ffnvcodec "ffnvcodec >= 12.1.14.0" "$ffnv_hdr_list" ""
> || \
> 
>        check_pkg_config ffnvcodec "ffnvcodec >= 12.0.16.0  ffnvcodec < 12.1"
> "$ffnv_hdr_list" "" || \
> 
>        check_pkg_config ffnvcodec "ffnvcodec >= 11.1.5.2 ffnvcodec < 12.0"
> "$ffnv_hdr_list" "" || \
> 
>        check_pkg_config ffnvcodec "ffnvcodec >= 11.0.10.2 ffnvcodec < 11.1"
> "$ffnv_hdr_list" "" || \
> 
>        check_pkg_config ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2"
> "$ffnv_hdr_list" ""
> 
> fi

Applied with various amendments:

  - Added missing version bump.
  - Added missing APIchanges entry.
  - Made the "both options are set"-check actually check both options, 
and not the same one twice.
  - Dropped "if != 0" checks, FFmpeg generally just does "if (variable)" 
in those cases.
  - Updated version checks in configure.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".