From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] libavutil/hwcontect_cuda: add option to use current CUDA context
Date: Thu, 28 Sep 2023 19:27:32 +0200
Message-ID: <3e9e73cc-52c8-426e-804d-4649b110f90d@rothenpieler.org> (raw)
In-Reply-To: <CAJZRZVmj-oPYMQ0Ko1BSXj8J5kdCv8J8Mvqix8TsqwY+XTQOhQ@mail.gmail.com>
On 14.09.2023 18:52, Roman Arzumanyan wrote:
> Got it, thanks.
> Please find the patches in attachment.
>
> Just for my own understanding - could you please explain how this magic
> works in the configure script? I mean this section:
>
> if ! disabled ffnvcodec; then
>
> ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h ffnvcodec/dynlink_cuda.h
> ffnvcodec/dynlink_cuviddec.h ffnvcodec/dynlink_nvcuvid.h"
>
> check_pkg_config ffnvcodec "ffnvcodec >= 12.1.14.0" "$ffnv_hdr_list" ""
> || \
>
> check_pkg_config ffnvcodec "ffnvcodec >= 12.0.16.0 ffnvcodec < 12.1"
> "$ffnv_hdr_list" "" || \
>
> check_pkg_config ffnvcodec "ffnvcodec >= 11.1.5.2 ffnvcodec < 12.0"
> "$ffnv_hdr_list" "" || \
>
> check_pkg_config ffnvcodec "ffnvcodec >= 11.0.10.2 ffnvcodec < 11.1"
> "$ffnv_hdr_list" "" || \
>
> check_pkg_config ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2"
> "$ffnv_hdr_list" ""
>
> fi
Applied with various amendments:
- Added missing version bump.
- Added missing APIchanges entry.
- Made the "both options are set"-check actually check both options,
and not the same one twice.
- Dropped "if != 0" checks, FFmpeg generally just does "if (variable)"
in those cases.
- Updated version checks in configure.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-09-28 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 7:26 Roman Arzumanyan
2023-09-14 10:00 ` Timo Rothenpieler
2023-09-14 13:29 ` Roman Arzumanyan
2023-09-14 13:32 ` Timo Rothenpieler
2023-09-14 14:03 ` Anton Khirnov
[not found] ` <CAJZRZVm1yM0n5ri-X7FZq1A+X2E1GmpsdDu6hQN5t3wpjbY6=A@mail.gmail.com>
[not found] ` <7984201b-83b4-4d51-9d5b-d70e958bf399@rothenpieler.org>
2023-09-14 16:52 ` Roman Arzumanyan
2023-09-14 16:54 ` Timo Rothenpieler
2023-09-19 8:18 ` Roman Arzumanyan
2023-09-19 12:25 ` Timo Rothenpieler
2023-09-28 17:27 ` Timo Rothenpieler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e9e73cc-52c8-426e-804d-4649b110f90d@rothenpieler.org \
--to=timo@rothenpieler.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git