From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 608C94263F for ; Mon, 21 Mar 2022 20:33:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5468C68B0FB; Mon, 21 Mar 2022 22:33:46 +0200 (EET) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF7E8689F59 for ; Mon, 21 Mar 2022 22:33:39 +0200 (EET) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-d6e29fb3d7so70977fac.7 for ; Mon, 21 Mar 2022 13:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=hyBkw8wTS/o4wv3vqgEJluLCysVQCk/mgILU+JzSlTI=; b=UplWsmZBVrLUz2B2WrfvHJFqj+psGbzcSH3vCiZw5M2ZuOv9azWy/XkwuICu2pgJgd JUxvF28o7EN44aPG3LO4JHGd7V0kD1oDasiFHqxvtmrpMJbqCljsRpx7jFvvUW1vwaYZ rWtZpJUXIgTyfHgyryyyu/nL3T/JlYuCuefZsa9uOHEkNJwe5k5GBFNyJ7JK0YSf0O0z nr7J2Q0fdpGOX2mfzJIuLu8J1FIfnJNom8KXLg+ygYdmVG6jo8u9tN6rLfKPNf3cEmLk WtuHSr9NC/Udic+P9D2kltdBdqEHvvcIDV/me/Plwc32mf5N//fx0Zh7kh4FpE1hy1IO PhCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=hyBkw8wTS/o4wv3vqgEJluLCysVQCk/mgILU+JzSlTI=; b=pRwFMBVWX07Sa3umQ+17FHDrauj38Q7m6Un6OfUQifDs42So+F/3iW5Ipo9YVA9qdR YtoAwBWivny8PRBctzpeIqtYT1QoVO6lV1hK6w26gaq62Px5/s0WhsWUXi24I/OF3C99 jN+dXwe67C40YEOy//DCBWB75wUlRMKcfNKA1duCkYeZh39zpDyOzMn5LisI6HeBUQVg bVb9JQaD584Dfdr1sPs6M+fGHIRp47MbPERhgH3MqJwLZ1mUx56TRQ/08g9ds6dMu0Uk ciPBV0JoJkp4ue2fCOMxk/jJPjUscFp3600ezed6A+TbImpnQELLWMl0oYszsEjGj6JQ CfOg== X-Gm-Message-State: AOAM532Y3Hyyofr0ahZOPXECuiWWgooHzIx0sn1DRK78zw9sopAi5TCB wTaSHxx9f+CY4lk6kd+YFWH/284xkLej0g== X-Google-Smtp-Source: ABdhPJzhiaqclcDRKlM9ieZlTLSaOSNe3K4bFj6PrCkC3vdq8Y56YKNYj0wQ7pvtH+DyrDpPdw2G2g== X-Received: by 2002:a05:6870:828c:b0:dd:ec79:58f4 with SMTP id q12-20020a056870828c00b000ddec7958f4mr359603oae.250.1647894817831; Mon, 21 Mar 2022 13:33:37 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id g18-20020a9d6c52000000b005af7c7cb702sm7627509otq.34.2022.03.21.13.33.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 13:33:37 -0700 (PDT) Message-ID: <3e5b386f-d888-c5da-0906-69897db8644f@gmail.com> Date: Mon, 21 Mar 2022 17:33:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220321201946.16919-1-michael@niedermayer.cc> <20220321201946.16919-2-michael@niedermayer.cc> From: James Almer In-Reply-To: <20220321201946.16919-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/allcodecs: Dont play with NULLs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/21/2022 5:19 PM, Michael Niedermayer wrote: > Fixes: member access within null pointer of type 'const FFCodec' (aka 'const struct FFCodec') > Fixes: 45726/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6554445419249664 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/allcodecs.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c > index b1aa7e266b..22d56760ec 100644 > --- a/libavcodec/allcodecs.c > +++ b/libavcodec/allcodecs.c > @@ -882,10 +882,11 @@ const AVCodec *av_codec_iterate(void **opaque) > > ff_thread_once(&av_codec_static_init, av_codec_init_static); > > - if (c) > + if (c) { > *opaque = (void*)(i + 1); > - > - return &c->p; > + return &c->p; > + } > + return NULL; Can't you just do return (const AVCodec *)c; Or is that aliasing a problem? > } > > static enum AVCodecID remap_deprecated_codec_id(enum AVCodecID id) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".