From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avfilter/ccfifo: remove unnecessary context allocations
Date: Fri, 12 May 2023 16:24:40 -0300
Message-ID: <3e52deb7-12de-7488-0c3e-3c1bfe72b84c@gmail.com> (raw)
In-Reply-To: <CAHGibzHysM9=aYUC148n64Jr-aG9i1V094nGaUpvWgpLe9kQVw@mail.gmail.com>
On 5/12/2023 12:17 PM, Devin Heitmueller wrote:
> On Thu, May 11, 2023 at 2:20 PM James Almer <jamrial@gmail.com> wrote:
>>
>> This is not public API, no it has no need for an alloc() and free()
>> functions. The struct can reside on stack.
>
> I don't have any objection to this patch in principle, assuming this
> is the standard convention that ffmpeg uses for such things.
>
> I will point out though that the patch doesn't include the usage in
> libavdevice/decklink_enc.cpp, so it would cause build breakage if the
> proposed changes are not reflected in that file as well.
Thanks for spotting it. Adapted decklink as well, and pushed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-05-12 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 18:03 [FFmpeg-devel] [PATCH] " James Almer
2023-05-11 18:11 ` Leo Izen
2023-05-11 18:19 ` [FFmpeg-devel] [PATCH v2] " James Almer
2023-05-12 15:17 ` Devin Heitmueller
2023-05-12 19:24 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e52deb7-12de-7488-0c3e-3c1bfe72b84c@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git