* [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c @ 2024-02-18 19:20 Stone Chen 2024-02-18 19:44 ` Stone Chen 2024-02-19 0:08 ` Marton Balint 0 siblings, 2 replies; 6+ messages in thread From: Stone Chen @ 2024-02-18 19:20 UTC (permalink / raw) To: ffmpeg-devel; +Cc: Stone Chen In commit 6c45d34, a line was added that always sets rdiv to 0, overriding any user input. This removes that line allowing user set values for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. Signed-off-by: Stone Chen <chen.stonechen@gmail.com> --- libavfilter/vf_convolution.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c index bf67f392f6..a00bb2b3c4 100644 --- a/libavfilter/vf_convolution.c +++ b/libavfilter/vf_convolution.c @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) p = orig = av_strdup(s->matrix_str[i]); if (p) { s->matrix_length[i] = 0; - s->rdiv[i] = 0.f; sum = 0.f; while (s->matrix_length[i] < 49) { -- 2.43.2 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c 2024-02-18 19:20 [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c Stone Chen @ 2024-02-18 19:44 ` Stone Chen 2024-02-19 0:08 ` Marton Balint 1 sibling, 0 replies; 6+ messages in thread From: Stone Chen @ 2024-02-18 19:44 UTC (permalink / raw) To: ffmpeg-devel [-- Attachment #1: Type: text/plain, Size: 1053 bytes --] Sorry I think I didn't correctly attach the patch the first time. On Sun, Feb 18, 2024 at 2:21 PM Stone Chen <chen.stonechen@gmail.com> wrote: > In commit 6c45d34, a line was added that always sets rdiv to 0, overriding > any user input. This removes that line allowing user set values for 0rdiv, > 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. > > Signed-off-by: Stone Chen <chen.stonechen@gmail.com> > --- > libavfilter/vf_convolution.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > index bf67f392f6..a00bb2b3c4 100644 > --- a/libavfilter/vf_convolution.c > +++ b/libavfilter/vf_convolution.c > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) > p = orig = av_strdup(s->matrix_str[i]); > if (p) { > s->matrix_length[i] = 0; > - s->rdiv[i] = 0.f; > sum = 0.f; > > while (s->matrix_length[i] < 49) { > -- > 2.43.2 > > [-- Attachment #2: 0001-Fix-rdiv-always-being-set-to-0-in-vf_convolution.c.patch --] [-- Type: text/x-patch, Size: 1001 bytes --] From 38734506c1f651062e38c4e1281d8070b6e4bdaf Mon Sep 17 00:00:00 2001 From: Stone Chen <chen.stonechen@gmail.com> Date: Sun, 18 Feb 2024 13:47:05 -0500 Subject: [PATCH] Fix rdiv always being set to 0 in vf_convolution.c In commit 6c45d34, a line was added that always sets rdiv to 0, overriding any user input. This removes that line allowing user set values for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. --- libavfilter/vf_convolution.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c index bf67f392f6..a00bb2b3c4 100644 --- a/libavfilter/vf_convolution.c +++ b/libavfilter/vf_convolution.c @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) p = orig = av_strdup(s->matrix_str[i]); if (p) { s->matrix_length[i] = 0; - s->rdiv[i] = 0.f; sum = 0.f; while (s->matrix_length[i] < 49) { -- 2.43.2 [-- Attachment #3: Type: text/plain, Size: 251 bytes --] _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c 2024-02-18 19:20 [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c Stone Chen 2024-02-18 19:44 ` Stone Chen @ 2024-02-19 0:08 ` Marton Balint 2024-02-19 1:07 ` Stone Chen 2024-02-19 1:38 ` Stone Chen 1 sibling, 2 replies; 6+ messages in thread From: Marton Balint @ 2024-02-19 0:08 UTC (permalink / raw) To: FFmpeg development discussions and patches On Sun, 18 Feb 2024, Stone Chen wrote: > In commit 6c45d34, a line was added that always sets rdiv to 0, overriding any user input. This removes that line allowing user set values for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket #10294. This is likely not the correct fix, because resetting it to 0 was added to support dynamic reconfigurations. The way I see it, the user option rdiv-s and internally used rdivs should be separated, init_params should always recalculate the internal rdivs based on the user option rdivs... Regards, Marton > > Signed-off-by: Stone Chen <chen.stonechen@gmail.com> > --- > libavfilter/vf_convolution.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > index bf67f392f6..a00bb2b3c4 100644 > --- a/libavfilter/vf_convolution.c > +++ b/libavfilter/vf_convolution.c > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) > p = orig = av_strdup(s->matrix_str[i]); > if (p) { > s->matrix_length[i] = 0; > - s->rdiv[i] = 0.f; > sum = 0.f; > > while (s->matrix_length[i] < 49) { > -- > 2.43.2 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c 2024-02-19 0:08 ` Marton Balint @ 2024-02-19 1:07 ` Stone Chen 2024-02-19 1:38 ` Stone Chen 1 sibling, 0 replies; 6+ messages in thread From: Stone Chen @ 2024-02-19 1:07 UTC (permalink / raw) To: FFmpeg development discussions and patches Hi Marton, Thanks for the feedback! I'm not sure what dynamic reconfiguration is, from some searching I think it might be related to commands? On Sun, Feb 18, 2024 at 7:08 PM Marton Balint <cus@passwd.hu> wrote: > > > On Sun, 18 Feb 2024, Stone Chen wrote: > > > In commit 6c45d34, a line was added that always sets rdiv to 0, > overriding any user input. This removes that line allowing user set values > for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket > #10294. > > This is likely not the correct fix, because resetting it to 0 was added to > support dynamic reconfigurations. > > The way I see it, the user option rdiv-s and internally used rdivs > should be separated, init_params should always recalculate the internal > rdivs based on the user option rdivs... > > Regards, > Marton > > > > > Signed-off-by: Stone Chen <chen.stonechen@gmail.com> > > --- > > libavfilter/vf_convolution.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > > index bf67f392f6..a00bb2b3c4 100644 > > --- a/libavfilter/vf_convolution.c > > +++ b/libavfilter/vf_convolution.c > > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) > > p = orig = av_strdup(s->matrix_str[i]); > > if (p) { > > s->matrix_length[i] = 0; > > - s->rdiv[i] = 0.f; > > sum = 0.f; > > > > while (s->matrix_length[i] < 49) { > > -- > > 2.43.2 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c 2024-02-19 0:08 ` Marton Balint 2024-02-19 1:07 ` Stone Chen @ 2024-02-19 1:38 ` Stone Chen 2024-02-19 20:39 ` Marton Balint 1 sibling, 1 reply; 6+ messages in thread From: Stone Chen @ 2024-02-19 1:38 UTC (permalink / raw) To: FFmpeg development discussions and patches Hi Marton, Thanks for the feedback! I'm not sure what dynamic reconfiguration is, from some searching I think it might be related to commands? On Sun, Feb 18, 2024 at 7:08 PM Marton Balint <cus@passwd.hu> wrote: > > > On Sun, 18 Feb 2024, Stone Chen wrote: > > > In commit 6c45d34, a line was added that always sets rdiv to 0, > overriding any user input. This removes that line allowing user set values > for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket > #10294. > > This is likely not the correct fix, because resetting it to 0 was added to > support dynamic reconfigurations. > > The way I see it, the user option rdiv-s and internally used rdivs > should be separated, init_params should always recalculate the internal > rdivs based on the user option rdivs... > > Regards, > Marton > > > > > Signed-off-by: Stone Chen <chen.stonechen@gmail.com> > > --- > > libavfilter/vf_convolution.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c > > index bf67f392f6..a00bb2b3c4 100644 > > --- a/libavfilter/vf_convolution.c > > +++ b/libavfilter/vf_convolution.c > > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) > > p = orig = av_strdup(s->matrix_str[i]); > > if (p) { > > s->matrix_length[i] = 0; > > - s->rdiv[i] = 0.f; > > sum = 0.f; > > > > while (s->matrix_length[i] < 49) { > > -- > > 2.43.2 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c 2024-02-19 1:38 ` Stone Chen @ 2024-02-19 20:39 ` Marton Balint 0 siblings, 0 replies; 6+ messages in thread From: Marton Balint @ 2024-02-19 20:39 UTC (permalink / raw) To: FFmpeg development discussions and patches On Sun, 18 Feb 2024, Stone Chen wrote: > Hi Marton, > > Thanks for the feedback! > > I'm not sure what dynamic reconfiguration is, from some searching I think > it might be related to commands? Yeah, exactly. If you check the code, the process_command callback allows this, which eventually calls param_init() which does filter (re)configuration and recalculation of rdivs. Regards, Marton PS: Please do not top post on this mailing list. > > On Sun, Feb 18, 2024 at 7:08 PM Marton Balint <cus@passwd.hu> wrote: > >> >> >> On Sun, 18 Feb 2024, Stone Chen wrote: >> >> > In commit 6c45d34, a line was added that always sets rdiv to 0, >> overriding any user input. This removes that line allowing user set values >> for 0rdiv, 1rdiv, 2rdiv, 3rdiv to apply as expected. This fixes ticket >> #10294. >> >> This is likely not the correct fix, because resetting it to 0 was added to >> support dynamic reconfigurations. >> >> The way I see it, the user option rdiv-s and internally used rdivs >> should be separated, init_params should always recalculate the internal >> rdivs based on the user option rdivs... >> >> Regards, >> Marton >> >> > >> > Signed-off-by: Stone Chen <chen.stonechen@gmail.com> >> > --- >> > libavfilter/vf_convolution.c | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/libavfilter/vf_convolution.c b/libavfilter/vf_convolution.c >> > index bf67f392f6..a00bb2b3c4 100644 >> > --- a/libavfilter/vf_convolution.c >> > +++ b/libavfilter/vf_convolution.c >> > @@ -674,7 +674,6 @@ static int param_init(AVFilterContext *ctx) >> > p = orig = av_strdup(s->matrix_str[i]); >> > if (p) { >> > s->matrix_length[i] = 0; >> > - s->rdiv[i] = 0.f; >> > sum = 0.f; >> > >> > while (s->matrix_length[i] < 49) { >> > -- >> > 2.43.2 >> > >> > _______________________________________________ >> > ffmpeg-devel mailing list >> > ffmpeg-devel@ffmpeg.org >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > >> > To unsubscribe, visit link above, or email >> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-19 20:39 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-02-18 19:20 [FFmpeg-devel] [PATCH] Fix rdiv always being set to 0 in vf_convolution.c Stone Chen 2024-02-18 19:44 ` Stone Chen 2024-02-19 0:08 ` Marton Balint 2024-02-19 1:07 ` Stone Chen 2024-02-19 1:38 ` Stone Chen 2024-02-19 20:39 ` Marton Balint
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git