From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A22E24885C for ; Fri, 19 Apr 2024 17:04:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 647AF68D410; Fri, 19 Apr 2024 20:04:51 +0300 (EEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7E86668D3CD for ; Fri, 19 Apr 2024 20:04:44 +0300 (EEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e40042c13eso18699325ad.2 for ; Fri, 19 Apr 2024 10:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713546281; x=1714151081; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=5WSL0qYOBpeHmwstG+Eeo3IHHG36MFM7Yyf3fYBhrWo=; b=bcxRGRUfBvTR3RXFsw1Sv2nDPiVPc841O46YxGRSQGtySHC2Aa7dU3oZsbJOaHNjU7 jZ1Hy/0VqenH8BEvCLtW3Mm/m/eBqh23W2xLJpor7omUumhA1tBZOZfMQaRdSJK8H20r 3DptmC/7jns2OqmBDobO4CwVkeoDTQO7qPDUbeeyaKUGielmHNO6zSzHdBgMrLIlRbR5 xa3hdMOP192Uzcbiwzz82cFWfJyH+/1BYAjyzDXhx7l5wDqo5TELvhvjf8+KYX64E7S/ BpC6aV/zI9fMZatfF/p+vK5SDxKT7rJYeD3JvE8Yqto/Yej5G8At3PHGFxlqODsU3WLC bH/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713546281; x=1714151081; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5WSL0qYOBpeHmwstG+Eeo3IHHG36MFM7Yyf3fYBhrWo=; b=Lox8eJTp2DbjFaFMMD+r/gzzYnSi0mi3EV4OjS30Jq57UKQQTGX66dHBHytHAe1ZKa Y4T0Z/8N7F0ypZGt1liyd6OFEx78KVKHYd2q3k2aEj66vBd8tgFUFfdwQPzkmQOyagcU ojnhth8sEJ6zqcnRYi3bmRf2nS6g6RdicksXurJ2+V/xgjyCqkt+ktC8kDQoqFuEGDHA pYl/KJ6USLrbAWPxwwbjZLs90Q7zy0f9moNkEH2srrv+RMjghJNDNo5w+XJUGSuUKxer THMR5M3flZAqDllpCtF4dM4B1u3NDu8irmmZGdcGTeFQwxUv8Xo+xGNw8PqGC1i5FC21 3gAg== X-Gm-Message-State: AOJu0YyF3xqUeH6SK6tvYRJWXRu7CVbHhqseZVHXpvV1iP2EUgtdu5Zd UR7rqNG3k+KrbKp+0TNFTElu2qvYZwtIRhtRTTEJanxksdeOK3bAmIGTfw== X-Google-Smtp-Source: AGHT+IGWUX/auOhgtXkakj9pZhLU+Ynj9vOeeGMnbl078kJe/rUlpzxkEzDSia2iDCcNGR/ozVyvfA== X-Received: by 2002:a17:902:cf0d:b0:1e4:7ca3:8a33 with SMTP id i13-20020a170902cf0d00b001e47ca38a33mr3158699plg.17.1713546280969; Fri, 19 Apr 2024 10:04:40 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id m20-20020a170902c45400b001e197cee600sm3602753plm.3.2024.04.19.10.04.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 10:04:40 -0700 (PDT) Message-ID: <3e292cbb-8248-4dc6-a750-27f7b0e8ff8f@gmail.com> Date: Fri, 19 Apr 2024 14:04:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240419165946.99911-1-ffmpeg-devel@pileofstuff.org> Content-Language: en-US From: James Almer In-Reply-To: <20240419165946.99911-1-ffmpeg-devel@pileofstuff.org> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: handle errors > 0 in avformat_network_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/19/2024 1:59 PM, Andrew Sayers wrote: > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 4dded7aea4..855723a406 100644 > --- a/libavformat/utils.c > +++ b/libavformat/utils.c > @@ -560,7 +560,7 @@ int avformat_network_init(void) > { > #if CONFIG_NETWORK > int ret; > - if ((ret = ff_network_init()) < 0) > + if ((ret = ff_network_init())) ff_network_init() needs to be fixed to return negative error values instead. This change will make it return 1 on error on Windows. > return ret; > if ((ret = ff_tls_init()) < 0) > return ret; _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".