* [FFmpeg-devel] [PATCH] avformat/jpegxl_probe: fix incorrect cw_mask probing
@ 2022-05-01 19:39 Leo Izen
2022-05-16 14:49 ` Leo Izen
0 siblings, 1 reply; 2+ messages in thread
From: Leo Izen @ 2022-05-01 19:39 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Leo Izen
Fix incorrectly skipping over the upX_weights
if the cw_mask is present and it is not a multiple of 4.
---
libavformat/jpegxl_probe.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libavformat/jpegxl_probe.c b/libavformat/jpegxl_probe.c
index 9cd00da194..c03dc3bd1d 100644
--- a/libavformat/jpegxl_probe.c
+++ b/libavformat/jpegxl_probe.c
@@ -368,15 +368,19 @@ int ff_jpegxl_verify_codestream_header(const uint8_t *buf, int buflen)
/* default transform */
if (!jxl_bits(1)) {
+ uint32_t cw_mask;
+
/* opsin inverse matrix */
if (xyb_encoded && !jxl_bits(1))
jxl_bits_skip(16 * 16);
+
/* cw_mask and default weights */
- if (jxl_bits(1))
+ cw_mask = jxl_bits(3);
+ if (cw_mask & 1)
jxl_bits_skip(16 * 15);
- if (jxl_bits(1))
+ if (cw_mask & 2)
jxl_bits_skip(16 * 55);
- if (jxl_bits(1))
+ if (cw_mask & 4)
jxl_bits_skip(16 * 210);
}
--
2.36.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/jpegxl_probe: fix incorrect cw_mask probing
2022-05-01 19:39 [FFmpeg-devel] [PATCH] avformat/jpegxl_probe: fix incorrect cw_mask probing Leo Izen
@ 2022-05-16 14:49 ` Leo Izen
0 siblings, 0 replies; 2+ messages in thread
From: Leo Izen @ 2022-05-16 14:49 UTC (permalink / raw)
To: ffmpeg-devel
On 5/1/22 15:39, Leo Izen wrote:
> Fix incorrectly skipping over the upX_weights
> if the cw_mask is present and it is not a multiple of 4.
Bumping for review.
- Leo Izen (thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-01 19:39 [FFmpeg-devel] [PATCH] avformat/jpegxl_probe: fix incorrect cw_mask probing Leo Izen
2022-05-16 14:49 ` Leo Izen
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git