From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A0C2549C86 for ; Wed, 6 Mar 2024 05:32:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD38468CB1D; Wed, 6 Mar 2024 07:32:35 +0200 (EET) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0B4D668BDDF for ; Wed, 6 Mar 2024 07:32:29 +0200 (EET) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4TqLff4rswz9smq for ; Wed, 6 Mar 2024 06:32:26 +0100 (CET) Message-ID: <3dfe0f21-fef8-406b-adf3-3f73d9d656bd@gyani.pro> Date: Wed, 6 Mar 2024 11:02:25 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20240301141135.23870-1-ffmpeg@gyani.pro> Content-Language: en-US From: Gyan Doshi In-Reply-To: <20240301141135.23870-1-ffmpeg@gyani.pro> X-Rspamd-Queue-Id: 4TqLff4rswz9smq Subject: Re: [FFmpeg-devel] [PATCH] avfilter: update filter timeline state only on main link X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2024-03-01 07:41 pm, Gyan Doshi wrote: > At present, consume_update evaluates timeline state on all links for > a multi-input filter. This can lead to the filter being incorrectly > en/dis-abled when evaluation on a frame on a secondary link leads to > a different result than the frame on the current main link next in > line for processing. Ping. Plan to apply in 72h, barring objections. Regards, Gyan > --- > libavfilter/avfilter.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index daa7c3672a..d7ea993508 100644 > --- a/libavfilter/avfilter.c > +++ b/libavfilter/avfilter.c > @@ -1430,7 +1430,8 @@ static void consume_update(FilterLinkInternal *li, const AVFrame *frame) > AVFilterLink *const link = &li->l; > update_link_current_pts(li, frame->pts); > ff_inlink_process_commands(link, frame); > - link->dst->is_disabled = !ff_inlink_evaluate_timeline_at_frame(link, frame); > + if (link == link->dst->inputs[0]) > + link->dst->is_disabled = !ff_inlink_evaluate_timeline_at_frame(link, frame); > link->frame_count_out++; > link->sample_count_out += frame->nb_samples; > } _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".