From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3FC3044D67 for ; Mon, 21 Nov 2022 04:37:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8DEF968BCC0; Mon, 21 Nov 2022 06:37:32 +0200 (EET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5714068BB94 for ; Mon, 21 Nov 2022 06:37:25 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669005450; x=1700541450; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=fu9W0kHDnFT1pIxbZMfEfIsErCV7RvdSEBScxVP2mC0=; b=ZLhcF+KuDnpg86HczBxouf+5ASUkPvBxscrwew9mRRjKtG7jy2FYVR9M G5/gKxMJkV4GSxEF/trpXV9CNdcZn+FGqZJ6V4vzckE4mIK9OEgcDVxFJ PzsTCmYFZ4ldGCVuTIOrai/RGjviFXj7SBkEck3VWAY6SZPGJMnNhZZLy eAWjj7zg4rEdSe6dxn5YMvzsoFwnzB7UTJk43XM7lj3Jit7U49x/jB6nJ JWCDmShIYlL5VPQZhSDLMwx9Umi1fYqoFlm2wokrknpTfoQXb2GD5gkLV btVF4Ahtixq4AkMHnlXGlNsySGIIXYegc2nIeuuq2C8aeYLSb4PsLuIsA w==; X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="293858748" X-IronPort-AV: E=Sophos;i="5.96,180,1665471600"; d="scan'208";a="293858748" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2022 20:37:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="673848841" X-IronPort-AV: E=Sophos;i="5.96,180,1665471600"; d="scan'208";a="673848841" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 20 Nov 2022 20:37:22 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 20 Nov 2022 20:37:22 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 20 Nov 2022 20:37:22 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 20 Nov 2022 20:37:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVt/cM0Mqi3eUQFK4PtYl5YEeQ3VDSsKnCYruvOElPqiVjZHO8j01m3xbc/ddOJCw/3N4VjxOCmrIJFiIy9F0rxmNFsqJpcvO4ngZbG44aaZKowQHCD2LbcfkJTeV72jNMaZARDIR73MNeoHgO52dOcu7xsa35RSU/m+8jKqsios2yysQukluSCwsBE4q9kdIHseQUHmvoM26Hej48cQhobByColfOAOB7i74Jw6+z06+rz4+SqXHtnO5ryDTWirrJ5zBaQm3xpTnH5sbK7UPUPIuA21yrjYTsot/FKI47laKrY1LPTbShufuh9ohpSZgq449kY6m7XBqLCrbmCUtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fu9W0kHDnFT1pIxbZMfEfIsErCV7RvdSEBScxVP2mC0=; b=WdG9VdQ/D0Ht5X6jwFuxmNhqZEu/7uS+c5q4gT/KeyaB0YBXHn5IAhNkHI27ClcdbUgnqNEistrLhEXoBCRJLpbeSk4irTo70OHLmZIzEHWZUk5uEf0d9TW4ek3dWBGm7RH4YhzRgsV/u74TSJqgQkWAqaFmHPy7sXV/ZRfTxldYaqHU9Lf/DE5JRliub2QggIP6Af++mzfes2q89zRXsaczQyT/oADc1YoS42E/HALYDXcfDPCf7YmoUiCW+3PBEoUXmbEHmojfPbJAykXpbluSLLy7wWYIE1itFH4/jzQlzf37s3c2Mtey9ytpbvw1kQD7DjBusZ5L2K/tW7rnug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CO1PR11MB4914.namprd11.prod.outlook.com (2603:10b6:303:90::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15; Mon, 21 Nov 2022 04:37:20 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::ca2a:c3a1:b0cb:c003]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::ca2a:c3a1:b0cb:c003%9]) with mapi id 15.20.5834.015; Mon, 21 Nov 2022 04:37:13 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64 Thread-Index: AQHY+D/OGmJXXN1OUU2z04r+qRJvSq4+nYgAgAo30AA= Date: Mon, 21 Nov 2022 04:37:13 +0000 Message-ID: <3df5a7af279b8dd9a4526645a312c4754d9c4ebb.camel@intel.com> References: <20221114152023.11003-1-bin.wang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|CO1PR11MB4914:EE_ x-ms-office365-filtering-correlation-id: 5eaf9aba-ee75-4588-4040-08dacb7a0fd7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ABk9ANb6YfAtioNXSv5Ytf/lVzbW4oV1Fz4ofJWa0muvpS7h3caXhRMGHHcsZ847/l2Sg/aUlvghx9TutH0s5LUmJJqHfo3//RtAkwkl3KY26hYvtiKAz9ygWVYEb+Xz3cjF0Kjls50eruHXmsSgZVYV4jQlZOelYDpz2sUb57fYdPxvFdbY2/LCTBpz+WkoB4g1RYz5SOI13li/FxNjAorildTh3ygppXoRzqGEjX9s69kWqq2IgCJ28iAOjEXRD3SbCBoRb95Ci7zrRaqPfwS6aNm06+AVS3nNQWu/9bu/xLe7jtXfJgxp8Oww8OLF121k6EuuPM0oqB8vI///895KAOvC4LEid0oxVfusimjBjIJc4MYuh9qYLE7OWV3WnM2Bnaj8hzr4MWNIHZ0Hv+JQvd5Y4Aj1oavrAV8mjUJPRUpG72m1BAG/IgBYFAvn6UtloIsoCh/eijguGxliw/3isnfEkAHcCZApGI7L/VaNDqKtdWLUVuhWD0pGBfVnnO7BiuM6mFfkO29n0kiqulbPYyvwCYSG3HX+3eNqMYlxEb7vDiDjRA4OwuvuXOGw/1Zb+ugXn/muduSfnIcVVR/PPWvpwaShAcgH69xbflQVWeFM+NS4voZsf0+4s06+SOWCXgLTwPga2D2OTEqQMp5NFIkX/qrt9qrMmRHHaDUvGWD+ei1jzOM2HfLV5FAls3yiI62CrzuY/OIa2OvnPw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(136003)(39860400002)(346002)(376002)(366004)(451199015)(122000001)(82960400001)(38100700002)(26005)(38070700005)(86362001)(478600001)(6486002)(71200400001)(53546011)(5660300002)(8936002)(6506007)(64756008)(91956017)(66556008)(8676002)(76116006)(66946007)(66446008)(41300700001)(316002)(66476007)(186003)(2616005)(6916009)(2906002)(4001150100001)(83380400001)(6512007)(36756003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?elZubnVMVWQzbkoyS2xzN1M2RjR5WlZNcEg0eERhTElkdHdhdTFtajZ0ZExI?= =?utf-8?B?dGdBbUdlK0FWS1hDaWJ1ZzdsYlBQdVRBUm1lM1M4RForZjBpRE45WFpMWjMv?= =?utf-8?B?YkdHTUpCNis1WGt2dUVYUXVBN1loTWtDdnAybEhHbVdsWlBRZ0ZQb2pRTmV3?= =?utf-8?B?aXhldkNWalMxcStmcmZLYTBnaVVCektCQ1JvMzFZejF4VUFQOHM3czNQSXYx?= =?utf-8?B?VHk0eEVpbWsrZ3JPaG12VEhvdSsyOWhKaVdPdUU0NWEvKy80UGtoc1Q0Y3cz?= =?utf-8?B?SEZ3a2hQUjIxSkh1WWd6UENhcGloUGQ5M3huQXlRbGdjck90OUdXWFlocWtI?= =?utf-8?B?dkNpSktFdElmTzBiendwZUdSOWg3YmpheEJUZ2RnSE5Oc0I0eFF6RVlTcHpw?= =?utf-8?B?cHU1OEVQZlVjQ096UnRMdWpKcVoxUWNwLzR3SS9jUXZDOE5CdFhKTjlJWGNn?= =?utf-8?B?RGJBeFdZNHhJOUN6Vm9xR284YW9UdGFqSVdqTVNBc1hlREtSNDMwOEtNdWov?= =?utf-8?B?U2hDUG90cDlEQ3doak9KeGd6cFZ2Y3VQVTNaN2xlTTZCRE5PY0kvWEx4c3pp?= =?utf-8?B?dFBDa0Zua3kySWlIUG0wc0FDQ2ZmYzBZNUxRdjVIVmFMcVE5bDQ5QTF4Y3lK?= =?utf-8?B?QzNHMHhCdXpYbEh3K0VmY3NCZVloUEF1dHpPYXkzdmFYcHUwTjNJbmthQ3A2?= =?utf-8?B?V0h5RlBkM2xtdUhic2x2NmY4YWxWSHNmbnhleVIxTytaNnpqMkVGMkd1RkR3?= =?utf-8?B?WkQ3Qi91MWxPYTNmNjk3azhQaDhBVmd0L3VJOHluUHphUDZIbm85TEhtaUxR?= =?utf-8?B?Y09xNHFjZURDL1ZQU1c3bGhQb3lJbXZvOWtnMk9oMFUwdWVxREx5MU1WQjVQ?= =?utf-8?B?R2RjcTdWdUJKYzJCSGkrL2NWWkdSOXp6RVdSZldmMExlazNEclEzWUFNRUp2?= =?utf-8?B?STB0RlNxRDVrR21YNUUwNXNWTERQNHh0aGRDYTBmbnppeEpOZElLNkNqNUVv?= =?utf-8?B?L3ZhWGFXR1dDZVhSZ3o4ZXNCM1VwNGNndTZHT3JGaVV4TzJ0VVBjMVA0dGND?= =?utf-8?B?MEJrd3pJWEh3RGplRCtQQjFTaVJZZWtwSklyb29GWGpZSTRVR3daVG5tSkZm?= =?utf-8?B?WTIrTnFEclUybEVqUmJXRzBKMXFHb09rOGRPL3lpZ0kwNWg5eExKZDBRQU54?= =?utf-8?B?N3FlMm1tUzR5bm1ZMVAreHdRR3R1YWpFaXZvUFRMUC9XYm9nUVlwVXAvTjM5?= =?utf-8?B?WEQwMHowYW1QdUo0NjNPdUx5dmN0ZG5KUmc3T0tlemxVSW05VzNXdk41WFhB?= =?utf-8?B?MHJvejhGVWQ2ekR6OVA2N1pYT01iUmxERGE0L1ErZWJGc1VxcE1hdEc2cWZ0?= =?utf-8?B?U0w4OElQM1NUWitwQmpBS00zRmdHREtUSGlONHdxSjdGMUUyaVNYZDIvcTBl?= =?utf-8?B?clJCMTc4b0JNQUlCdEUyUGNNWUdwOE5aVG1oek1JZmN6eUxFRk43S2VDMDhI?= =?utf-8?B?UUQ1RXBqbXIzT1VYRnFZNTVjSHI3Sk5kakdFb041aVU5KzVoMDNsZ095K1Fh?= =?utf-8?B?VWJmRzlSb1lmaTNZR3RuZ0JCNnJWZXpXTVc1Y1N6YW56WWdyaHIwSTRmVFlG?= =?utf-8?B?VHlPQm10eFU3bGdsYVZ5RXdGQzB2Y2UyK3VWTHZMd3QwUVBjc0tBNkU3ZXNQ?= =?utf-8?B?alJlcnp0TUpCdnZ3b0VxNTFaMThiWXdEUGo5d1V2MkNQbTlnSWpyT0lYN09q?= =?utf-8?B?elRwVWo5dmE1TFNWTG9JSXJuUmxWNHNFcEJxaEphK0Vpb3BmUlZvc0NJaTht?= =?utf-8?B?b1BVWmZwbXIvVm9wK3YwQUpScllIakcvNmRCNkpoYlRYUVUvUFhHSHpWcmFX?= =?utf-8?B?L2pqZTAvY0YwUFhrZTRXbVpvM3VaTk85M2tyMk04REc0TkhVeXNuZFN0OGZk?= =?utf-8?B?bnUvdXU5NjR4TUttQmFyZklaNElhUXdJdnZ4bS9YS1g4T21xKzNQcXJLaE9o?= =?utf-8?B?cklhWTh0V3g1TkVwNHYyRkZaMzNld1prTm9rcW03T09wWStrNEUzZWlBbVp4?= =?utf-8?B?V24xaXgzUGVTdWkzdXlwRGo3dk9vWFdMMDdTWThBK3Z6VWxrRVV0WVNWcHlu?= =?utf-8?B?ckg4TncvQjJEWG1BTld4RkJ5TmUzU1M1M3VuWkdtQ3RJUHlqN0VJQUlkMnpV?= =?utf-8?B?WkE9PQ==?= Content-ID: <8763F2B6AB6EBD488F33085F7E589759@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5eaf9aba-ee75-4588-4040-08dacb7a0fd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2022 04:37:13.7935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 22a7k5WwzD4bCzJgUbVn3ajE++vgTW4VGf/qqLRWCeHA0wrUZFSM4w+wU665W3wSk4qQtRgrFVR4Z/rj4mrccA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4914 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-11-14 at 13:34 -0300, James Almer wrote: > On 11/14/2022 12:20 PM, bin.wang-at-intel.com@ffmpeg.org wrote: > > From: "Wang, Bin" > > > > Signed-off-by: Wang, Bin > > --- > > libavfilter/x86/vf_convolution.asm | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/libavfilter/x86/vf_convolution.asm > > b/libavfilter/x86/vf_convolution.asm > > index c912d56752..9ac9ef5d73 100644 > > --- a/libavfilter/x86/vf_convolution.asm > > +++ b/libavfilter/x86/vf_convolution.asm > > @@ -189,15 +189,16 @@ cglobal filter_sobel, 4, 15, 7, dst, width, matrix, > > ptr, c0, c1, c2, c3, c4, c5, > > cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, > > c1, c2, c3, c4, c5, c6, c7, c8, r, x > > %endif > > %if WIN64 > > - SWAP xmm0, xmm2 > > - SWAP xmm1, xmm3 > > + VBROADCASTSS m0, xmm2 > > + VBROADCASTSS m1, xmm3 > > mov r2q, matrixmp > > mov r3q, ptrmp > > DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, > > c8, r, x > > -%endif > > - movsxdifnidn widthq, widthd > > +%else > > VBROADCASTSS m0, xmm0 > > VBROADCASTSS m1, xmm1 > > +%endif > > + movsxdifnidn widthq, widthd > > pxor m6, m6 > > mov c0q, [ptrq + 0*gprsize] > > mov c1q, [ptrq + 1*gprsize] > > @@ -281,7 +282,7 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, > > matrix, ptr, c0, c1, c2, > > fmaddss xmm4, xmm5, xmm5, xmm4 > > > > sqrtps xmm4, xmm4 > > - fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias > > + fmaddss xmm4, xmm4, xm0, xm1 ;sum = sum * rdiv + bias > > cvttps2dq xmm4, xmm4 ; trunc to integer > > packssdw xmm4, xmm4 > > packuswb xmm4, xmm4 > > Should be ok. Applied, -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".