From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64
Date: Mon, 21 Nov 2022 04:37:13 +0000
Message-ID: <3df5a7af279b8dd9a4526645a312c4754d9c4ebb.camel@intel.com> (raw)
In-Reply-To: <cd853dd0-cea6-4314-7ed5-9e5e1b4d072c@gmail.com>
On Mon, 2022-11-14 at 13:34 -0300, James Almer wrote:
> On 11/14/2022 12:20 PM, bin.wang-at-intel.com@ffmpeg.org wrote:
> > From: "Wang, Bin" <bin.wang@intel.com>
> >
> > Signed-off-by: Wang, Bin <bin.wang@intel.com>
> > ---
> > libavfilter/x86/vf_convolution.asm | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/libavfilter/x86/vf_convolution.asm
> > b/libavfilter/x86/vf_convolution.asm
> > index c912d56752..9ac9ef5d73 100644
> > --- a/libavfilter/x86/vf_convolution.asm
> > +++ b/libavfilter/x86/vf_convolution.asm
> > @@ -189,15 +189,16 @@ cglobal filter_sobel, 4, 15, 7, dst, width, matrix,
> > ptr, c0, c1, c2, c3, c4, c5,
> > cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0,
> > c1, c2, c3, c4, c5, c6, c7, c8, r, x
> > %endif
> > %if WIN64
> > - SWAP xmm0, xmm2
> > - SWAP xmm1, xmm3
> > + VBROADCASTSS m0, xmm2
> > + VBROADCASTSS m1, xmm3
> > mov r2q, matrixmp
> > mov r3q, ptrmp
> > DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7,
> > c8, r, x
> > -%endif
> > - movsxdifnidn widthq, widthd
> > +%else
> > VBROADCASTSS m0, xmm0
> > VBROADCASTSS m1, xmm1
> > +%endif
> > + movsxdifnidn widthq, widthd
> > pxor m6, m6
> > mov c0q, [ptrq + 0*gprsize]
> > mov c1q, [ptrq + 1*gprsize]
> > @@ -281,7 +282,7 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias,
> > matrix, ptr, c0, c1, c2,
> > fmaddss xmm4, xmm5, xmm5, xmm4
> >
> > sqrtps xmm4, xmm4
> > - fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias
> > + fmaddss xmm4, xmm4, xm0, xm1 ;sum = sum * rdiv + bias
> > cvttps2dq xmm4, xmm4 ; trunc to integer
> > packssdw xmm4, xmm4
> > packuswb xmm4, xmm4
>
> Should be ok.
Applied,
-Haihao
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-11-21 4:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 15:20 bin.wang-at-intel.com
2022-11-14 16:34 ` James Almer
2022-11-21 4:37 ` Xiang, Haihao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3df5a7af279b8dd9a4526645a312c4754d9c4ebb.camel@intel.com \
--to=haihao.xiang-at-intel.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git