From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 58D3748EF2 for ; Mon, 29 Jan 2024 23:32:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B883668D28D; Tue, 30 Jan 2024 01:32:02 +0200 (EET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DB74768D20C for ; Tue, 30 Jan 2024 01:31:55 +0200 (EET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1d71cb97937so17977785ad.3 for ; Mon, 29 Jan 2024 15:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706571113; x=1707175913; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jE/ATmLb9JA4D8/DDYxsMeRRS4T0RpYbHcACnhKUKyg=; b=D3YNDc0p7GyDiqEpcz4ew+cO7FNlo3UtVZbQrgf09jM+DkK8N1C+f2sUpKuu4yGi+B +u2fgdQT33hUP/KQ7LJhYiSKGFUNgNUw4Wr8VK/ewRzKf1swmuID630yANDeRDkDg6tm yPZ6Fh/mSVEGtmmfwjNvRQnsWHuuKFMOEdMXdW1g0jnXGPFJVk6nd9D4AQo108DdrI7r PjTKkfCK+grRcd+rkMkNrXV6yrVxlKYCNK3+8m3TQWWWB1t43MufC8l17W11hSxX5YVh FBIQniwdeV+Adg9z9CoXW7DDwvk721uNd1wMGgunDDlESEh4eCwGNlas6OXL2PBPtORZ E9qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706571113; x=1707175913; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jE/ATmLb9JA4D8/DDYxsMeRRS4T0RpYbHcACnhKUKyg=; b=iPjbJLgjkHiyhqRpo2XCzsifoxOfuM2tlsjfexLOZZtGDuGncLh/RVBrUt4vlCyDWE ma/oNBD8YJLMoezypEyx+sbGvy1AalNUXKSSJ4QXA78dLsFM4VteVQ+PNJjEKpwpvArj c3fWyvMeUyAE1W950oy8P0kBhtvCBGLeGn1c1/qPIpi/y2oXAqzc0SbjiJc3kTv87ELb 727kk9fMK/qUE8Y3Qlfwo9CeC+PKnExvHHHhl0txhk+XceO3bXi/Nr2FaiNzEYIF5PYM PXRFBa+z8w8JvQLEOXwRDCem6fID81wtCKalUzUNZhBUNfQPN4i5/NyEYQzIa6sa61Qn BQsg== X-Gm-Message-State: AOJu0YzZUdYrTLueQzatniWxtOUgJlxYgGtiFkRqnhfnOeRM7D7FZB22 NKdK5cbtR/Sy8uGp6+p+bUBeuhAJaf+SK6B4CAx87nid/kvXCil8mOMNyeS4 X-Google-Smtp-Source: AGHT+IGvDNAsXvxCistTlYS//lOZyNFVTYl9NhybYDKPjqmGhe0VtTyNI8yvcfOPxo7k/QS/8meLZQ== X-Received: by 2002:a17:902:bb0f:b0:1d8:f129:a0bc with SMTP id im15-20020a170902bb0f00b001d8f129a0bcmr1666051plb.13.1706571113193; Mon, 29 Jan 2024 15:31:53 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id kk12-20020a170903070c00b001d70953f166sm5935636plb.155.2024.01.29.15.31.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 15:31:52 -0800 (PST) Message-ID: <3de88e6a-7aef-452d-bcb2-d8d2b48f1c77@gmail.com> Date: Mon, 29 Jan 2024 20:32:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240129232104.4193951-1-post@frankplowman.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20240129232104.4193951-1-post@frankplowman.com> Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: Increase IntraEdgeParams buffer size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/29/2024 8:22 PM, Frank Plowman wrote: > The reference line buffers are used with indices in the range > -MAX_TB_SIZE - 3 to refw + FFMAX(1, w/h) * ref_idx + 1, which is > at most 5*MAX_TB_SIZE + 1. > > Fixes buffer overflows. > http://fate.ffmpeg.org/report.cgi?slot=armv7-linux-gcc-9&time=20240124051736 > --- > libavcodec/vvc/vvcdsp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/vvc/vvcdsp.c b/libavcodec/vvc/vvcdsp.c > index c82ea7be30..56e71d5163 100644 > --- a/libavcodec/vvc/vvcdsp.c > +++ b/libavcodec/vvc/vvcdsp.c > @@ -87,10 +87,10 @@ typedef struct IntraEdgeParams { > uint8_t* left; > int filter_flag; > > - uint16_t left_array[3 * MAX_TB_SIZE + 3]; > - uint16_t filtered_left_array[3 * MAX_TB_SIZE + 3]; > - uint16_t top_array[3 * MAX_TB_SIZE + 3]; > - uint16_t filtered_top_array[3 * MAX_TB_SIZE + 3]; > + uint16_t left_array[6 * MAX_TB_SIZE + 5]; > + uint16_t filtered_left_array[6 * MAX_TB_SIZE + 5]; > + uint16_t top_array[6 * MAX_TB_SIZE + 5]; > + uint16_t filtered_top_array[6 * MAX_TB_SIZE + 5]; > } IntraEdgeParams; > > #define PROF_BORDER_EXT 1 Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".