From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 50DFD4CFE4 for ; Fri, 14 Feb 2025 12:29:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C3C8268BFFF; Fri, 14 Feb 2025 14:29:42 +0200 (EET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3894568B87F for ; Fri, 14 Feb 2025 14:29:31 +0200 (EET) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38f265c6cb0so888563f8f.2; Fri, 14 Feb 2025 04:29:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739536170; x=1740140970; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=QYAKutJJp8HA+owZwjgX3Q2JFPdfLP7De0hEbKwvD6Q=; b=CQsQWcbfmdETCz4WDFg1qlUDzCGKNPe0bc4Z6H1zGWc7+8TyUgXkk+xgT+v7qFZJ5+ ZgBlQh5UKrmpVCbLqOGdsFQvlaN3ZSaNoYW8gpEBEUzbeJy+/qoFJCYhXjgPBfWH2TgA xzzikye5vTqcmMpCUB/VZrOtjLybWDo1/6+L2bV2xS9elCpmLdMqPR9kmIdjtAM1jq59 AySfoktlAkrQNZsWF5sLT9b4wn0py0JeMdqAKSjT05MFurbKukvkX87Qq16IwAYVDFaR m9nPQo2IlxRAMc/lcQVAn1e+bwecHGFvW76RefGpovTTZQLm50O1CNvMNk3qlLk/C9/1 yt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739536170; x=1740140970; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QYAKutJJp8HA+owZwjgX3Q2JFPdfLP7De0hEbKwvD6Q=; b=JAlfc3Q96tFPJVKRko3CsmRtczPSrATSmr+UaPjV8s5AfMoimzA3ickKFSjatT/1ox RNg6wanpTxmhE3lUncRYHw/szZNWK99oRHaAd4aW3v8n2/B4ziMD4GHNwIqml5WTq18C /OUubnfNJpz/iEuT5INlvhgei0GUxVNCQPa5hP106ywODRCWhHR/KLm9ob5t0DJYtshd XuyREImwC1QZPR+NOyG1md+FfE0IB+s8zTYg5xPLmFWFiQaXgjmOBjnurG1hF5Tg/41f dZZUJjiPMl31omaNdcvyKUqi3tJMOpHXwbUybZSHs4EMQT7Wm6j8mw/Wy6cZvoIFHURu tXxg== X-Forwarded-Encrypted: i=1; AJvYcCU3DyBMCjojFYiufxDeMcg+LRpdecH1jFYoaHSwMQBi4z8F/CMudwn/x1enr7VqZIjYqYmBzWAtL6UwG1L+ERa+X3J9H+0YaT8v@ffmpeg.org X-Gm-Message-State: AOJu0YxJOQ1ZrIV56nRA8F2e0OngnuHEFmG3/q7Q+FQEA0lJGVbR2BWo 0JUq5dHA5iwPh9F5QE8a0ppIhsqI26/DKzwNvDeRUTVhqiaYB0JICkEYkA== X-Gm-Gg: ASbGncsp2y/pZtlmZXuCM1IazYCERui5TQzMTceEzmDrACHjCx67plOlFouI4gYaKSy 9Oa4Lbrft/TMtQhxXykHgF4dzThw4z6nqztmywErRTLcuBhxGDNCqGKH7ol/lBFzTJlycboMmxe kaEE99QyE/MSvPlY16OEuOdu26Na6ppib7dAvl8Q9bC4fzradOGAWs8Pe3gWraYnyfqWJaLA5KD 4l8OIhcMBtK2Ela2V1DGIllsbqYB0OCrurxz6VPA/fV0mQPx7iTw/Pk4wJvFoYu3iR/yJrbLnR3 GkDYFjpUOKeDYOjayxg9wR+Sf3Cn10+BbUjIsVJBZ66ZgtbDJMohp2K83t7hpRaWWIHjUA== X-Google-Smtp-Source: AGHT+IEilDY+JTtSBzOWQZd9cGO7IvofIQQnf5YVot1Pr20wFrYAE5ibZcxM8Xwq01lgVnqs8FQQYQ== X-Received: by 2002:a5d:5f46:0:b0:38d:d767:364 with SMTP id ffacd0b85a97d-38dea26db1emr11423998f8f.13.1739536170130; Fri, 14 Feb 2025 04:29:30 -0800 (PST) Received: from ?IPV6:2001:9e8:1d81:f000:d0e6:71e1:1a45:b7af? ([2001:9e8:1d81:f000:d0e6:71e1:1a45:b7af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258b44b2sm4464719f8f.20.2025.02.14.04.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2025 04:29:29 -0800 (PST) Message-ID: <3de176d3-e484-473e-95ae-5d7d221bc839@gmail.com> Date: Fri, 14 Feb 2025 13:29:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: FFmpeg development discussions and patches , Zhao Zhili References: <95067355-1e79-4d4e-96e4-57257d04552d@gmail.com> Content-Language: en-US From: Leandro Santiago In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avutil/detection_bbox: Cleanup: Remove unneeded bbox_size struct member X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Oh, I see. I had not noticed that AVDetectionBBox was part of the public API, but it now looks obvious to me. Thx for pointing it out. On 2/14/25 10:56, Zhao Zhili wrote: > >> On Feb 14, 2025, at 16:47, Leandro Santiago wrote: >> >> There is no need to store this field in the struct, >> as it can be computed as sizeof(AVDetectionBBox). >> >> Signed-off-by: Leandro Santiago >> --- >> libavutil/detection_bbox.c | 1 - >> libavutil/detection_bbox.h | 7 +------ >> 2 files changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/libavutil/detection_bbox.c b/libavutil/detection_bbox.c >> index cb157b355b..456c35f87a 100644 >> --- a/libavutil/detection_bbox.c >> +++ b/libavutil/detection_bbox.c >> @@ -40,7 +40,6 @@ AVDetectionBBoxHeader *av_detection_bbox_alloc(uint32_t nb_bboxes, size_t *out_s >> return NULL; >> >> header->nb_bboxes = nb_bboxes; >> - header->bbox_size = bbox_size; >> header->bboxes_offset = bboxes_offset; >> >> if (out_size) >> diff --git a/libavutil/detection_bbox.h b/libavutil/detection_bbox.h >> index 011988052c..7844fb05da 100644 >> --- a/libavutil/detection_bbox.h >> +++ b/libavutil/detection_bbox.h >> @@ -70,11 +70,6 @@ typedef struct AVDetectionBBoxHeader { >> * the array of bounding boxes starts. >> */ >> size_t bboxes_offset; >> - >> - /** >> - * Size of each bounding box in bytes. >> - */ >> - size_t bbox_size; >> } AVDetectionBBoxHeader; >> >> /* >> @@ -85,7 +80,7 @@ av_get_detection_bbox(const AVDetectionBBoxHeader *header, unsigned int idx) >> { >> av_assert0(idx < header->nb_bboxes); >> return (AVDetectionBBox *)((uint8_t *)header + header->bboxes_offset + >> - idx * header->bbox_size); >> + idx * sizeof(AVDetectionBBox)); >> } > No, this field is for ABI compatibility. New fields can be added at the end of AVDetectionBBox, > sizeof(AVDetectionBBox) can be different between API user of libavutil and libavutil internal. > >> /** >> -- >> 2.48.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".