Re: [FFmpeg-devel] [PATCH 05/13] fftools/ffmpeg_filter: move filtering to a separate thread

[James Almer <jamrial@gmail.com>]

On 11/24/2023 7:56 PM, Michael Niedermayer wrote:
> On Thu, Nov 23, 2023 at 08:15:00PM +0100, Anton Khirnov wrote:
>> As previously for decoding, this is merely "scaffolding" for moving to a
>> fully threaded architecture and does not yet make filtering truly
>> parallel - the main thread will currently wait for the filtering thread
>> to finish its work before continuing. That will change in future commits
>> after encoders are also moved to threads and a thread-aware scheduler is
>> added.
>> ---
>>   fftools/ffmpeg.h        |   9 +-
>>   fftools/ffmpeg_dec.c    |  39 +-
>>   fftools/ffmpeg_filter.c | 825 ++++++++++++++++++++++++++++++++++------
>>   3 files changed, 730 insertions(+), 143 deletions(-)
> 
> This seems to cause a new assertion failure with this:
> 
> echo 'Call 0 ping'  | ./ffmpeg -nostats -i mm-short.mpg -vf nullsink,color=green -bitexact -vframes 1 -f null -

That's an interesting way to trigger the filter command interrupt.

> 
> Press [q] to stop, [?] for help
> 
> Enter command: <target>|all <time>|-1 <command>[ <argument>]
> 
> Assertion !fgp->frame->buf[0] failed at fftools/ffmpeg_filter.c:2987
> Aborted (core dumped)
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".