From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A31F94039B for ; Sun, 19 Jun 2022 10:07:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4EDBD68B58D; Sun, 19 Jun 2022 13:07:20 +0300 (EEST) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F62968B1AA for ; Sun, 19 Jun 2022 13:07:10 +0300 (EEST) Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4LQpNW3Ysgz9sWq for ; Sun, 19 Jun 2022 12:07:07 +0200 (CEST) Message-ID: <3d8477b5-a19c-8fa0-c12b-0e601e0faf74@gyani.pro> Date: Sun, 19 Jun 2022 15:36:55 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <165556470747.13099.7107809224178268483@lain> <20220619090242.11655-1-ffmpeg@gyani.pro> From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-06-19 02:54 pm, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Gyan Doshi: >>> Default avctx->frame_size is 0 which led to init failure for >>> audio MediaFoundation encoders since 827d6fe73d. >>> >>> The MF audio encoders accept variable frame size input buffers. >>> >>> Fixes #9802 >>> --- >>> libavcodec/mfenc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c >>> index 13ed7b3e11..8618e54ea3 100644 >>> --- a/libavcodec/mfenc.c >>> +++ b/libavcodec/mfenc.c >>> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx) >>> FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet), \ >>> EXTRA \ >>> .p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID | \ >>> - AV_CODEC_CAP_DR1, \ >>> + AV_CODEC_CAP_DR1 | AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \ >>> .caps_internal = FF_CODEC_CAP_INIT_THREADSAFE | \ >>> FF_CODEC_CAP_INIT_CLEANUP, \ >>> }; >> This will add this capability to both audio and video encoders, although >> it makes no sense for the latter. >> > This should actually been covered by the libavcodec-avcodec FATE test. > How did you test your patch? Manually. I didn't expect HW / ext lib encoders to be covered by FATE, and indeed I don't find anything for MF. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".