From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E8A9B49F76 for ; Fri, 15 Mar 2024 12:20:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 91F2768D137; Fri, 15 Mar 2024 14:20:04 +0200 (EET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 46D3A68CE16 for ; Fri, 15 Mar 2024 14:19:58 +0200 (EET) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e6bee809b8so1951975b3a.1 for ; Fri, 15 Mar 2024 05:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710505196; x=1711109996; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5csV7rQbEGqwsYFIjHf6B0W2k5KLeMAfp6kly7xA+8s=; b=eeAcobF7VHRPQOkuXPbkcmxDQRzKztKZm9/iMQu7dlph/qzlzcHxL7suTdbM/YVQKx iJjXKvfv97tJX8OHGXA2FssMFNLxGgUMUjv3ZWA8dQr8zGuRauVTKZMKQQfHOzYsSO7m KmOUcK08hWyee5iNTAeHqK5XrzeomPKmwRom3+w5tlYxVjsu5JEZN1X2fW2hhybY6Pfe QI7Ve7bu6g4JpKrRsLvE1v6PuU92eX+A5Kl5XgACAae5mONGtMcr7c1azydh+CIth8N1 G3S7wYue+IF5CAPiJMFymC1SmSNZsPlzTQlmRxBTj2Cdl2LKhV55n2DUMR0oGbSp7XTj no3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710505196; x=1711109996; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5csV7rQbEGqwsYFIjHf6B0W2k5KLeMAfp6kly7xA+8s=; b=qYTJJybOEb1D+O4P+JIKmVfRvjbvjix1HVKGcb/ILJPKldrnwW8hH1WBCpd2URFQ+0 jxQWj3KVInA2OQT9ho4lBsXm7Tp4SOjP0FucBQzeNFvl/R9um1mFDyRbRWzSyORk3+lR AUO8yq92jKh+QOCfdLWcubaZDtdtOqgm0w9zZzagoSw+e/XN1FJdu/VN735mgEUWUjOf MCb8IyxxsuRe1h++sP4J31/DcmcAb4aXEgFTB41ttOX9vyHZkUfhJf2jursP2VCWA9eY FxtnymbSSa4dPk3jegvKZpLOrmcZJ2kpHctD8mPj4boXEdtTwME1Qu4KBIC0Emaz1ucs WXqQ== X-Gm-Message-State: AOJu0YxMRH9nqCQ4xT6PSZC6Iw1SMI0lcsis4Y7WVQ3WjIt4sRAPiCKJ Qm/fx2JRpwE04CbQJQykPgb9hYM3hs6OG/pOjjUMM60jAk32MvWL2YdH4xbE X-Google-Smtp-Source: AGHT+IEb69yR+ZMhBv+siVUiPrXxegG6R8ZGxDRYDui0wpSdK96G09wj19tkFaJvsq6kTwxjj1IfDA== X-Received: by 2002:a05:6a21:181:b0:1a3:26b5:c7bf with SMTP id le1-20020a056a21018100b001a326b5c7bfmr3708267pzb.47.1710505195698; Fri, 15 Mar 2024 05:19:55 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id o7-20020a17090a420700b0029bc9c34a39sm2750403pjg.50.2024.03.15.05.19.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 05:19:55 -0700 (PDT) Message-ID: <3d6a36d1-d9fb-4090-a286-382a6379fa42@gmail.com> Date: Fri, 15 Mar 2024 09:20:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240315120442.73754-1-ffmpeg@haasn.xyz> <20240315120442.73754-3-ffmpeg@haasn.xyz> From: James Almer In-Reply-To: <20240315120442.73754-3-ffmpeg@haasn.xyz> Subject: Re: [FFmpeg-devel] [PATCH v3 2/9] avcodec/av1dec: initialize AFGS1 VSC metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/15/2024 8:58 AM, Niklas Haas wrote: > From: Niklas Haas > > Unused by AV1, but should still be set properly. The doxy for av_film_grain_params_alloc() says "Allocate an AVFilmGrainParams structure and set its fields to default values", so this should be done there. > --- > libavcodec/av1dec.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index e6346b51dbe..8a5796c757f 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -1124,6 +1124,10 @@ static int export_film_grain(AVCodecContext *avctx, AVFrame *frame) > aom->uv_mult_luma[1] = film_grain->cr_luma_mult; > aom->uv_offset[0] = film_grain->cb_offset; > aom->uv_offset[1] = film_grain->cr_offset; > + aom->color_range = AVCOL_RANGE_UNSPECIFIED; > + aom->color_primaries = AVCOL_PRI_UNSPECIFIED; > + aom->color_trc = AVCOL_TRC_UNSPECIFIED; > + aom->color_space = AVCOL_SPC_UNSPECIFIED; > > return 0; > } _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".