Re: [FFmpeg-devel] [PATCH v3 2/9] avcodec/av1dec: initialize AFGS1 VSC metadata

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 2/9] avcodec/av1dec: initialize AFGS1 VSC metadata
Date: Fri, 15 Mar 2024 09:20:04 -0300
Message-ID: <3d6a36d1-d9fb-4090-a286-382a6379fa42@gmail.com> (raw)
In-Reply-To: <20240315120442.73754-3-ffmpeg@haasn.xyz>

On 3/15/2024 8:58 AM, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> Unused by AV1, but should still be set properly.

The doxy for av_film_grain_params_alloc() says "Allocate an 
AVFilmGrainParams structure and set its fields to default values", so 
this should be done there.

> ---
>   libavcodec/av1dec.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index e6346b51dbe..8a5796c757f 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -1124,6 +1124,10 @@ static int export_film_grain(AVCodecContext *avctx, AVFrame *frame)
>       aom->uv_mult_luma[1] = film_grain->cr_luma_mult;
>       aom->uv_offset[0] = film_grain->cb_offset;
>       aom->uv_offset[1] = film_grain->cr_offset;
> +    aom->color_range = AVCOL_RANGE_UNSPECIFIED;
> +    aom->color_primaries = AVCOL_PRI_UNSPECIFIED;
> +    aom->color_trc = AVCOL_TRC_UNSPECIFIED;
> +    aom->color_space = AVCOL_SPC_UNSPECIFIED;
>   
>       return 0;
>   }
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".