From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 37EFD49E00 for ; Tue, 12 Mar 2024 03:34:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8FC1468D0B0; Tue, 12 Mar 2024 05:34:08 +0200 (EET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5C67168D083 for ; Tue, 12 Mar 2024 05:34:00 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710214446; x=1741750446; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=9/eLPvpzQMV11/di6y0Shmi+yySpcBz6GWzHeN5TOw8=; b=XoAvPQdJIFt69S7AFwg0es63KndHkinDMa/Qye4CGA4RDq8tTZyjbB5K 7csUsV6A3AcEGspi7rOG7c8nZYNCgObMohhEIGAgUC0muN1XuEKM5ZzVZ uHSbz4AfcTaJ6PllgYWsdjsFwqhHgR4J+Df5WB7qSS6v/JdNFKKsTEBBg 5gXnGK/HpI+diKzy4yzfjPm/PepJRWPpXFZv6h6kVU6qXKac+dxTnjv3B BMOPdK3k7hI3bQV9SEUWMpT+VagW8xbPvnp5+P894lU2yDYvUPfGASPVj Xt6tkC4Zyt/dqXOHHbpyFsgCtrvnWS595Ypxxbh0Z/Y0KMpAK68Orbfw6 w==; X-IronPort-AV: E=McAfee;i="6600,9927,11010"; a="8670134" X-IronPort-AV: E=Sophos;i="6.07,118,1708416000"; d="scan'208";a="8670134" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2024 20:33:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,118,1708416000"; d="scan'208";a="11296411" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Mar 2024 20:33:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 20:33:55 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Mar 2024 20:33:54 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Mar 2024 20:33:54 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Mar 2024 20:33:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRdSJKrKEVtPHO5KxICWw1rsOhsBUTODS2tKIxkqV91L6aCuLYi+T74UTuiRd/3jXz/73te6xBAe2OTRM1kIdICYsZD3Q1Dsll5ymzZwM14w3Qt4F3dSHHx89BS9Plpw5nprv5W13FWZqyDVztrWyIbHmNeQfYW/I6BvUDEbhQ09ySsrpzhGVjZLSeq+SNPrtUGPoPHr9sZzOBFL/6W20pQBWxe/FE+YoeZJiM2dAgeL6CcIjQI+KTzYXjGX/NzagMpaGA/tILlP1zMUKb/ikPtLZhOLSphccxa07xjMarIZVHm7pFH9/4Sc3KKnlpwZR9Bv3ToN5LUafBwZQ7MwpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/eLPvpzQMV11/di6y0Shmi+yySpcBz6GWzHeN5TOw8=; b=ORZplOW1hiL/2EJHJtGMj9a9j2dhlhGAS5chZ4zltvhCVvnZSvLBJ+CPAn7BS0M4kBmy9Ab/17IZzbczaPo+frrf7/e36BoWI4VbMh0OiPzX83LcH5WqWG83VVkcEbuFrwxwYoT3eWH4X1uWvtLxz9AGYy1TdAsFydhiYWpuom691X1F6ESg0UTUk2Fz0YKgRof46ZmVO2ij5djEzCksNI3FS0YORLvGRYjvhmWG0pc29J/0Dt783nh5pidBFPr5dpsSipTAnhrVE126VeZ+4sTueCIXQkWjYe4NxxYDSITSjhQX4s8cjk7W2vgIpxmgYdDOBK927thjudI0gW+NkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by MN0PR11MB6012.namprd11.prod.outlook.com (2603:10b6:208:373::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.17; Tue, 12 Mar 2024 03:33:52 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::566d:2e2d:1fa3:d511]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::566d:2e2d:1fa3:d511%4]) with mapi id 15.20.7386.005; Tue, 12 Mar 2024 03:33:52 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] lavc/vvc: AVERROR_PATCHWELCOME for subpictures Thread-Index: AQHac+WBU9/0Xh6CJ0aJaUnQykGx7LEzRnCAgAACW4CAACuvAA== Date: Tue, 12 Mar 2024 03:33:52 +0000 Message-ID: <3d233448d9d0c35b7764f061e00667bdb5f5d232.camel@intel.com> References: <20240311185331.84556-1-post@frankplowman.com> <20240312004919.GV6420@pb2> <15ff0462-6e6b-40bc-a691-3dc3389b20d5@gmail.com> In-Reply-To: <15ff0462-6e6b-40bc-a691-3dc3389b20d5@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|MN0PR11MB6012:EE_ x-ms-office365-filtering-correlation-id: ec7c5d5c-39fa-42c4-6b09-08dc42453d00 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b5Ls4T7S4NKSHXJaJmOYzyaq+/W1TN3e/c6LnLgI8CCODip0wCPjx9mqpRltjs5FD1WJqmhNdJ4OP2dqRsQlHAw7sfKRanJG4tLbfVMpoj+hVMOzlE3Zsaz2Oy+f73Klgy0Kxo68bOUCHh5R/rkfF0XYg5HGbL1gMFNJCRs2+d7CYAV6lIrsATjqUPBUxLl42pYXu0ehxcE3Z4FCI0heKqbw6uiy9pU6bHRK9Yks3kpPum78KRfelgVWVEbNAAVfw6Lm9WJCtFK7bf6gZo3yChCWxRX5UGhNMngZITJcfyQ/Zw5iCYcsI7JlgQ011TX4Qq1/QoUGQUoOx1UHKYA2kZYUe9asl4FVvvK/YKQ+HxY+r10HkhZxgoK4gb5SvZUyK7cnvbgRsEdk8IbGbaMMfot2eGtqML6P03TR2/jIDSyWX3Uz0N5pGwj9/VATJ2r37EHk5d8YU90zBhIkgwvEX9omZLXWI0K4qs3hgc77QInlYlViAMcPRqdN8v6rwLHByK3ju5mpLXiXVVPX1emge/2PePdgjlS+8RjZ2TiwA+7WYGalXwu733nV3VRNCVNla1MU9TEBtlEMipmaKpCleTJlKV7Xng2pzaB85MxjVhN5Mau4035UJ6repqO48AqNhU7j4a3Pk743BxzHm2Y7I2qO4b4eojmz8XLgo7qoZwA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VWxMai9OTmRhRmk4aVNGOTB5VEppa1RpdFhrOWhMSHpaSk03MXJJMTczOGxD?= =?utf-8?B?cGdjanp2Z2M4Z1Bndlpzd1ZsNXpkNGdUcWNSVnRJMUtpb1JRZWJkQmlEQW9B?= =?utf-8?B?WmVpQkg2VFVJWm4xT0U0TGdVZFZRRmJPSlhobXoxMkFXTlRjM0VCeDZGeTIy?= =?utf-8?B?Z1ExQXJ1aVJqNkFWaFVvN25DanpxZlBjeXpCdDZmYnFja3psMnpBYktrSUw4?= =?utf-8?B?WFYrcW1LUjlYNzVZbVozRmEyY2JYV05MZUhTTFdmN3ZJV2RkTWc0dmcxWWx4?= =?utf-8?B?eUF4bkFTbWlQeFAzZmg4dDlyMnAxeHJtUjMwTWF4WkhETW5adC96dUhYc0pY?= =?utf-8?B?c2t2RHlLNHltblBuOGI1bUJ2K0dUZ0RISCtLM1RUUmNRR0k4MGdxQ0VLY1lF?= =?utf-8?B?Ri9pMEdxS0dTTjhUTlNSMWtaNUNNaGdVZit2aFpRNFNSLzdqS0xtdEgrTEI4?= =?utf-8?B?cE8wODI4TW12OFpYM1F0eTdjUG8vQjRYYmpvVUw1dVd0THFhTExTR1liRkdY?= =?utf-8?B?cUhBYVY2cVFrdWExYUMzTmVaSTd0UU9kdHc2eVdLRklDRnBMdUtLWUNaTUhq?= =?utf-8?B?T3hNQmlRSGlRdHltZUtrR2dURE40U3pWcWxrQzkra2txZ3NIRTlGSWFNUWpH?= =?utf-8?B?VTdWUGpwaDVjUlYxSUQwNDFoQ3Z3RnJweW5xZVl4aThYTnd6Qi9MMzNGa0FG?= =?utf-8?B?cU55ZTJjVlFCbHBlN1pDR2cvYlZUeEFtNzdFY2dKejMwVjYxWEMwWVNTVkV5?= =?utf-8?B?RGV5VHhTYjA1OHdKSzU3QWJ1RzZzWGdwRGQwYWtwcHJnaUxlYktkdHpsdDJI?= =?utf-8?B?NVBiQ1hRTUFoMHIrYjRxSFBpV2RFOHJxSENQZThjVG4xYWw4R1pjSC9VMzVV?= =?utf-8?B?M3ZGL2hPUEUzZ3cyeThrTURIT0VwUDVkRzlEYnJuN3MvZm1Rd1hpMDZvVWZV?= =?utf-8?B?MzhieDBmNjFqanJQWVQ5eWtDN2I3STRRUUZNemFDYmtuVlE0N0tMbHBnaXh6?= =?utf-8?B?SXFPV2J2MmhDRXVEUHhzVTBrdjY0djViZ1ppdUI1V2huSlY2c1N3UmVGbmxP?= =?utf-8?B?OVA0TDMzdTZFaC9OdVJMSmZZM2FjUnNTaHlMUE95TnVJMDh2SWNZbEJBTWFH?= =?utf-8?B?T29TT0hKVUx5QW9lZXZySzlsZnRKRC9lSFAwbEU1OEQwQUx3bmc4VFU3bXhT?= =?utf-8?B?SEl6MGtBeVBpblFqMzdKQytoRlpPZEhKOGVhNUNFaEp3ZmpUM0xuamZWL2Rt?= =?utf-8?B?UGVJblBlQzZrSUZWT1d4U2RldWpZbFEwc1dISDc1VDdkdlUyZDVVQisxcWIw?= =?utf-8?B?UUY2ZERrak82d0daQXJUTEU4VjdzZVJHTnV4MVZuTVNOTnR0TGtQUDJwZjhx?= =?utf-8?B?K0N1ZDU1dnFhVXlzL21SNUZlQk04K3hHY2RiTVlPYStFWlRVSkpoUllBRkpN?= =?utf-8?B?UmFXcjE2RmQvd3BVNkZvRGZ2TUdDd0tYbWtVK3NNaEZTZlhqbnNCcHNWTzcy?= =?utf-8?B?RVpGYnE1L2RIbk9MOXVhNGMzclA2M25FWTFLSWpzQlNBVDY4bG1lNWFDdUtj?= =?utf-8?B?cEtzMnNXdTM0aWx3NWpvc2VlK3FVQzRkZTJhN0lNbzZwbTJLT0doTzJsMXRk?= =?utf-8?B?YXRMNFJON0I2bTUvWFdHMXgwZW9OUGNuQzh2MVpZU01QcmpCMGRuQmZBY1hy?= =?utf-8?B?bUFZNkJ6UVJGWW9ZeHJiWDlIN3R1WTY4M0s4VktnOXBqZW5oSDRqOGMyTTBT?= =?utf-8?B?K0hFaTNwUGdvdnBMcElGUjBIY09VRXZmS2VVUlZKaGpBcUZpSTJCNUluS0F0?= =?utf-8?B?SXorQjI2Z3ZsVTRGLzhwOTBoWU5oWUZPbk5CZXNPdWNuQ2RXTWFSTUd3Y05k?= =?utf-8?B?akR0SVYyb3U5YnRmTDdwbHBiMWhSRDZSU0JsMFoxTHlraW1KbU1nTmtIN2VJ?= =?utf-8?B?NkhzNUJKamMxTVVpTy9ERzBvNTRVc1ZZRnpkbWYrNS9EVkFKbE9pS2hpSjZO?= =?utf-8?B?WURnTVdXenRYZVYxbUg4clhqcHZRcDVQRlJpQnhsRWxDdlNUd1NoTTZTMXp4?= =?utf-8?B?TTUrM1h0THUvWEt6dWFmZ2hGK09uSUhCK2d0WTdoaC84R0cycFM2UGE4elRk?= =?utf-8?B?Q1dxQVZmZjVIOWNNcXNUM25UczdFN2NJcjFvWnI2d0dUQVlqeGhVa29PWjBZ?= =?utf-8?B?NkE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec7c5d5c-39fa-42c4-6b09-08dc42453d00 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2024 03:33:52.3182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wiKOW0cihHX2ssSrcSrdGv8Zcbs4Q+E8Da1M06RktrdJGyAeV0eQywtpdgrVJWnHsmKqv9M1lhx65A/gV6R5xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6012 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavc/vvc: AVERROR_PATCHWELCOME for subpictures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2024-03-11 at 21:57 -0300, James Almer wrote: > On 3/11/2024 9:49 PM, Michael Niedermayer wrote: > > On Mon, Mar 11, 2024 at 06:53:31PM +0000, Frank Plowman wrote: > > > VVC's subpictures feature is not yet implemented in the native > > > decoder. > > > Throw an AVERROR_PATCHWELCOME when trying to decode a bitstream > > > using > > > the feature. Fixes crashes when trying to decode bitstreams > > > which > > > use the feature. > > > > > > Signed-off-by: Frank Plowman > > > --- > > > libavcodec/vvc/vvc_ps.c | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > This breaks fate-vvc-conformance-SUBPIC_A_3 > > > > make fate-vvc-conformance-SUBPIC_A_3 > > TEST vvc-conformance-SUBPIC_A_3 > > --- ./tests/ref/fate/vvc-conformance-SUBPIC_A_3 2024-03-05 > > 02:37:36.235300141 +0100 > > +++ tests/data/fate/vvc-conformance-SUBPIC_A_3 2024-03-12 > > 01:47:27.301593567 +0100 > > @@ -1,9 +0,0 @@ > > -#tb 0: 1/25 > > -#media_type 0: video > > -#codec_id 0: rawvideo > > -#dimensions 0: 1920x1080 > > -#sar 0: 0/1 > > -0, 0, 0, 1, 6220800, 0xa419cfb6 > > -0, 1, 1, 1, 6220800, 0xa419cfb6 > > -0, 2, 2, 1, 6220800, 0xa419cfb6 > > -0, 3, 3, 1, 6220800, 0xa419cfb6 > > Test vvc-conformance-SUBPIC_A_3 failed. Look at > > tests/data/fate/vvc-conformance-SUBPIC_A_3.err for details. > > tests/Makefile:318: recipe for target 'fate-vvc-conformance- > > SUBPIC_A_3' failed > > make: *** [fate-vvc-conformance-SUBPIC_A_3] Error 69 > > > > thx > > The sample appears to decode fine and doesn't crash, although all > four > frames are exactly the same (I don't know is that's intended). The result is correct. Assume native decode can handle subpic, at least a part of the feature. > Maybe the crashes can be fixed in some other form? And abort only if > FF_COMPLIANCE_STRICT is requested. Previous I made a patch to fix the crash in setup ps, but still get error in decoding slice, it's better to return AVERROR_PATCHWELCOME only in case of pps_single_slice_per_subpic_flag. https://github.com/intel-media-ci/ffmpeg/pull/723 Thanks Fei > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".