From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id F2A3F49F75 for ; Fri, 15 Mar 2024 12:25:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AA3C68D13D; Fri, 15 Mar 2024 14:25:55 +0200 (EET) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 018BF68CB9F for ; Fri, 15 Mar 2024 14:25:48 +0200 (EET) Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6e6738f7535so940418a34.2 for ; Fri, 15 Mar 2024 05:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710505546; x=1711110346; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VX6ka5IDrcHyPXATFhDkUaBOVao29oaGFrJGgNaAptU=; b=UHGEMXljdJ+4S4nRlQ7FBVHxtz7URi8Y1KcO9G7rx+1M95V0cOMVQjRNefxURmRlzN dpBRL+Fgznopz6LJb98ViwVu7Mc+B033BfM/aHYUgNAAn4Y5pR9rRblV2xddrDIYnVFL wLLcMmgcDQziYsE7FY4SC2QJF/uyqxudyy/F+kZMfLPMmBv0tEFc2xAUxZojR5Yq28LU NhRC97PXfLAdqeYq8Qytq76c+aP4JzeLudJqzTd61463Z8kgaA9KSFOUSBRjZt9pwbXR z8m4Y3RGZt6WSWTocTE39qeCmSp8Nq2KOGavPojOdJRaOpZqPv8ekKybFb6BuZiwqNki 7Qfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710505546; x=1711110346; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VX6ka5IDrcHyPXATFhDkUaBOVao29oaGFrJGgNaAptU=; b=RHnvT6at+B8YF+HJJSdkOHIUNA6spB9XI+knSdivrtv+skrT3dosQ6X2NsCNpt9zV4 NLc4fy30BsqmXvYz13Qg6zng0EIcnaD+GLfF6poSUflMLKyIxDjN7rEM4GW1kHQ+PduJ 789oMh3RgN+pTrfJx258+RPycemcMLnq8/4AiyuddtqoO/5QKMhhJ1bwfnso9aAqmCYZ 55QC7GTceKXRoB84SqYdlTjM/g9o4U9bVj/TdFspHvOoRgU7gSfwG1wWfBBBUuXfFsrZ VmGr4lrDNVuJeem/KvLrUlVaaH9oe9D9Nq2NyVHy+YiewsuhyTJudilNyELzuNlst1C4 gZcw== X-Gm-Message-State: AOJu0YyhiIn+8HnJxetzRdoT9rHoCcallx6oSIQd4xvR6BsNJI7J4+o0 nA+yHMiWb/+KKyY61OIW1s35xKcJ4pqyRdT/BVPWh6ehoicKJ9HBQDkep+0A X-Google-Smtp-Source: AGHT+IECMt26dDWQthk8w8tgj9t7Ijs1WIVfYYY45R1NQp1Yj+tvv54tncpQmaKp4UQbsqxl70gbCA== X-Received: by 2002:a05:6870:b14d:b0:221:45a1:b72a with SMTP id a13-20020a056870b14d00b0022145a1b72amr3715817oal.35.1710505546239; Fri, 15 Mar 2024 05:25:46 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id g20-20020aa78754000000b006e672b48b49sm3275286pfo.157.2024.03.15.05.25.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 05:25:45 -0700 (PDT) Message-ID: <3d1c8f7c-9aa3-45b3-a777-e75bba2fcb10@gmail.com> Date: Fri, 15 Mar 2024 09:25:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240315120442.73754-1-ffmpeg@haasn.xyz> <20240315120442.73754-3-ffmpeg@haasn.xyz> <3d6a36d1-d9fb-4090-a286-382a6379fa42@gmail.com> <20240315132347.GD76907@haasn.xyz> From: James Almer In-Reply-To: <20240315132347.GD76907@haasn.xyz> Subject: Re: [FFmpeg-devel] [PATCH v3 2/9] avcodec/av1dec: initialize AFGS1 VSC metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/15/2024 9:23 AM, Niklas Haas wrote: > On Fri, 15 Mar 2024 09:20:04 -0300 James Almer wrote: >> On 3/15/2024 8:58 AM, Niklas Haas wrote: >>> From: Niklas Haas >>> >>> Unused by AV1, but should still be set properly. >> >> The doxy for av_film_grain_params_alloc() says "Allocate an >> AVFilmGrainParams structure and set its fields to default values", so >> this should be done there. > > This function doesn't know whether the film grain is of type AV1 or > H274, and so cannot set the correct codec-specific parameter defaults. > > Unless, of course, we add these fields to the common struct, as > discussed above. (Or if we add the type to the function signature) We can't change the function signature, but we can add the fields to the common struct. Just leave a comment about reordering the fields in the next bump (Which hopefully will not be forgotten). _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".