From: Frank Plowman <post@frankplowman.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: Fix compiling with MSVC 2022 17.8 and older
Date: Thu, 27 Jun 2024 08:47:29 +0100
Message-ID: <3d1ae7b0-c935-417b-ae36-26ad841028ef@frankplowman.com> (raw)
In-Reply-To: <20240626082040.40005-1-martin@martin.st>
On 26/06/2024 09:20, Martin Storsjö wrote:
> Versions of MSVC older than 17.9 error out here with the following
> error:
>
> src/libavcodec/vvc/filter.c(815): error C2059: syntax error: '}'
> src/libavcodec/vvc/filter.c(832): error C2065: 'all_zero_bs': undeclared identifier
> src/libavcodec/vvc/filter.c(836): error C2065: 'all_zero_bs': undeclared identifier
> ---
> libavcodec/vvc/filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/filter.c b/libavcodec/vvc/filter.c
> index 2cadaaaf22..7ffcb29f47 100644
> --- a/libavcodec/vvc/filter.c
> +++ b/libavcodec/vvc/filter.c
> @@ -812,7 +812,7 @@ static void vvc_deblock(const VVCLocalContext *lc, int x0, int y0, const int rs,
> for (int y = y0; y < y_end; y += (DEBLOCK_STEP << vs)) {
> for (int x = x0 ? x0 : grid; x < x_end; x += grid) {
> const uint8_t horizontal_ctu_edge = !vertical && !(x % ctb_size);
> - int32_t bs[4], beta[4], tc[4] = { }, all_zero_bs = 1;
> + int32_t bs[4], beta[4], tc[4] = { 0 }, all_zero_bs = 1;
> uint8_t max_len_p[4], max_len_q[4];
>
> for (int i = 0; i < DEBLOCK_STEP >> (2 - vs); i++) {
LGTM.
--
Frank
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-27 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 8:20 Martin Storsjö
2024-06-27 7:47 ` Frank Plowman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d1ae7b0-c935-417b-ae36-26ad841028ef@frankplowman.com \
--to=post@frankplowman.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git