From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D89B24A5CB for ; Thu, 2 May 2024 20:00:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 022AB68D82B; Thu, 2 May 2024 23:00:18 +0300 (EEST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 36AA868D70D for ; Thu, 2 May 2024 23:00:12 +0300 (EEST) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-41bab13ca81so65231915e9.1 for ; Thu, 02 May 2024 13:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jkqxz-net.20230601.gappssmtp.com; s=20230601; t=1714680011; x=1715284811; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VzFDITHnaI8Soc7wmP7Ub4vCuKIDxZ1uumuRCGQps6c=; b=LInfpPNOl0A1dE7pasauGw0LfKcZ1pK5VEDOX3/rOhWZFdggEWEpvAzLr5fs8Edxw9 +uGvDkeeBWi02rW+8lPZgJng3Hxa9WI5VEWyE7I+V9ZW+NuTiFZGu6zR/c3wrDCZJrAN 3uo7glqiVXos8xapFMMZoRonLtE6OFjpFYTacoGqhSLdAk1tD/L+2gAus7L6fY5hxDyd MJcuRU9tnQcAdByU6MaVqtPM5fB8y1Is5oNslHsZiSVOCa1QjNF6XCIRizDCTCABMENA 4a8lAswugOBYSmWjffP1MQJKvtwD3IztjeaAP/IO8MNpr7tbeCjTDRBqgT3T+14mwS89 hHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714680011; x=1715284811; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VzFDITHnaI8Soc7wmP7Ub4vCuKIDxZ1uumuRCGQps6c=; b=VzX2YtMgHlbAJEDCxHy2HzpmrfvsrrLngGW1PbBQPG9E/1SqDO6m2Bgnp9SabBnGcE J1+O1G2ulXjFC9bA/+Gx5ET7q71Tsyo0kLszhqY+lB/XvctYD/jAbv0QRj//q4bKHwwm XoH7enqrKA6hFiAs+CB7FYYH4+bUQB5qWw7Xfy11v4UIu3nzyRN8kEnz/OnAPIbKudPN Eg217qRG9KciSxGsEegL2Rqik1pqMz8LLm1TmgVxmkz5tPUc0tNg9hYM/KDC+uJ1NfRx ZRP42h1lgabCVx9JGNuipEEhv8UbiyQb9XT+3Gmk7l5l2prKLGvrQZnnSrTw6wBFKab0 ciGA== X-Gm-Message-State: AOJu0YwIa8IceKfuYQSXZGhgpTgvc0CMMbTRFSU6XMgQTkuOm8virxVc U/Z3LkkpvvmLQdO4I6x4tRUCxfXNhHj50xm5Q8TjrSukQf28Cwr76TV1nq2wOPInmQUGKzRWM5l o X-Google-Smtp-Source: AGHT+IEq2p5CoIcta+yM5Hi4o+YkqQIjhqk5nPs7MWEwaWzpeHblteNzsyHPiOneZk5EsrURO4ZgZg== X-Received: by 2002:a05:600c:35ca:b0:41a:2c91:6352 with SMTP id r10-20020a05600c35ca00b0041a2c916352mr764960wmq.36.1714680011196; Thu, 02 May 2024 13:00:11 -0700 (PDT) Received: from [192.168.0.15] (cpc92302-cmbg19-2-0-cust1183.5-4.cable.virginm.net. [82.1.212.160]) by smtp.gmail.com with ESMTPSA id bd23-20020a05600c1f1700b0041bfb176a87sm6793609wmb.27.2024.05.02.13.00.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 13:00:10 -0700 (PDT) Message-ID: <3d15252d-691c-418d-ac95-c41e193a4382@jkqxz.net> Date: Thu, 2 May 2024 21:00:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240501183809.1060-1-ovchinnikov.dmitrii@gmail.com> <20240501183809.1060-2-ovchinnikov.dmitrii@gmail.com> From: Mark Thompson In-Reply-To: <20240501183809.1060-2-ovchinnikov.dmitrii@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 01/05/2024 19:38, Dmitrii Ovchinnikov wrote: > From: Evgeny Pavlov > > Added AMF based h264, hevc, av1 decoders. > Co-authored-by: Dmitrii Ovchinnikov > v2: added encoder reinitialisation > --- > libavcodec/Makefile | 7 +- > libavcodec/allcodecs.c | 3 + > libavcodec/amfdec.c | 719 +++++++++++++++++++++++++++++++++++++++++ > libavcodec/amfdec.h | 72 +++++ > 4 files changed, 799 insertions(+), 2 deletions(-) > create mode 100644 libavcodec/amfdec.c > create mode 100644 libavcodec/amfdec.h > > ... > + > +static int amf_decode_init(AVCodecContext *avctx) > +{ > + AvAmfDecoderContext *ctx = avctx->priv_data; > + int ret; > + enum AVPixelFormat pix_fmts[3] = { > + AV_PIX_FMT_AMF_SURFACE, > + avctx->pix_fmt, > + AV_PIX_FMT_NONE }; > + > + ret = ff_get_format(avctx, pix_fmts); > ... > +const FFCodec ff_##x##_amf_decoder = { \ > ... > + .init = amf_decode_init, \ > ... This is still fundamentally incorrect. See my reply to the previous posting of this patch: . Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".