From: Mark Thompson <sw@jkqxz.net>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec.
Date: Thu, 2 May 2024 21:00:38 +0100
Message-ID: <3d15252d-691c-418d-ac95-c41e193a4382@jkqxz.net> (raw)
In-Reply-To: <20240501183809.1060-2-ovchinnikov.dmitrii@gmail.com>
On 01/05/2024 19:38, Dmitrii Ovchinnikov wrote:
> From: Evgeny Pavlov <lucenticus@gmail.com>
>
> Added AMF based h264, hevc, av1 decoders.
> Co-authored-by: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com>
> v2: added encoder reinitialisation
> ---
> libavcodec/Makefile | 7 +-
> libavcodec/allcodecs.c | 3 +
> libavcodec/amfdec.c | 719 +++++++++++++++++++++++++++++++++++++++++
> libavcodec/amfdec.h | 72 +++++
> 4 files changed, 799 insertions(+), 2 deletions(-)
> create mode 100644 libavcodec/amfdec.c
> create mode 100644 libavcodec/amfdec.h
>
> ...
> +
> +static int amf_decode_init(AVCodecContext *avctx)
> +{
> + AvAmfDecoderContext *ctx = avctx->priv_data;
> + int ret;
> + enum AVPixelFormat pix_fmts[3] = {
> + AV_PIX_FMT_AMF_SURFACE,
> + avctx->pix_fmt,
> + AV_PIX_FMT_NONE };
> +
> + ret = ff_get_format(avctx, pix_fmts);
> ...
> +const FFCodec ff_##x##_amf_decoder = { \
> ...
> + .init = amf_decode_init, \
> ...
This is still fundamentally incorrect.
See my reply to the previous posting of this patch: <https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-February/321500.html>.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-05-02 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 18:38 [FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 02/10, v2] avcodec: add amfdec Dmitrii Ovchinnikov
2024-05-02 19:55 ` Michael Niedermayer
2024-05-30 14:21 ` Dmitrii Ovchinnikov
2024-05-30 14:26 ` Andreas Rheinhardt
2024-05-30 14:41 ` Dmitrii Ovchinnikov
2024-05-02 20:00 ` Mark Thompson [this message]
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 03/10, v2] avcodec/amfenc: Fixes the color information in the output Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 04/10, v2] avcodec/amfenc: HDR metadata Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 05/10, v2] avcodec/amfenc: add 10 bit encoding in av1_amf Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 06/10, v2] avcodec/amfenc: GPU driver version check Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 07/10, v2] avcodec/amfenc: add smart access video option Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 08/10, v2] avcodec/amfenc: redesign to use hwcontext_amf Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 09/10, v2] avfilter/scale_amf: Add AMF VPP & super resolution filters Dmitrii Ovchinnikov
2024-05-01 18:38 ` [FFmpeg-devel] [PATCH 10/10, v2] doc/filters: Add documentation for AMF filters Dmitrii Ovchinnikov
2024-05-01 21:10 ` [FFmpeg-devel] [PATCH 01/10, v2] avutil: add hwcontext_amf Lynne
2024-05-02 8:04 ` Dmitrii Ovchinnikov
2024-05-02 8:36 ` Lynne
2024-05-02 20:27 ` Mark Thompson
2024-05-30 14:33 ` Dmitrii Ovchinnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d15252d-691c-418d-ac95-c41e193a4382@jkqxz.net \
--to=sw@jkqxz.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git