From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6AE08479C5 for ; Sat, 27 Jan 2024 12:25:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D13AE68CF80; Sat, 27 Jan 2024 14:25:08 +0200 (EET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5283268CBFD for ; Sat, 27 Jan 2024 14:25:03 +0200 (EET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d75c97ea6aso8695975ad.1 for ; Sat, 27 Jan 2024 04:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706358300; x=1706963100; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=BKg7qRl4/yi0XBhkpzsTj0JZG+tP4xDzwF4aiPamLOw=; b=cky7xWj2IAGkIeIavDPGQ/5dmBOiu30hlyj+9LywbWCl11yAthS1Gaipm5JfX7DAM7 Qcv3KAHMOQlVOqhDfzw56ooQ1I1mAq7dhEaFHdpkuYZEca/7t3rfiH2qF2c33K1BkWra ykjsXZY4a7dbI6qLcruaRDGZXhR2sE+2yVR14gGDM0qBB36ARNxr7insDg8xvW9e1xRW +XTnxyuWV5Md3v06C0XlbkdycnAbL8SIrp4QW4yxAjekFNbKHzdoQJm2ymG7No2wTMsX MoBUzfieJOJo2o4Ezpz2XdHFdaq+29zDz2nFM5JB/NFLb5rJRvJzJFIDeLydYQZe9lYy 48yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706358300; x=1706963100; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BKg7qRl4/yi0XBhkpzsTj0JZG+tP4xDzwF4aiPamLOw=; b=DPek9fDbarc7X0xtCUrDv5rNi32PTRQqlL6ZPROdCh2ZFnYuh+zOt9xEiqoYOMdkS6 lOIybaTCFtsv3gKN6DZd2DW1372hZ8tGNZl8Pd59aIGK9aas3JqgfnZrsfEKpEyZJ6kj 7d8K/+FSu6syOLWasS7Rbus2LX2Z13bFo5HjuAgP5QV3eUrBmrZ89in9+QUqgXafo6tC WV+MSSWYprXEn1M/badby/H87wDJngO20QThiYPQb+oqTxbw0vrOanqtocegXlsNxBEB GS8ycuxy0180pLt6p1anp8sBMeGEIJ2h97QJF7vr9Hgndjwj00Ymqu5RFQhOxpWFCvoX DdOw== X-Gm-Message-State: AOJu0Yx2pieT+hXKlCnLKLibWEQpiLEpLgDhjDsnOWoxEwrEh4om9/5S arWI4+zLPJI9sUfZhaUdJ9dIGlIgjmN4HgdGMa6TvQI5/YlCvRZ6knAVEV9o X-Google-Smtp-Source: AGHT+IGjrfUwoGA8MBYCK7RIISqKTLOGtFFbUICshgn83/XKgCYvb2/Q4ZRppNOAGjeaWPFi1VPeQA== X-Received: by 2002:a17:902:8b81:b0:1d7:6c6:9fca with SMTP id ay1-20020a1709028b8100b001d706c69fcamr2761773plb.30.1706358299956; Sat, 27 Jan 2024 04:24:59 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id jx8-20020a170903138800b001d74ca3a89asm2369438plb.293.2024.01.27.04.24.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jan 2024 04:24:59 -0800 (PST) Message-ID: <3c7036cc-6c11-435c-bd98-084d253ac4c3@gmail.com> Date: Sat, 27 Jan 2024 09:25:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240126214651.22783-1-michael@niedermayer.cc> <20240126214651.22783-2-michael@niedermayer.cc> Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20240126214651.22783-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h266_syntax_template: sanity check num_multi_layer_olss X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/26/2024 6:46 PM, Michael Niedermayer wrote: > It is not possible to encode a index into an empty list. Thus > this must be invalid at this point or before. > Its likely a broader earlier check can be used here, someone knowing > VVC should look at that. Its not immedeatly obvious from the spec > by looking for numlayerolss Can you check if the following fixes it? > diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c > index 549d021211..40572dadb5 100644 > --- a/libavcodec/cbs_h266_syntax_template.c > +++ b/libavcodec/cbs_h266_syntax_template.c > @@ -793,6 +793,7 @@ static int FUNC(vps) (CodedBitstreamContext *ctx, RWContext *rw, > { > //calc NumMultiLayerOlss > int m; > + int num_layers_in_ols = 0; > uint8_t dependency_flag[VVC_MAX_LAYERS][VVC_MAX_LAYERS]; > uint16_t num_output_layers_in_ols[VVC_MAX_TOTAL_NUM_OLSS]; > uint8_t num_sub_layers_in_layer_in_ols[VVC_MAX_TOTAL_NUM_OLSS][VVC_MAX_TOTAL_NUM_OLSS]; > @@ -895,7 +896,6 @@ static int FUNC(vps) (CodedBitstreamContext *ctx, RWContext *rw, > return AVERROR_INVALIDDATA; > } > for (i = 1; i < total_num_olss; i++) { > - int num_layers_in_ols = 0; > if (current->vps_each_layer_is_an_ols_flag) { > num_layers_in_ols = 1; > } else if (current->vps_ols_mode_idc == 0 || num_layers_in_ols is not meant to be reset on every loop. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".