From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 373FA405A9 for ; Fri, 24 Mar 2023 12:59:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 311D668C7B3; Fri, 24 Mar 2023 14:59:09 +0200 (EET) Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 22D8168C74E for ; Fri, 24 Mar 2023 14:59:02 +0200 (EET) Received: by mail-oi1-f177.google.com with SMTP id bm2so1200078oib.4 for ; Fri, 24 Mar 2023 05:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679662740; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZNJhx49hMlrjwFvgEbe7h6QrSgdPwf39N4ByQGriH9A=; b=iCvzA1VgsySrmy+VsrxNKETBhqgKLn+P+Gyy1tpIcWE87FXAiEAX1xP0Xn4E9WGE4t 5qAtmadfs8Wz8/1SE6TwX+h/MHJUP9jDmqfP43IvZu7za5kzAACsoQVHQB6tcJxU+S6u 3skwmDyfnv4E78M2pQgA3prEQXFlAEpbW6d+1ZYW6M+v359A/BrEsD2fauegWGLh7Kot 8uhKvqUDh6m1MTWyHUOEL4NEnE/h8P3pc0WofIS2VmXMOF90yVk1k4OEfNygWe1Go0z+ aSx+7HoZ1gxBwrauyrz68MNxjY7/nY7sExGlzaJGRIRStyPI8nk5fKM/AoFHONO/ugAO gqAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679662740; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZNJhx49hMlrjwFvgEbe7h6QrSgdPwf39N4ByQGriH9A=; b=2djiGDb8t/ZdqnK8GHFi7SM/RvGVUy42wCWvKQNPgh3BHnDCBN3bZ1rWbhbl/cNyUw MWFlKqzkOEM7pPcW05sHy/6QJPbhEJeRvzCFpeVYcVIim7Kmo1IRDorfPbUhkw4DJ4Bx xPp+8c4a0elh4/MiJGz1N4wnWBQayHDituj+nvko70lREYgYTz/G0l42hVeyWYxI2r7y FD934lujNb+9StXOjlq1YfIHUsCx5FlYGtckOqGTXJ4FGhspZ50/MdAt6vUsUa4SHvR3 20M5E5QOutAJYrvuP9jlgDU4XU5yGww2dw4ks5/YjLgly3AcLMQMpNqF/16Zj4bAsZAp z0Mg== X-Gm-Message-State: AO0yUKXdFTpqq4acbqUzcFoNpWEVHiM6UUb9d4X0jSS6XyP4T1KcWFXo 2Kvu/QJx0JSzodpoNoN2T7XmEV0upJE= X-Google-Smtp-Source: AK7set8+f2ia+WjEhAWjM44xSXdr1J+vZ+HnOu9FLzIAXOfcvhUJvV7tPD2kYe9g90VZ7DfzN+gPGQ== X-Received: by 2002:aca:2217:0:b0:387:6a3b:5a86 with SMTP id b23-20020aca2217000000b003876a3b5a86mr976730oic.28.1679662740266; Fri, 24 Mar 2023 05:59:00 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id 21-20020aca1115000000b003878631adaesm432834oir.52.2023.03.24.05.58.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 05:58:59 -0700 (PDT) Message-ID: <3c4ff584-e011-9fcf-f060-85cc8ded81ee@gmail.com> Date: Fri, 24 Mar 2023 09:59:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230321170637.10907-6-jamrial@gmail.com> <20230321180001.65412-1-jamrial@gmail.com> <167965834125.27013.4504786416238930490@lain.khirnov.net> <0d1d14c8-b41d-b88d-8a74-e11f7c455bae@gmail.com> <167965913421.27013.10971877037446793810@lain.khirnov.net> From: James Almer In-Reply-To: <167965913421.27013.10971877037446793810@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/24/2023 8:58 AM, Anton Khirnov wrote: > Quoting James Almer (2023-03-24 12:50:40) >> On 3/24/2023 8:45 AM, Anton Khirnov wrote: >>> Quoting James Almer (2023-03-21 19:00:01) >>>> @@ -3095,6 +3153,12 @@ after_cues: >>>> avio_seek(mkv->track.bc, track->blockadditionmapping_offset, SEEK_SET); >>>> >>>> put_ebml_uint(mkv->track.bc, MATROSKA_ID_TRACKMAXBLKADDID, track->max_blockaddid); >>>> + if (track->max_blockaddid == 4) { // HDR10+ >>> >>> Maybe this magic 4 deserves a name too? >> >> Is has no name. See >> https://www.matroska.org/technical/codec_specs.html#itu-t35-metadata >> >> It only defines a name for the BlockAddIDType, which i used, and >> constricts the BlockAddIDValue to be used for it to 4. >> It's not necessarily HDR10+ (i can remove that comment if it makes it >> look like it should be named), it's potentially any ITU-T T35 payload of >> which we only care about HDR10+, so i can't name it that. It's simply 4. > > MATROSKA_BLOCKADDITIONAL_ITUT35_VAL then? 4 as BlockAddID is valid for any mapped BlockAddIDType value, not just MATROSKA_BLOCK_ADD_ID_TYPE_ITU_T_T35. But ok, i'll add a #define for it. If we ever start writing other types, like SMPTE ST 12-1 Timecode, we could just make sure to never use 4 for it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".