From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 143F044B0F
for <ffmpegdev@gitmailbox.com>; Sun, 23 Mar 2025 04:36:55 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2D51687C67;
Sun, 23 Mar 2025 06:36:52 +0200 (EET)
Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BE90687BB2
for <ffmpeg-devel@ffmpeg.org>; Sun, 23 Mar 2025 06:36:47 +0200 (EET)
Received: from smtp102.mailbox.org (smtp102.mailbox.org
[IPv6:2001:67c:2050:b231:465::102])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(No client certificate requested)
by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4ZL3L45WsDz9sZZ
for <ffmpeg-devel@ffmpeg.org>; Sun, 23 Mar 2025 05:36:44 +0100 (CET)
Message-ID: <3c3441bc-1e3d-4bfb-bb76-599d28efbac4@gyani.pro>
Date: Sun, 23 Mar 2025 10:06:42 +0530
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
References: <20250319110624.1962-1-ffmpeg@gyani.pro>
Content-Language: en-US
From: Gyan Doshi <ffmpeg@gyani.pro>
In-Reply-To: <20250319110624.1962-1-ffmpeg@gyani.pro>
X-Rspamd-Queue-Id: 4ZL3L45WsDz9sZZ
Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_demux: set default for
readrate_catchup to be 5% faster
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3c3441bc-1e3d-4bfb-bb76-599d28efbac4@gyani.pro/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On 2025-03-19 04:36 pm, Gyan Doshi wrote:
> The existing default value is the same as the primary readrate.
> This maintains the flow rate as best as possible but does not
> reduce the lag. This new value allows catchup to gradually happen
> without overwhelming the receiver.
>
> Addresses a concern brought up in #11469
Plan to push tomorrow.
Regards,
Gyan
> ---
> fftools/ffmpeg_demux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index b8171e336e..23216f6c13 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1892,7 +1892,7 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
> d->readrate_initial_burst);
> return AVERROR(EINVAL);
> }
> - d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate;
> + d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate * 1.05;
> if (d->readrate_catchup < d->readrate) {
> av_log(d, AV_LOG_ERROR,
> "Option -readrate_catchup is %0.3f; it must be at least equal to %0.3f.\n",
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".