Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] ffmpeg_demux: set default for readrate_catchup to be 5% faster
Date: Sun, 23 Mar 2025 10:06:42 +0530
Message-ID: <3c3441bc-1e3d-4bfb-bb76-599d28efbac4@gyani.pro> (raw)
In-Reply-To: <20250319110624.1962-1-ffmpeg@gyani.pro>



On 2025-03-19 04:36 pm, Gyan Doshi wrote:
> The existing default value is the same as the primary readrate.
> This maintains the flow rate as best as possible but does not
> reduce the lag. This new value allows catchup to gradually happen
> without overwhelming the receiver.
>
> Addresses a concern brought up in #11469

Plan to push tomorrow.

Regards,
Gyan

> ---
>   fftools/ffmpeg_demux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index b8171e336e..23216f6c13 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1892,7 +1892,7 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
>                      d->readrate_initial_burst);
>               return AVERROR(EINVAL);
>           }
> -        d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate;
> +        d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate * 1.05;
>           if (d->readrate_catchup < d->readrate) {
>               av_log(d, AV_LOG_ERROR,
>                      "Option -readrate_catchup is %0.3f; it must be at least equal to %0.3f.\n",

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-03-23  4:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19 11:06 Gyan Doshi
2025-03-23  4:36 ` Gyan Doshi [this message]
2025-03-24 10:52   ` Gyan Doshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c3441bc-1e3d-4bfb-bb76-599d28efbac4@gyani.pro \
    --to=ffmpeg@gyani.pro \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git