From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CD952400E9 for ; Thu, 3 Nov 2022 02:22:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A2DFA68BE9A; Thu, 3 Nov 2022 04:22:19 +0200 (EET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1EF6D68BD32 for ; Thu, 3 Nov 2022 04:22:12 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667442138; x=1698978138; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=AMmeuCJyBHk3Y4COQUPQPcy+x8KH0zzqKXGTHjpgHug=; b=ikhxJSXcnqt/sYDb/GDdMl3ejGwp+H/FE1wsZA/iI+ssHoIN+Lr6SvVp 5uvCN2gn514ZJqFOEieIsTgX20tEA80bcTpS9KMQOEKw5U9ABe42DFASJ dfewPOpPKhmh9jyRiCjntm2CPMtxGifbMvBasceheTVAlzq/w58g2KfcJ xf7qi6R7sqrFPETTJhVRC/Kll3aCAFIaMc70o5WtpkI5MfCFa4ANsCeK1 WeS7L+QltA+/Zab5r5yjarVvQV1kyCFjmqozOtTXzYkBF7Z5+quCH2bTv weRjuBUXrKCZxrOWmh76nIZXTySVLWh8cte5qKbFXskNZ13XHsTT4H4Qm g==; X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="308285308" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="308285308" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2022 19:22:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10519"; a="963761715" X-IronPort-AV: E=Sophos;i="5.95,235,1661842800"; d="scan'208";a="963761715" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 02 Nov 2022 19:22:05 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 19:22:04 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 19:22:04 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 2 Nov 2022 19:22:04 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 2 Nov 2022 19:22:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgoDqsdeHD6qyhwG+Fs4O0hCU6I/NpW5KLWqQEHdLgHXiCjRzIYC8LVMBV47ouF+4Tafm9o9W7iSZr6vkxFHGxzIgmY0qmjrQ9v50OaOx7+eRnOGdW1sIjAaJrMBcWHApp0vw78ct4CKCSfu462mlRluEhYYANeaummgxvF33GoYJ6RR1HGxZqGzhpRtUmJRxwdS/CsHUJL+ICJgHgFB5ddBds3r+0zMxhohkuhUuL9VzLPVro9iRpnftF7nijLKo9eebYHUdx6rZgDqolLopW0Rq1u5GL1dDrCoDjWhYD7BDpK6F+Ph9gBFRXnSKbEAfSAbc0Ybsvrtbhm76XXWhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AMmeuCJyBHk3Y4COQUPQPcy+x8KH0zzqKXGTHjpgHug=; b=aiahhnv4Uxv+FBGn10B9d9qtLGqgcX8F90pT+ldOIzi8TuUqARANa6uWCUZpzZ0AFPB1AXTWjTPcabXghQP41LP0oYsI+ITimaNROi43jQqgP7UXW6NR4S1I+mKHL0eIdT/JXdwqopJfxhuBwb3HslTmEQqwgDb8ltuBz9kV3tgmdn82kPhtTDk9E1I5Nrjxpdwk2IaghimE/5q5ouqnBjMl5HJLiuaIOUqzhyzJLzepW2AseWNEeocKMXd43ZpCrjvji18R3l3S5TJ6d1nAOBPJsSl2IJn2cdgWbVya/BiKz7Jx127zJIn+yFfvJ69/8SdkcAGysYv8ZA8bh+v5tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA2PR11MB5034.namprd11.prod.outlook.com (2603:10b6:806:f8::15) by CH0PR11MB5346.namprd11.prod.outlook.com (2603:10b6:610:b9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Thu, 3 Nov 2022 02:21:56 +0000 Received: from SA2PR11MB5034.namprd11.prod.outlook.com ([fe80::991a:523a:893a:abdf]) by SA2PR11MB5034.namprd11.prod.outlook.com ([fe80::991a:523a:893a:abdf%7]) with mapi id 15.20.5791.020; Thu, 3 Nov 2022 02:21:56 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" , "ruijing.dong@amd.com" Thread-Topic: [PATCH v3] avcodec/av1_vaapi: fixed a decoding corruption issue Thread-Index: AQHY7vJ9h+QiQeWbSE2us6uMbMWnia4sd3UA Date: Thu, 3 Nov 2022 02:21:56 +0000 Message-ID: <3c1a1a2f5facb8497d580c02300691f7d1f83deb.camel@intel.com> References: <20221101023218.667352-1-ruijing.dong@amd.com> <20221102193553.214197-1-ruijing.dong@amd.com> In-Reply-To: <20221102193553.214197-1-ruijing.dong@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA2PR11MB5034:EE_|CH0PR11MB5346:EE_ x-ms-office365-filtering-correlation-id: dffb72d0-fa50-4221-9d96-08dabd422e2c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: z3PA3ii/Nb6+a2QDGdYE6iotPBZP1ifU8tIu4Tv+0dvXNOMazpZHl6zxg4fg5GK05dmolszYUSvLnjPNcD7hXZa8ivwdZMkrMVA//euXmM2XKOOsocaQiK47up02iCFGLS2qx0w7x02FpzyRbS3mfScafJbIk3LI/R2wsP+jpaE1dWzUQ29GcdZGhz+AmIxNGdPDQxKasWmv52rQD0nGUcLKCuNy2fIw1Yebx64/Gxxfpdo1w+/CtTERI5lehsWA21i5HqIJs5jHNSfDtb5Rt4lf76HqMMZaC0dmuZ++xfVc1kL++suM4PQRqn2x/ohGt/e7Ac9LspakU9Mh/9foOIUggxRv3OQ17OysaV1WAKFhUfd26AzWEpNmZ8DSbPMyfyMh03NBEBvV9yja5MiwpE+pHGFdwOcz0//f+UY3iyEahTG4NuIYeM7os0wvssDxZZjZ8Le2rb1t+mONlTx+Y5+PYmaP01SAJg40KwUpG6hEOikf+gcZOQ20n47C7iVFFHYzJSlq45/8lxiOsKIGTNSSoWVgx0bt6QQBaTKW8+CxM4/5gBT8D0eQfsosEesmQB8MwXtdesCqHHQMUBR2upIoPaw7ADNRylptc0cAkVxJiY4MiOvXm523iucjWcjNJP1D/vMn4E9H+0zQewDJ5TxEHM7DXun52JQ0iN3RrzZ17F7eGV5pTcFPFr5PglaHrCNcQi/QPvSDO95HsdjkmA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5034.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199015)(91956017)(8936002)(64756008)(66446008)(186003)(8676002)(36756003)(2616005)(66476007)(316002)(6512007)(66946007)(76116006)(66556008)(83380400001)(41300700001)(5660300002)(6506007)(2906002)(966005)(6486002)(38070700005)(71200400001)(38100700002)(86362001)(478600001)(122000001)(110136005)(82960400001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TDlBams5TksxeExsYk5mY2xuUkJaRUhTNzJvRkdJaWRGUytUTzYvR1p3VGc0?= =?utf-8?B?REd0WEt4ajlHSTYxNHFGVnRDSDk3ZHFLSm9MQ0VBS09iTVlCZnBtQVl5N0sw?= =?utf-8?B?amlrVkNjWENNRldkdUpPZzk2SHJHVkh6RE1iTlhlK0dMbnVTOWdXR0hNczdP?= =?utf-8?B?VERGbGFydFFuSENjS3piVlF5QmliQ0ozbk5vSmYyNWNMVmYrSklHVzVYSFFx?= =?utf-8?B?Z3Mwb3BBN1k2eHE1Z0xKNzJSdGt1NExZZTdENzB0WU5JTDVjQTJkODc1Ylc0?= =?utf-8?B?QzJsamdMYlB4cVNqVHl3Y2pIZjZSYmxqZTYrMEZaLzg4QkN4RVM4Q1JUMm1J?= =?utf-8?B?NkRKNlRreDVjamc2RlNWekdBZWRjSlRnUUVrdWQvTXkya1JlakltZHhSbmI5?= =?utf-8?B?b0d3OHNyeWwwMDl3UStsSzB5bnM0aDZobG92UkdDS0dmYloxYitsdEgwZ2Iw?= =?utf-8?B?N1dad200azhTbGFkOEtpSXZ4MDJ4czlaRThBazBBT3BiMVBVR3NRZG1kcFpC?= =?utf-8?B?bURiaHdQaVEvUjA5bDFvc3NycnppSjNXMmJVaUlpcGd5RnRYVUEyb011Wmc1?= =?utf-8?B?aVlVUHFkcStaR0ZPV2djWEN5OWl6aDBQRmlzckg1d1JmaVcrb1ExUHVIeTQx?= =?utf-8?B?WCtBM3JmVCs4UmY2Tk04Y1pJTUlUaDloeHJMV1ptMjc2TXgxc01lTVdSdFVj?= =?utf-8?B?SHZaUjd5bXh2SjR1b1ZVT3pwNk41M2doNXRLRXJxRVJsRVd4M1hTUnFuR1RD?= =?utf-8?B?WU13MUxnK3dJczhDNjlEQTczOHozMzlCR3U2R3RQdDhiRFJDUnVZSTBLUkpU?= =?utf-8?B?R3F3bGMyRXdZbGwwMWFTWE53UzVueU5ndGZlRTRIVS9Ha1NtTkpZamE4UjRG?= =?utf-8?B?MXoxcXRwODJmZEtVOGp2bUZrcndlTlpNb1RlQkRkdDRyUjlPcndHam5JMGlu?= =?utf-8?B?WFE1QjlwdGdXUXVmaHQ4R3F0bnhTRzUzaUoxSjZVZW5LWSt2SEdBYVdBZWF3?= =?utf-8?B?U012ekx2SzdOa0tVRlNJVzBXd3I4OVNmYmpRdEU2RGdRRGdIdkxUL2xxMkor?= =?utf-8?B?Ky9Zb2FwWW5NdisraS8yd09VdllJRlpxVlZORDJ0UW11Tk9tNm41bDU1bTY0?= =?utf-8?B?VXNsUXpkSkU0WUJ6WU9SMGNHbWVhYXJNSTZuK3dqUGMyQlRUaW5laU02RFNK?= =?utf-8?B?TEUva3ZwbnRXRGVMNTA5aUFOSkl4V05yeGV1YVBsSW5HT3RUQ25BM1JZUUJu?= =?utf-8?B?bEh1R3c5ZlhYNmxFY0FUUUp2MExCQ001MHFIMlErUHpoQWlnZFl0bHRzV2pL?= =?utf-8?B?aWlpZVZRZWZYZlliQjEzVFBvM1J2d1ZxeUQ5ZGxUcmZEUnJiMGorRXdzOE1j?= =?utf-8?B?TnBKYjdieGtGd21id3Q3dGIrWWxWLzNQN0VNbFpzQlpWbDE0clExckN3UUlz?= =?utf-8?B?S1FDNUVhQkU3bXFlUS9uejJydkVvU25Cenh0cUx1Ky9ObDNoYk94TGVsbFFh?= =?utf-8?B?Zk1UbC9BTHprcWRmbVRZcGJSTEFGNkhoUFdwdTIrcWVLYXNrNE1vSnM3dkg5?= =?utf-8?B?UjRaNjZ6TDdPOUYrR01xOW83Q25rb1JWWlk4THBQd050MndseVdXM0daOTlO?= =?utf-8?B?MC8zUGxrblZqMFVIV2hyVnJtR1lRbkNwQTBmM3FjVDRQR0MybFVDaVNsMG45?= =?utf-8?B?Nm1qU1QzYzFkUjV2VjNoZnlrT0hxeVVSZXFTOTVuYkVYS2VmT1NyMmtuRFo4?= =?utf-8?B?MXpSUjhOUThRSzBhdzJhdlFoalNodW1SemNrUy9wRkZqUHRHTzlFTEEvTEVX?= =?utf-8?B?YUpHQ3R1aS9YenNiR2dPelRoTlFtbVp2ZlNLRzB3NkpNc1ZoalRrdVptRzAv?= =?utf-8?B?MEhlMmJXWGxSZ0o4YmZDZ3R3dkFlZ1BrbmptWHVNVXQ5MVoxMTVhdHlKb29V?= =?utf-8?B?MnhCZ0ptZHhWQTR5c3VDeHp5Wmgwb1IxdmwzQStxTkZ1RXhrTm1UUkM4d1kx?= =?utf-8?B?bytlUjJqVDBzQWhNcXNpV29PL29CdEhuU2ZDSzBteDAwNGNCVmtzT1d6T05Q?= =?utf-8?B?bEpyajR4NmtocnhWUjMwK0FJZU9FVjlESnVWWVUzVFovSzFBOTY2VmtwakMv?= =?utf-8?B?MkJKdU5KSXNVTWRRekFseEJXc0N2RVg2K2F1ZEsydm8rTXlHWjlPTmFCR3JB?= =?utf-8?B?TEE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5034.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dffb72d0-fa50-4221-9d96-08dabd422e2c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 02:21:56.6357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OUNMl6T7EvzDYRbU0hOf+o34MYLLnLKpEJrXzFvl078VSHExhxBKe6mugGLg9C2FQrN71cqXOuL91ECodvXSfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5346 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/av1_vaapi: fixed a decoding corruption issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-11-02 at 15:35 -0400, Ruijing Dong wrote: > In av1_spec.pdf page 38/669, there is a sentence below: > > if ( frame_type == KEY_FRAME && show_frame ) { > for ( i = 0; i < NUM_REF_FRAMES; i++) { > RefValid[ i ] = 0 > ...... > } > ...... > } > > This shows that the condition of invalidating current > DPB frames should be the coming frame_type is KEY_FRAME plus > show_frame is equal to 1. Otherwise, some of the frames > in sequence after KEY_FRAME still refer to the reference frames > before KEY_FRAME, and if these before KEY_FRAME reference > frames were invalidated, these frames could not find their > reference frames, and it could cause image corruption. > > Mesa fix is in > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19386 > > Signed-off-by: Ruijing Dong > --- > update: re-organize commit message and title > > libavcodec/vaapi_av1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c > index 63374c31c9..d0339b2705 100644 > --- a/libavcodec/vaapi_av1.c > +++ b/libavcodec/vaapi_av1.c > @@ -274,7 +274,7 @@ static int vaapi_av1_start_frame(AVCodecContext > *avctx, > }; > > for (int i = 0; i < AV1_NUM_REF_FRAMES; i++) { > - if (pic_param.pic_info_fields.bits.frame_type == > AV1_FRAME_KEY) > + if (pic_param.pic_info_fields.bits.frame_type == > AV1_FRAME_KEY && frame_header->show_frame) LGTM, Thanks. Fei > pic_param.ref_frame_map[i] = VA_INVALID_ID; > else > pic_param.ref_frame_map[i] = ctx->ref_tab[i].valid ? > -- > 2.25.1 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".