From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BC0594907B for ; Sun, 3 Mar 2024 00:31:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DBF5C68D32B; Sun, 3 Mar 2024 02:31:11 +0200 (EET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D240768D301 for ; Sun, 3 Mar 2024 02:31:05 +0200 (EET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5dbd519bde6so2901647a12.1 for ; Sat, 02 Mar 2024 16:31:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709425863; x=1710030663; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kRK5jJEyQa9l41UkPiTFKpZn8nVmd5MKKVNezE+aBGI=; b=J6mfJpekf9WpHTFw1ZBOjsvQixA4nuWnUh7Zhbgwiri/bu0fV0BtQ3SKB0JL7jnTo5 9Lgf4QVq4djCN5AWtXpAAB98TNCjPRgKDhrcte6fPbwKNz8uq0KJ5Ontw9JAMXOBc/1C Sj7fK2eQFq3RCXGPuHYnYdaS2AXeUh49ENaexL55VQm3z+NbIKpFJjNx8NlHLitBgLGq ccJBCrZi3Pm6CCRrPJg7Po9swutN35CeRB70119AaOnV0R6UZanMmP1qedIL9fMcJ7bo Cl/E+OqzOZHiFsm+M59OOHQF2hNO+EWc/VHNBFQ9ku5fWGhvedHyczaN8TrdzGSJkS3D 2GxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709425863; x=1710030663; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kRK5jJEyQa9l41UkPiTFKpZn8nVmd5MKKVNezE+aBGI=; b=iiVwJAAzsnXe7ecWV18YK0SCarJWjFq+8QMHcaok4f1Ki9UWg0uAV71TMuS4P/UY/u R5r1mhn/yiMI+nGPtzs6B0/larGH2i6gorOJ01oDdzJxZmWKuJLAoWBYHQsudRtrZ+At be8izWKPgY0kObJLmNcn49VZuKrx1T5xq1mrmHaenCLu/TXJeMU2Eg2+KCuHNdLR2vip D5BZEOGEemmNCwDCPWNW83nrlRpfbSiv3XtrF3vcCwXBQpIZgeuUllJLCG5PO59o9jW5 8k3twuUDaLBAws51oREEHGs38GuiMLdo8Cy72L2hH9G9bGHbnwJhW6X4ta30ZUGQeThF 96dg== X-Gm-Message-State: AOJu0YwDzcSGbzLjHlZlgCh+jUOBvhwO9EKAqR1eu99SUA6xkOmy47W3 qgT6yfsQx2vLIus3HAWvUYVnY7ntBYjyC+kQ5L0rNwgafKo8R9TxijvviBFb X-Google-Smtp-Source: AGHT+IE9dhlhzWiHYbgHgDCCMkUUfPeKYI/t7zDE5+HdDVdfTJkHbhWR7NzAmTYiaeBwkEqEBXcxkw== X-Received: by 2002:a17:90a:1097:b0:29b:2779:6ceb with SMTP id c23-20020a17090a109700b0029b27796cebmr4175543pja.34.1709425863009; Sat, 02 Mar 2024 16:31:03 -0800 (PST) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id 1-20020a17090a0f0100b0029981c0d5c5sm5976631pjy.19.2024.03.02.16.31.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Mar 2024 16:31:02 -0800 (PST) Message-ID: <3c12598e-4bf5-4a17-8a53-1cf08b244e82@gmail.com> Date: Sat, 2 Mar 2024 21:31:09 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240229174122.6696-1-jamrial@gmail.com> <20240229174122.6696-2-jamrial@gmail.com> <20240303002756.GK6420@pb2> From: James Almer In-Reply-To: <20240303002756.GK6420@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/2024 9:27 PM, Michael Niedermayer wrote: > On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/iamfenc.c | 30 +++++++++++++++++++++++++++++- >> tests/ref/fate/iamf-5_1_4 | 14 +++++++------- >> tests/ref/fate/iamf-7_1_4 | 16 ++++++++-------- >> tests/ref/fate/iamf-ambisonic_1 | 10 +++++----- >> tests/ref/fate/iamf-stereo | 4 ++-- >> 5 files changed, 51 insertions(+), 23 deletions(-) > > seems to break fate here > > --- ./tests/ref/fate/iamf-7_1_4 2024-03-03 01:24:48.462539621 +0100 > +++ tests/data/fate/iamf-7_1_4 2024-03-03 01:25:31.762992374 +0100 > @@ -1,12 +1,12 @@ > -5d9fcee2b9b2ad3c802c40bb1147016e *tests/data/fate/iamf-7_1_4.iamf > +157c3185684e12cc8385ee7c3ef2fb4c *tests/data/fate/iamf-7_1_4.iamf > 99851 tests/data/fate/iamf-7_1_4.iamf > -#extradata 0: 34, 0xafa70d5e > -#extradata 1: 34, 0xafa70d5e > -#extradata 2: 34, 0xaf7b0d5c > -#extradata 3: 34, 0xaf7b0d5c > -#extradata 4: 34, 0xafa70d5e > -#extradata 5: 34, 0xafa70d5e > -#extradata 6: 34, 0xafa70d5e > +#extradata 0: 34, 0x40a802c6 > +#extradata 1: 34, 0x40a802c6 > +#extradata 2: 34, 0x407c02c4 > +#extradata 3: 34, 0x407c02c4 > +#extradata 4: 34, 0x40a802c6 > +#extradata 5: 34, 0x40a802c6 > +#extradata 6: 34, 0x40a802c6 > #tb 0: 1/44100 > #media_type 0: audio > #codec_id 0: flac Did you apply the first patch before this one? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".