From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written
Date: Sat, 2 Mar 2024 21:31:09 -0300
Message-ID: <3c12598e-4bf5-4a17-8a53-1cf08b244e82@gmail.com> (raw)
In-Reply-To: <20240303002756.GK6420@pb2>
On 3/2/2024 9:27 PM, Michael Niedermayer wrote:
> On Thu, Feb 29, 2024 at 02:41:22PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>> libavformat/iamfenc.c | 30 +++++++++++++++++++++++++++++-
>> tests/ref/fate/iamf-5_1_4 | 14 +++++++-------
>> tests/ref/fate/iamf-7_1_4 | 16 ++++++++--------
>> tests/ref/fate/iamf-ambisonic_1 | 10 +++++-----
>> tests/ref/fate/iamf-stereo | 4 ++--
>> 5 files changed, 51 insertions(+), 23 deletions(-)
>
> seems to break fate here
>
> --- ./tests/ref/fate/iamf-7_1_4 2024-03-03 01:24:48.462539621 +0100
> +++ tests/data/fate/iamf-7_1_4 2024-03-03 01:25:31.762992374 +0100
> @@ -1,12 +1,12 @@
> -5d9fcee2b9b2ad3c802c40bb1147016e *tests/data/fate/iamf-7_1_4.iamf
> +157c3185684e12cc8385ee7c3ef2fb4c *tests/data/fate/iamf-7_1_4.iamf
> 99851 tests/data/fate/iamf-7_1_4.iamf
> -#extradata 0: 34, 0xafa70d5e
> -#extradata 1: 34, 0xafa70d5e
> -#extradata 2: 34, 0xaf7b0d5c
> -#extradata 3: 34, 0xaf7b0d5c
> -#extradata 4: 34, 0xafa70d5e
> -#extradata 5: 34, 0xafa70d5e
> -#extradata 6: 34, 0xafa70d5e
> +#extradata 0: 34, 0x40a802c6
> +#extradata 1: 34, 0x40a802c6
> +#extradata 2: 34, 0x407c02c4
> +#extradata 3: 34, 0x407c02c4
> +#extradata 4: 34, 0x40a802c6
> +#extradata 5: 34, 0x40a802c6
> +#extradata 6: 34, 0x40a802c6
> #tb 0: 1/44100
> #media_type 0: audio
> #codec_id 0: flac
Did you apply the first patch before this one?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-03 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 17:41 [FFmpeg-devel] [PATCH 1/2] avformat/iamf_writer: update extradata from packet side data James Almer
2024-02-29 17:41 ` [FFmpeg-devel] [PATCH 2/2] avformat/iamfenc: ensure updated extradata is written James Almer
2024-03-03 0:27 ` Michael Niedermayer
2024-03-03 0:31 ` James Almer [this message]
2024-03-03 1:02 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c12598e-4bf5-4a17-8a53-1cf08b244e82@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git