From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8488D4AE93 for ; Wed, 22 May 2024 13:00:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 75A2568D37C; Wed, 22 May 2024 16:00:38 +0300 (EEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EE1EE68CCB8 for ; Wed, 22 May 2024 16:00:31 +0300 (EEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1ee954e0aa6so10463955ad.3 for ; Wed, 22 May 2024 06:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716382830; x=1716987630; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=CoYqBOzKXUGtP3yQi/AZobnREhfDGP2mnRz9sGWzNhg=; b=KSpY5JmR0lEM+lW6jo1VFXtNF8qAFTaKfuc4OeEWmmjd2httxKtzJPuGbIoBDvzWe7 oYfQtyWUUnc2ilnqp1PHTyqF7ttmJ9ed8IXtmqsiVKNUCqRrjw8bX3par4vkvQJOmKWS QzcaYvO2KHXjkmY8pIwQRhvMe+D8oRf4IraktM8GeQU4QHdKKZ7xeHlfmgDicU22Vj57 M/5aVwZa8U/hkB/IEumPyBI65rIJghyN+Zg1uv99UrSiJvOeq5BjimsHZhQgIbAJE32/ ZoZg263XHHqCP13IUKgqhSlSTLVfPgm7Tt5TrrUJqFPH89YoWJ/cyJyJ19FI7p0O/0Vy gr1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716382830; x=1716987630; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CoYqBOzKXUGtP3yQi/AZobnREhfDGP2mnRz9sGWzNhg=; b=QUQvqWLnICC36+UoQWBZM/a9XbsjGgZMhqZJxPgLm6hPcDfWyShb3t/PeiyQYcxily 5YH9A7M8FAPxppTYE4c4tfMrLmI+AAV1tu3MOGkuozajxiEIEcLQktCoNs0+fRckNA5+ NgPEk44RvJpmG7hRE17Z45to48o80rM7MUJJ6rcR+DspIXhZHQ4HHUaww2yItnX/iYaH cIFoLQgVA3RZKZTHoI9SGI+rAxlfWYcFhZV/hOxIkEvaT61sgPqErR8tkEhIJyJ0yA5N +9bgmA4SNRSecY+fp8j6NNvMIzWGFMPwEwbUEuYcph3E7+qeIs5PjARaAKLceMozq0dl DGTQ== X-Gm-Message-State: AOJu0YxllavE8XqZjmBz8U9jyOeMDF8I9FHc2y29jK4t/caTVL/+XXV5 p4Cz/BjJ/g/xOX/eYFUT0BPjNKGNHEEAnM3n7uHZVK1dP4QhwjxqULUprQ== X-Google-Smtp-Source: AGHT+IESx3OJpRh/M22ZJCmoVaHzk1kVRywFeb+6GgwRfFYuVigN2lTNEyP3vIaGNJmr4+hd79EMqQ== X-Received: by 2002:a17:902:c412:b0:1f2:f784:97a3 with SMTP id d9443c01a7336-1f31c9e48e5mr21451975ad.51.1716382829476; Wed, 22 May 2024 06:00:29 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f30d16bd73sm32301665ad.262.2024.05.22.06.00.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 06:00:29 -0700 (PDT) Message-ID: <3beb7fbb-1d08-474d-bba4-e71252010230@gmail.com> Date: Wed, 22 May 2024 10:00:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240519132554.3342-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240519132554.3342-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avformat/vvc: fix parsing sps_subpic_id X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/19/2024 10:25 AM, James Almer wrote: > The length of the sps_subpic_id[i] syntax element is sps_subpic_id_len_minus1 + 1 bits. > > Signed-off-by: James Almer > --- > libavformat/vvc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/vvc.c b/libavformat/vvc.c > index 34c0aaf58b..ac3209a01b 100644 > --- a/libavformat/vvc.c > +++ b/libavformat/vvc.c > @@ -371,6 +371,7 @@ static int vvcc_parse_sps(GetBitContext *gb, > const int tmp_height_val = AV_CEIL_RSHIFT(sps_pic_height_max_in_luma_samples, ctb_log2_size_y); > const int wlen = av_ceil_log2(tmp_width_val); > const int hlen = av_ceil_log2(tmp_height_val); > + unsigned int sps_subpic_id_len; > if (sps_num_subpics_minus1 > 0) { // sps_num_subpics_minus1 > sps_independent_subpics_flag = get_bits1(gb); > sps_subpic_same_size_flag = get_bits1(gb); > @@ -390,11 +391,11 @@ static int vvcc_parse_sps(GetBitContext *gb, > skip_bits(gb, 2); // sps_subpic_treated_as_pic_flag && sps_loop_filter_across_subpic_enabled_flag > } > } > - get_ue_golomb_long(gb); // sps_subpic_id_len_minus1 > + sps_subpic_id_len = get_ue_golomb_long(gb) + 1; > if (get_bits1(gb)) { // sps_subpic_id_mapping_explicitly_signalled_flag > if (get_bits1(gb)) // sps_subpic_id_mapping_present_flag > for (int i = 0; i <= sps_num_subpics_minus1; i++) { > - skip_bits1(gb); // sps_subpic_id[i] > + skip_bits_long(gb, sps_subpic_id_len); // sps_subpic_id[i] > } > } > } Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".