From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1933E42085 for ; Tue, 22 Feb 2022 05:46:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 113F568AFE1; Tue, 22 Feb 2022 07:46:55 +0200 (EET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3BFAC68A74F for ; Tue, 22 Feb 2022 07:46:46 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645508812; x=1677044812; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=aW3bCQOphSHsJLTNfjxnNGfJEIZxOTmxDmvA+umskhw=; b=bHFCwZ7HF6H9UTtcSHNfNB4VKCWLVhqcxiCWdBJBwLxrmLxR1Iv7Mgsa VMNBiPS8YBrPtsGLaZKhenyFIjxh14kJcQaJTysqKVPSUwAoIncOzukbY CzlvdF6U+d9IHZJR3+8OF2wtwxTjIo+ttZlHK0v3rV4hUta9XII2RqMfy 0nWL4oV3XYfAewFI+dDbky92e37iUMAf41WGZUKk/bZjOq4iSvV6tfYz9 N9ExZBiP6pW4t5RKZVa7gt00XRNxyhZboXYkvW0sB4egmO3TgRKEelpIg HI/Vp1ErDlOS/gMjzYTJYG02GnAM/pMeizOr8Jiz0VGpBW6eMSm1Lhwg4 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="314880481" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="314880481" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 21:46:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="573310572" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga001.jf.intel.com with ESMTP; 21 Feb 2022 21:46:44 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 21:46:43 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 21:46:43 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 21 Feb 2022 21:46:43 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 21 Feb 2022 21:46:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2vpNylVrlJoHTvEsttunmGYO/Q1O2fAFmvGdz3oDvcu1IEC+BC/tN/fAqpAME92t8AcAg0VMGGlTL4ZvCrebIpG7pkycE6Gq5GzF9k4de05exAcwVkwaWpC581Bn/0zJwrLbsy8r+sE0sVbtKwaCKHGj79o8PF5+AdOJmLmx634iwYZzk9jOmdaqi1waROd0GyhMpRLnwPIr2nBK1ESSppnB2ycnz98D04qDk5x2A/M81uQZTFT0MSUNJI6tpF/9lzparP8egDfIExhBvi5rnh9Mr4tDC1waJw+vEBE//9PS2lWLbrNFxMR2wu1G0Ok70XHONRJ6XAK0cXr33XcYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aW3bCQOphSHsJLTNfjxnNGfJEIZxOTmxDmvA+umskhw=; b=TU0oIV4T4hayMCmf71C4lJraGOYCQkvvWrMYvdfAshYjcwMfXGYlekqd3JgIROPd+rehoBok8kUjnK8yGCxZwzAo6DkDt9hyo32cbcEgEY11kwH4ZCFSG6yncZNzrHgyxobnnl47N4+UfJTT5KK5Eftboz6tV0EIx92Zp5XR5T9OBXcQUIoJv9zLhKZS6Rt4EqKy1b/B1tvEjIqqxSpS8SoLgT3fZJiVulYeD65t4rcVAXHQ+abLuEPL0noX3qSg1vqVBUMT+WCoXFwRSG++I2C6ch9WltHNX/kSt+eHdOaJFFPBt3STvkzNXbBWw3sxOzFSR3avlxAH25fWiMUfSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CY4PR11MB1366.namprd11.prod.outlook.com (2603:10b6:903:2b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Tue, 22 Feb 2022 05:46:41 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::9b4:2af2:de92:517f%4]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 05:46:41 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode_h265: Add P frame to GPB frame support for hevc_vaapi Thread-Index: AQHYJslr6wNF22oJ/E6/JMLgr3pNHqyd6V8AgAEoLgA= Date: Tue, 22 Feb 2022 05:46:41 +0000 Message-ID: <3b94feeb89d9a990cc11d8b2b35a0949736e6fb6.camel@intel.com> References: <20220221021337.2190359-1-fei.w.wang@intel.com> <03ec8c31-088a-95b6-a514-6fbf14518537@jkqxz.net> In-Reply-To: <03ec8c31-088a-95b6-a514-6fbf14518537@jkqxz.net> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a8f7646-ea50-4f1c-7719-08d9f5c6b39a x-ms-traffictypediagnostic: CY4PR11MB1366:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pZMxm6/zky8IgBMuJpW7fTdnxcnBQSZnzx/CiruR5If86CzRXodld7Ok5Ng3HjJuXpEUIxn4cEt+w8ogtlIL9YJEhUuBD0mZ2n/bvB6u+ZqIhvC5ksWGljjQrjEzfLEiLFjmSubbUXcNykGrJ75xgRxiwQ8EwxR7mYGs1zYnmrAJzL1rI4c9QciBMFLagLb8w9GIIzqYpayN/gjPYdWYZUEKkT0He8dQhGAfa/02zqF060N9qYxRKqelOCZ06y7+KwMv+QC12tW/hrg2MaSxYlLL/SioykbeSX0NVamLrz/hDsSnLNvezr4wkiOcF5t0jF1rcHWr2bOInuZj07A70oG5qYTY7SLZo88J73DrVuzgR6mFrne/6HOPcK4EGwx8wCQogm7BOy1/oPMqvzDhiddBZC8jQHY+JMChXKcrtnefKIxvUrR958C0Hrz85cWT9XOuUplTXDOTHCslN+IQ6GqD7rM/QNJ4Ml9x+SqhTuCKDdc/AjY4Pi6LpXSDUH3p/1QnDd6TNA1rvpeF+UwHhqrgA49cCwAQaGVeQQdwQUpL8Nh54hlhgOvSk7VuRN/COb9Drw38B5fqvIYecgCvy9/IdH1wTwXOZavXjuu34aPekJlqX0jTaxmN0mdZq1EbXDyHGS9IRWFc8xMj8wJZzceulGhvgaj7BNopQqrqS6hn6K2sa0Gj1RBkLOrSqpmQY4yZx+4ruBTS26fuw23HEJlqxNFzvSXh1syDhDLFffscxN0gtokxn47pQYOvl/rrTqzRLwHHdGREATypL+gZDUHxp8hYnVJmhYRDyTIBDcDSQCuEfOn+jBd3Sf9rajMn x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(6486002)(966005)(6512007)(8936002)(6506007)(71200400001)(2906002)(53546011)(508600001)(83380400001)(66946007)(66446008)(26005)(186003)(6916009)(36756003)(66556008)(91956017)(66476007)(38070700005)(86362001)(76116006)(64756008)(8676002)(82960400001)(122000001)(316002)(38100700002)(2616005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZXdFK1JuK3FoZStOY3lEWk1wS2dSYVdFT0taeUpiUXFuZ2tMMzZDQjFybGNT?= =?utf-8?B?Y0tFNkROMGlVcVFGSERCNnk2TnlQQVBjL3prRkFOOWNnYkdndUdOcjRYK0Fp?= =?utf-8?B?Q3BqR1JQMjJLWk5JWVB4SVV2N3Qxd3lrVTl0Tk1xa3UzOWNvSTVpcHp4cnI3?= =?utf-8?B?dmdSSUZ5Y1NBRGhQZ3VZMm9zTXN3RGM3bW9mRllTSjlDanZGeUFYUGFXWWxx?= =?utf-8?B?am11a0tnRjFneFZ6S2tmdndaTi9KUzBPRVFUZTVJOVFZTjl1aVRObktHYjBo?= =?utf-8?B?b1BLQStSL3BkN1R0RFVvd0tlN25jaDBnNURoMjhSOXpSOXBhZjFPQXQ2UjNS?= =?utf-8?B?SHlhV2puU2JpTCsyaHJjcWhIRlBhM2Q2R3RTT3NkUXBlOWs3NWNEdjlySXV3?= =?utf-8?B?dmV6eXlvL05XdE1LVGZLbFhBVDRuSkdxQkR5aGFPYnJ4OTNqZE4yOUJDWmlU?= =?utf-8?B?bWFpWW90VDIwci9Xa2NrakNmODJuQXZuT3g0VlFWWUZjSmwxZnU0MEVZYkwz?= =?utf-8?B?VVo5eGl6NVNibjVKa0Zwd2VoQ3pnZzY5NElreVBoMlZXeWZaZytCRGkxTCtQ?= =?utf-8?B?UjgwUCs4YzRVVVJscVpBL3RmMXpSZVFSWlFzcXJyUmowa3lJZGNkdHNvM1lu?= =?utf-8?B?Y1V2c2dVTmVwSTV0dVVkcjJPekZHaEZ6aE5KVFBNaXRsYThVZTRkY29Mc3NK?= =?utf-8?B?R0s2UzFmakJJeWw2ZjdwRHhoYlVnSGJZMTFBS2ljdTNzWWs3U0RlUCtRTS9u?= =?utf-8?B?bEhjWHl0amM3ZSt0NUQwZUc4NjViUVRoaVc1Z201aWNDbmZoOE02TGZYN1BW?= =?utf-8?B?cVpBY0JjT0pkdUh1djFOUjV3MUhVc1RDNzA5YlEycWRwd0RRNlFNalZzaHZJ?= =?utf-8?B?U0dMTjJyM0xDeVkrOTc1anhTUXUwMVNHc0JDZVpMOUxSUm5aK1ZoSzBQSGN2?= =?utf-8?B?ODFsb1BXV041MkMrc2p6RGp6SnZRM2w2L3ZGclJ5cERrZjJGK3dBb3R3ZUtZ?= =?utf-8?B?bTBvUHJiek04bXNVazBjSG5mUnphRzBjVHBMUWE0UGV0bTZyU3dvY1AydlE2?= =?utf-8?B?WVpYbFFBNnFYNk5kKzZ5OEhJaFFoMHkrM1dmRTBLTllFb0VQWHdVbWVaanBN?= =?utf-8?B?NlM0YndhbUtNcy81dTVzY1JSS0drN2ZhQ0FteDJOTEVRWWFUNXdYVjRiUGhs?= =?utf-8?B?R0VaekhJcm5lb1Y4dExiTEhrdkdFK3U4bUc4MnE5UVRuZWN1YjIrSWcxdzNo?= =?utf-8?B?NWFXUnY3c1JBcGNZSkRlQ2pST2cvSTV4TjJhYmoxOVVxVVo0ZnQ0S0M3R2p4?= =?utf-8?B?c2JWSy9YaUl6cTV3MEVYSmIrVXdEYVE1cUVyOGxsb3IzeVlaTWhFVVBNZ3c2?= =?utf-8?B?SDhpcXlISEJmR3FXNHJHazFkcUdsVzRSL1NuZ2hPdHArempKV0RyTEpKbGFU?= =?utf-8?B?QnhhMUNzcGRIOTYvNUczNkJhNjNWdHpMdE1lck95Mi96RnJrVzZVelpMMFJo?= =?utf-8?B?WE9UTlRqVzdNMU9DNHJjWHVmQVRoYy9QRDN4bHkvQWtsQkRhdnQ4L3JnTkl4?= =?utf-8?B?MmNYVU1zWTRlU0NLR0xkRlhtT1BiVVJBaWNFTWJITDdmVC9JQisybVZaVlcz?= =?utf-8?B?cjJjcVlNazlzVC9iZWVzdHJVb1Nhc1I3WGt2MG1IUE5DdDVzZ1N5TUpwL2N1?= =?utf-8?B?bDJqenJicnQ4VVNvc1pCOVdsYW40UDdueDNMR3BQUVFQTGE4azR4aFF6Q3Rj?= =?utf-8?B?Q3IzYmlTY1VXWG5oMTI0WElYcUVsV0N4L1VFRlVzZnJQMHJYL2JkdHlDSWl0?= =?utf-8?B?QlM0REJiZUdXV3VDQ243dHNjcEtuYWNGaUZzVERKYlFXcnBaampmZzVkc3ha?= =?utf-8?B?MVc5MjBXaHpyNU1zUVFNOW1ZYmpWODgvcGd5U090TmV0cEx2c0dsdU9PUkcy?= =?utf-8?B?bENOOW81R1NWakV5ZjNSVjR1dGJXWWVjYTVVUzcyT0JPZzJnY0lnSDVJTDNL?= =?utf-8?B?b3FRT1VLOEROQ1ExRGFGL1luNnd2c0RVUUFIR2p4MkJRaVAzNFNYMmZMQmZj?= =?utf-8?B?SEJydXNKbnR3MlA4c0JDOXhTL2VNWEsrNHE0cndveExYNGFRa3NJNVRwdUNv?= =?utf-8?B?YW54NUJsYTJENk1pUkVvZWtWWnZMOTNvTlNPdXp3SGZkSFliR25GaFhKMGw1?= =?utf-8?Q?WcfGxC2X95BsbCHzpyaPdfE=3D?= Content-ID: <86A4E9E4DA31114AA94F6FE4B6EF6461@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8f7646-ea50-4f1c-7719-08d9f5c6b39a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 05:46:41.3648 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: POsY/JHR9Mu43yNpn+GozXnPXykdCO+/Zm+ixcX657Ir/LfjcgxsZA+eDA7ImmSv2pJrzOepWcw8x3wfmVNGzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1366 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] lavc/vaapi_encode_h265: Add P frame to GPB frame support for hevc_vaapi X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-02-21 at 12:06 +0000, Mark Thompson wrote: > On 21/02/2022 02:13, Fei Wang wrote: > > From: Linjie Fu > > > > Use GPB frames to replace regular P frames if backend driver does not > > support it. > > > > - GPB: > > Generalized P and B picture. P frames replaced by B frames with > > forward-predict only, L0 == L1. Normal B frames still have 2 > > different ref_lists and allow bi-prediction > > > > Signed-off-by: Linjie Fu > > Signed-off-by: Fei Wang > > --- > > libavcodec/vaapi_encode.c | 33 +++++++++++++++++++++++++++++++-- > > libavcodec/vaapi_encode.h | 1 + > > libavcodec/vaapi_encode_h265.c | 15 +++++++++++++++ > > 3 files changed, 47 insertions(+), 2 deletions(-) > > This always fails immediately on current iHD > (7e357b4bea76b2fe2522e6af41ae02ea69cec49e): > > $ ./ffmpeg_g -v 44 -y -hwaccel vaapi -hwaccel_output_format vaapi -i in.mp4 > -an -c:v hevc_vaapi -low_power 1 out.mp4 > ... > [hevc_vaapi @ 0x560e81d45e80] Using input frames context (format vaapi) with > hevc_vaapi encoder. > [hevc_vaapi @ 0x560e81d45e80] Input surface format is nv12. > [hevc_vaapi @ 0x560e81d45e80] Using VAAPI profile VAProfileHEVCMain (17). > [hevc_vaapi @ 0x560e81d45e80] Using VAAPI entrypoint VAEntrypointEncSliceLP > (8). > [hevc_vaapi @ 0x560e81d45e80] Using VAAPI render target format YUV420 (0x1). > [hevc_vaapi @ 0x560e81d45e80] Using CTU size 64x64, min CB size 8x8. > [hevc_vaapi @ 0x560e81d45e80] No quality level set; using default (25). > [hevc_vaapi @ 0x560e81d45e80] RC mode: CQP. > [hevc_vaapi @ 0x560e81d45e80] RC quality: 25. > [hevc_vaapi @ 0x560e81d45e80] RC framerate: 30000/1001 (29.97 fps). > [hevc_vaapi @ 0x560e81d45e80] Use GPB B frames to replace regular P frames. > [hevc_vaapi @ 0x560e81d45e80] Using intra, GPB-B-frames and B-frames > (supported references: 3 / 3). > [hevc_vaapi @ 0x560e81d45e80] All wanted packed headers available (wanted 0xd, > found 0x1f). > [hevc_vaapi @ 0x560e81d45e80] Using level 4. > ... > [hevc_vaapi @ 0x560e81d45e80] Failed to end picture encode issue: 24 (internal > encoding error). > [hevc_vaapi @ 0x560e81d45e80] Encode failed: -5. > Video encoding failed > ... > $ cat /proc/cpuinfo | grep 'model name' | head -1 > model name : Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz > $ uname -v > #1 SMP PREEMPT Debian 5.16.7-2 (2022-02-09) > > Do you get this too, or is your setup different somehow? Hi Mark, I tested this patchset with iHD (7e357b4bea76b2fe2522e6af41ae02ea69cec49e) on CFL (low_power=0), RKL and DG1, i965 on SKL, and didn't see this issue before. This day I reproduced this issue on ICL. It seems iHD driver doesn't return right values for ICL. > > > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c > > index 3bf379b1a0..95eca7c288 100644 > > --- a/libavcodec/vaapi_encode.c > > +++ b/libavcodec/vaapi_encode.c > > @@ -1845,6 +1845,30 @@ static av_cold int > > vaapi_encode_init_gop_structure(AVCodecContext *avctx) > > ref_l1 = attr.value >> 16 & 0xffff; > > } > > > > + ctx->p_to_gpb = 0; > > + > > +#if VA_CHECK_VERSION(1, 9, 0) > > + attr = (VAConfigAttrib) { VAConfigAttribPredictionDirection }; > > + vas = vaGetConfigAttributes(ctx->hwctx->display, > > + ctx->va_profile, > > + ctx->va_entrypoint, > > + &attr, 1); > > This probably shouldn't be done at all if the user has selected a codec > without B-frames or a configuration which is intra-only, because the log > message is confusing: > > [mjpeg_vaapi @ 0x55b90d72ee00] Driver does not report whether support GPB, use > regular P frames. > [mjpeg_vaapi @ 0x55b90d72ee00] Using intra frames only. > > > + if (vas != VA_STATUS_SUCCESS) { > > + av_log(avctx, AV_LOG_WARNING, "Failed to query prediction direction > > " > > + "attribute: %d (%s).\n", vas, vaErrorStr(vas)); > > And fail? 4/4 also ignores the error. It would be better to handle the error in the same way and update 4/4 too. > > > + } else if (attr.value == VA_ATTRIB_NOT_SUPPORTED) { > > + av_log(avctx, AV_LOG_VERBOSE, "Driver does not report whether " > > + "support GPB, use regular P frames.\n"); > > "support GPB" is a strange thing to say. It's a constraint - any driver which > supports B-frames will let you have the same thing in both RefPicLists, but > some require it because they don't support P-frames. > > So maybe something like "Driver does not report any additional prediction > constraints, using P-frames."? > > > + } else { > > + if (attr.value & VA_PREDICTION_DIRECTION_BI_NOT_EMPTY) { > > + ctx->p_to_gpb = 1; > > + av_log(avctx, AV_LOG_VERBOSE, "Use GPB B frames to replace " > > + "regular P frames.\n"); > > Maybe "Driver does not support P-frames, replacing them with B-frames."? > > > + } else > > + av_log(avctx, AV_LOG_VERBOSE, "Use regular P frames.\n"); > > + } > > +#endif > > + > > if (ctx->codec->flags & FLAG_INTRA_ONLY || > > avctx->gop_size <= 1) { > > av_log(avctx, AV_LOG_VERBOSE, "Using intra frames only.\n"); > > @@ -1861,8 +1885,13 @@ static av_cold int > > vaapi_encode_init_gop_structure(AVCodecContext *avctx) > > ctx->p_per_i = INT_MAX; > > ctx->b_per_p = 0; > > } else { > > - av_log(avctx, AV_LOG_VERBOSE, "Using intra, P- and B-frames " > > - "(supported references: %d / %d).\n", ref_l0, ref_l1); > > + if (ctx->p_to_gpb) > > + av_log(avctx, AV_LOG_VERBOSE, "Using intra, GPB-B-frames and " > > + "B-frames (supported references: %d / %d).\n", > > + ref_l0, ref_l1); > > Seems easier to just say intra and B-frames (though this isn't really adding > anything to the message above - it's still effectively a P-frame referring to > one previous frame, just using B-slices to do it in a strange way). > > > + else > > + av_log(avctx, AV_LOG_VERBOSE, "Using intra, P- and B-frames " > > + "(supported references: %d / %d).\n", ref_l0, ref_l1); > > ctx->gop_size = avctx->gop_size; > > ctx->p_per_i = INT_MAX; > > ctx->b_per_p = avctx->max_b_frames; > > diff --git a/libavcodec/vaapi_encode.h b/libavcodec/vaapi_encode.h > > index b41604a883..61c5615eb8 100644 > > --- a/libavcodec/vaapi_encode.h > > +++ b/libavcodec/vaapi_encode.h > > @@ -328,6 +328,7 @@ typedef struct VAAPIEncodeContext { > > int idr_counter; > > int gop_counter; > > int end_of_stream; > > + int p_to_gpb; > > > > // Whether the driver supports ROI at all. > > int roi_allowed; > > diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c > > index e1dc53dfa9..ea45893508 100644 > > --- a/libavcodec/vaapi_encode_h265.c > > +++ b/libavcodec/vaapi_encode_h265.c > > @@ -886,6 +886,7 @@ static int > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > VAAPIEncodePicture *pic, > > VAAPIEncodeSlice *slice) > > { > > + VAAPIEncodeContext *ctx = avctx->priv_data; > > VAAPIEncodeH265Context *priv = avctx->priv_data; > > VAAPIEncodeH265Picture *hpic = pic->priv_data; > > const H265RawSPS *sps = &priv->raw_sps; > > @@ -908,6 +909,9 @@ static int > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > > > sh->slice_type = hpic->slice_type; > > > > + if (sh->slice_type == HEVC_SLICE_P && ctx->p_to_gpb) > > + sh->slice_type = HEVC_SLICE_B; > > + > > sh->slice_pic_order_cnt_lsb = hpic->pic_order_cnt & > > (1 << (sps->log2_max_pic_order_cnt_lsb_minus4 + 4)) - 1; > > > > @@ -1066,6 +1070,9 @@ static int > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > av_assert0(pic->type == PICTURE_TYPE_P || > > pic->type == PICTURE_TYPE_B); > > vslice->ref_pic_list0[0] = vpic->reference_frames[0]; > > + if (ctx->p_to_gpb && pic->type == PICTURE_TYPE_P) > > + // Reference for GPB B-frame, L0 == L1 > > + vslice->ref_pic_list1[0] = vpic->reference_frames[0]; > > } > > if (pic->nb_refs >= 2) { > > // Forward reference for B-frame. > > @@ -1073,6 +1080,14 @@ static int > > vaapi_encode_h265_init_slice_params(AVCodecContext *avctx, > > vslice->ref_pic_list1[0] = vpic->reference_frames[1]; > > } > > > > + if (pic->type == PICTURE_TYPE_P && ctx->p_to_gpb) { > > + vslice->slice_type = HEVC_SLICE_B; > > + for (i = 0; i < FF_ARRAY_ELEMS(vslice->ref_pic_list0); i++) { > > + vslice->ref_pic_list1[i].picture_id = vslice- > > >ref_pic_list0[i].picture_id; > > + vslice->ref_pic_list1[i].flags = vslice- > > >ref_pic_list0[i].flags; > > + } > > + } > > Is it sensible to implement this properly in the generic code rather than > having special ad-hoc code here? > > (Is there any chance this will also be a thing for e.g. H.264 or H.266 in > future?) Considering that VAConfigAttribPredictionDirection is not a specific attribute for hevc in VA-API, I think it is acceptable to implement this in the generic code. Thanks Haihao > > > + > > return 0; > > } > > > > - Mark > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".