From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62684421B5 for ; Tue, 29 Mar 2022 12:07:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 205C268B191; Tue, 29 Mar 2022 15:07:07 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B882F68AF09 for ; Tue, 29 Mar 2022 15:07:00 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648555626; x=1680091626; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Xaymdruel/X2y4d5+gxuHiT3cXG5n3IvMeeNYvOPJiI=; b=Tg/9TFgYRaPGBJidTgbxFyWfSzMCo2lb8lvbNJtkiIMNzan4QSn3ePDB S/C16CM4nXIinyUT56197Vhn6ZHYLeknzJI8oJPiqb43a3zo3C5JqkwTT gYMHZMvpRENsIL2rcl68rNh08LdD5g+jTxGd9d6OhO9g+3PHsB+JvjgHz ZlRUA0174hg+AOsB18QkJFrGwW4SqUXNtVP3CqRJxTW1DUO+QlvN9PGL6 wuZFupntZqIW1moWK98qOUoxQzbL48aV2rLa8piJipYU3jZ5l3S5nu4UX IwW3ELPZ9yo+Mv0HKcDrfMKXq8y41IdGh/eGDWOivVQ9WlgD9RRPRoYkQ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="258948162" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="258948162" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 05:06:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="719501481" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 29 Mar 2022 05:06:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 29 Mar 2022 05:06:50 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 29 Mar 2022 05:06:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 29 Mar 2022 05:06:49 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 29 Mar 2022 05:06:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QUuct4H5lkCQKWx8PODLgJXzr5VasCaLeWqadhDh8ti+ljnEcKab3NzoY/aPe9H0n3bLiZnuJi7Mq9C+LhSse7ppHD7gRnDTWYyWiwgykFM3JiW9VwSrhHnRPQcUk8GWOKUNBVr/VbUd8Y9UKzaqO05bVJCIwTFDi+qrXc6OTNVUE+B142tVtkE1YwCTE3KaLI+6ewBlkBl9X0UYatxDuuiuw0GvvyctbTBZlEi/R/4S6DOG4wOivJsC/zcOHwm5kOiIhuToJI9l4TRLOLipbMsNZDrfb6mhfUXDPvx0XAjhptKGuS+4sTMXxK0xA7AorS3RbPqXxHT9vTlUlXEB7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xaymdruel/X2y4d5+gxuHiT3cXG5n3IvMeeNYvOPJiI=; b=MOWnTKqe1sQMdVa+/cvtm2qc0/ZBc6NM6VF/cbwV7rsOu6jV3I8bSkKjruyGi2/guO4EetBclplcrXng1fa/O9W3Z8sLHZqndS4umrqZ4iA970KZasqWE2AA7cdoZ//y6YYNzV+DeRlFYvNCEA5topR9fuL7AoQy94VaMQgBYwSMKpaNBrPy3Ire1weIUVZvj5DSNvydByW9KIq2qeHGCpa/JLZqm2XXzmrXwXWoOZfrQ9gPn7MFe206hwisVVi5q/9UUu2bhwomNGh4R7ltiKzUGe3hg4IKJi21RudUEDFWf92Urw8VEFD9HobvSLHzCb6cj+ia5MTD1DYvLaraNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM6PR11MB4506.namprd11.prod.outlook.com (2603:10b6:5:205::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.16; Tue, 29 Mar 2022 12:06:47 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::c0b8:e06a:3d29:da25%5]) with mapi id 15.20.5102.022; Tue, 29 Mar 2022 12:06:47 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize Thread-Index: AQHYPfelm0ihhE5RgUWa2rlqar3mHazWTvuA Date: Tue, 29 Mar 2022 12:06:47 +0000 Message-ID: <3b8b9c2d837ca5229c0672c2cb997db1b9e9bafd.camel@intel.com> References: <20220322141119.595627-1-fei.w.wang@intel.com> In-Reply-To: <20220322141119.595627-1-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5fc578c8-000b-415b-c05a-08da117c9949 x-ms-traffictypediagnostic: DM6PR11MB4506:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L4dhR99mPToCqj9lH0RRYdl0bjfepc5gKgfg+peFvcpGxyq2K6RLfMFfbwfuswyq1U+Jj2BDCqNKZcvoTZOj/GS+k/y3Wpv91u0H53p8enDEqX6EenlChnpzyeZdJGrUvZwd3Id7Tqo/FKMtKqZ4Vsg77pr8fCPMbvRjSf9QogBq9aL1krBusaJnA8mkjR4prhNCmobGjEdq+FPeDKdDb/ao38dYGvbN0/zIhxxVQgLDqlkSupECEfeT1YkB2l3+/4DslzpcviOkYLptxBztyKIDL2xe17CD2iCoEmTURS6VfPYPP9NXnQaCymYVF6rtT0Ttgt7YL9UJNG4psYVYZhr1o4tTrTP0nImA97L/UAIZIZzkZKPKamgPFgktFTcpE1k0DrcreZ5BZKVp71fdkxhcaw9gzkZxxcdXr287Al3Wyv3cY7p70W/GcwgCvqi6deHas6M+IIcrOtzNd/kRCIgyZTc0B+OgU3nyG1p3wAMbrpOJ5oPN/IRmIrrjyJA9Oj8JBHop975mrOEkkIgzJ7tmmP7tvKvkh3RsZdfilwjGO72VMb1sut72VUgZNndodZFsUDJbTRnyezS05NCf0hmBElQqSEKMop9f/7XWlEdWbN04VzCRHIrEuHNu8zu2xK68zLOUFw+BhZqOXzIJ3M/TtQu/4eWdjp7wcpKvR0iBGr+jGIeqg1jetmDhuclMaJXLn2FSl1qoO2k+eseNkRWVP64q70sEwsgACWgEBHw8f3Al1qWCNuJL2Pee2wb9TNUrvssGznWwFyoXTJSuHY/NJwN6jvuzMBn2j42ynaK810Z3y2S3F5JI73NYZw0o x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(38100700002)(86362001)(76116006)(66446008)(38070700005)(82960400001)(66476007)(66556008)(64756008)(36756003)(122000001)(91956017)(6506007)(6916009)(316002)(66946007)(6512007)(508600001)(966005)(8676002)(5660300002)(6486002)(71200400001)(2906002)(107886003)(26005)(186003)(2616005)(83380400001)(54906003)(4326008)(8936002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Si9UbUZXYWZYU1JoQkdKNVcwbjltemZSWjZqQVZyekFwc2liSEw3YkExRndM?= =?utf-8?B?L04yM0RmdTZmUG9Ub1d0cUkwY0Y2QVJtbC9jMS9uRkdIS1VINmFBeU9EM0Qy?= =?utf-8?B?RWkzcENoMUhOUFRpelM2TUw1M2pyVkZkRFVVVWp1c3lZNUpPQWJram5UVk5L?= =?utf-8?B?MCswMWxCZ1FQbmhRd3RZZW1RV2xNRVNBUFBqWjlPVFMvcEh6VXlwSkIxRkk5?= =?utf-8?B?Q29qbjd1UUw4L0IxWGdDY2dFeFRzS3Y4cXZ5VzlUQnNGRFhvVDdyeU5LYnBT?= =?utf-8?B?T3dWeUxnQVlLLzUrTnVGV28yZVd1S1BweGVoTTlSQ2JiME9veGF0RHN1WnZI?= =?utf-8?B?aks5NXk4SC9xMEpwU3EwRGp5TThNeWE4RXRXUXNMV0s5K3BLQkJNaVFYMjM5?= =?utf-8?B?Z05jR2NKdjAxRm9SVHUzUjlFV2dQNG9oNlA3QlBKd0V1SGxWOE9JN3VIbGVq?= =?utf-8?B?UFFSK1U3Z1FiKzFxc2FUMEZaUlV3ZjlVV2ZaelhLMG11MUVoazR0akFBbmsx?= =?utf-8?B?ZGZ4TkMrd1JwZVRhY25DcHNSTVBxZVFDRUtyYUFTRUVCOW1KdU1aaGJKakJ3?= =?utf-8?B?UldqSVMySDAxMEhwamJpUWp2ak5YbVhvSCtWaWc2VDlvc0R6dnN0Qlg2RUcr?= =?utf-8?B?cDZld3REdXFMa2RVdC96WkRJcHBiOGliTlJDekZqMjBPU084VnN1MVFxWVhu?= =?utf-8?B?Z0RKekNEQlUwbStyQ0krd3BoSUJuSDVWdFJsak1SYkVIdlY1UUh2QlJPNCtw?= =?utf-8?B?cEhPZFdYTEJRaXBRUDkyaGp0b3REZmQrRm9IbmMrb0N0QWZ5Nkh3azJyUjBN?= =?utf-8?B?b0t4d2YyZGlyNnN2d08xdFJMTFRodEkrYUswK0xYYWFzb0VvS2J3a3NLM2hE?= =?utf-8?B?SHFzRGMrMzR4NGRIekI3MjlwOEM1Z211VEZEdGhqc05MZW9lcGlHdWwrcmx4?= =?utf-8?B?NkZkdFBPRUVGdllRc3o5UHc0YTFEeEpRV1hGU1ZnZnFKbTBqOHpVMGo5NXZy?= =?utf-8?B?MTZZNElkaGsyWTcwNStFWnpxWG1vZkRlNy9YUGJ4MURTUkx3TlpaUjdseDVR?= =?utf-8?B?R3JMVWVsNm82SGJnUGVxVjNlSW5ZdWkzdGsrdFk2TWdpb3VFWmNIaDZERUc4?= =?utf-8?B?bjVPZ0ZIdWExTEdKU2lpYzBwMWFtdVU3UVJHZVlVTlc5OFpnbUlCTVdKT1FP?= =?utf-8?B?dk9mOFJSaFNET2tFZ3N2SStNbng2NUJua2l3bGNYalVsakdpbVR5NE9CbEFz?= =?utf-8?B?Vk5pSkpQZFNCK0w3UURXL3BZM2RKVTd1ZnFLK0dvUFkydHVwNWxZcXpLMzZq?= =?utf-8?B?a3Q2WlhLUmsrd0ozUHFHWGhCeGZIeWoxU0x1dEExc3pkMjRiVk1VbGM4OEtL?= =?utf-8?B?T1FjemFKTFEwcStZbDhIdnU2bXZUY2dFVzlndFpsZFhMdUxOdUkybDJranBW?= =?utf-8?B?Y0R3ZjlZMXo3U3dlZW0xdENaY09kSFJ4Q1F5UUNteVZyZHBmTGhlZ3kyeDA0?= =?utf-8?B?aXFOOHcwb215YXZVR2p0NTlVWFdobGtrcE1GaysvNTFJa2daWFJNWjk2U2Nw?= =?utf-8?B?c25FcFBMeGUyWjR4djFGeVlyalZ0WVNhQS82RWNLam4ySzB0T2ZBeVo2VTYw?= =?utf-8?B?bmoyVE1FRnduclNGbi9EMjd2cG1Xcm1td0lVWWRwNEEwVXVRVmlyQ21vL1oz?= =?utf-8?B?ZTBMNHE2YnBiTk9NVGdRd3dDUjRkSk5raGpLNWpYQXg1azR6bjVoQWxRNjFt?= =?utf-8?B?bU1XcjhqTVVTNVB6TGZIL1k1T2dsYzJNNnpEZlpCTXgyN0JZVjFpOElZbDFQ?= =?utf-8?B?NTMxeEFGWlhXSXZPRFdaWTRMUk5Ic1I3MFRBYngxRFRCZ1dmUytsUUdIbXlo?= =?utf-8?B?Ui9JUWw0MnNZV0FDV1J2eG05TGYvZ2RCM296Q090dldkUTNpRmVrNDdrT1Vj?= =?utf-8?B?NW5DKzFVeXF6Sk02K1U1dmIxWVQreGt3T1BiSnFyVHpNWjBTVFRac1VMUDNl?= =?utf-8?B?eTJYaWJhUGQwMnczOVAyUjdtUWhyWmIwVkRpaDdWL25CTWdxanpXcExHdHFj?= =?utf-8?B?QmgveVJWQmFpcC9tbGFsTG5hcSs3OFZDb1Y4QWw3ZHc2NERqcHZ2TkprU0wx?= =?utf-8?B?Y2FHUVpjd0M3UXBMckYzdVhLbWtRZEFTdHQyckd0WW1JUHBmV3kwdExuYlFN?= =?utf-8?B?NFhrSjIzVjRCUElySHVoRUdVT252WExlUVRmV0hhZ3hTQnk1Q2drVE9JWnRU?= =?utf-8?B?VHRLYXByRFBtRFptVGFic0YxR1J1RVRUcU9hWmpyTkpsVGRGQ1VvZTZrK2ZQ?= =?utf-8?B?VVROODdsQUdyeUxhcllaN1l4QThZMEFPazAzTllMTU90T2RLbGNQdS9UOTRE?= =?utf-8?Q?OeDM0eFGgfUjzuNU=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fc578c8-000b-415b-c05a-08da117c9949 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2022 12:06:47.1085 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kuEb7Va21mO3I+NgxrWT7muZ1KoY8ympZl8iO2paZ9J58yOnVdxSYWentCGKV2LTkW5YGaMJoy5kDdJ9PBRbOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4506 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] lavc/vaapi_encode: add support for maxframesize X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wang, Fei W" , "linjie.fu@intel.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-03-22 at 22:11 +0800, Fei Wang wrote: > From: Linjie Fu > > Add support for max frame size: > - max_frame_size (bytes) to indicate the max allowed size for frame. > > If the frame size exceeds the limitation, encoder will to control the frame > size by adjusting QP value. > - MFS_NUM_PASSES to indicate number of passes for QP adjust. > - MFS_DELTA_QP to indicate adjust qp value per pass. > > To simplify the usage, default QP adjust is set to delta_qp[4] = {1, 1, 1, 1}. > Use new_qp for encoder if frame size exceeds the limitation: > new_qp = base_qp + delta_qp[0] + delta_qp[1] + ... > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -f rawvideo \ > -v verbose -s:v 352x288 -i ./input.yuv -vf format=nv12,hwupload \ > -c:v h264_vaapi -profile:v main -g 30 -bf 3 -max_frame_size 40000 \ > -vframes 100 -y ./max_frame_size.h264 > > Max frame size was enabled since VA-API version (1, 3, 0), but query is > available > since (1, 5, 0). It will be passed as a parameter in picParam and should be > set > for each frame. > > Signed-off-by: Linjie Fu > Signed-off-by: Fei Wang > --- > 1. re-send the 2 legacy patch: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715105936.4860-1-linjie.fu@intel.com/ > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20190715110000.5069-1-linjie.fu@intel.com/ > > libavcodec/vaapi_encode.c | 67 +++++++++++++++++++++++++++++++++++++++ > libavcodec/vaapi_encode.h | 19 +++++++++-- > 2 files changed, 84 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c > index ffd6cb1c25..b2782e6f9e 100644 > --- a/libavcodec/vaapi_encode.c > +++ b/libavcodec/vaapi_encode.c > @@ -365,6 +365,17 @@ static int vaapi_encode_issue(AVCodecContext *avctx, > goto fail; > } > > +#if VA_CHECK_VERSION(1, 5, 0) > + if (ctx->max_frame_size) { > + err = vaapi_encode_make_misc_param_buffer(avctx, pic, > + VAEncMiscParameterTypeMultiPassFr > ameSize, > + &ctx->mfs_params, > + sizeof(ctx->mfs_params)); > + if (err < 0) > + goto fail; > + } > +#endif > + > if (pic->type == PICTURE_TYPE_IDR) { > if (ctx->va_packed_headers & VA_ENC_PACKED_HEADER_SEQUENCE && > ctx->codec->write_sequence_header) { > @@ -1869,6 +1880,54 @@ rc_mode_found: > return 0; > } > > +static av_cold int vaapi_encode_init_max_frame_size(AVCodecContext *avctx) > +{ > +#if VA_CHECK_VERSION(1, 5, 0) > + VAAPIEncodeContext *ctx = avctx->priv_data; > + VAConfigAttrib attr = { VAConfigAttribMaxFrameSize }; > + VAStatus vas; > + int i; > + > + vas = vaGetConfigAttributes(ctx->hwctx->display, > + ctx->va_profile, > + ctx->va_entrypoint, > + &attr, 1); > + if (vas != VA_STATUS_SUCCESS) { > + ctx->max_frame_size = 0; > + av_log(avctx, AV_LOG_ERROR, "Failed to query max frame size " > + "config attribute: %d (%s).\n", vas, vaErrorStr(vas)); > + return AVERROR_EXTERNAL; > + } > + > + if (attr.value == VA_ATTRIB_NOT_SUPPORTED) { > + ctx->max_frame_size = 0; > + av_log(avctx, AV_LOG_WARNING, "Max frame size attribute " > + "is not supported.\n"); > + } else { > + ctx->delta_qp = av_calloc(MFS_NUM_PASSES, sizeof(uint8_t)); > + if (!ctx->delta_qp) { > + return AVERROR(ENOMEM); > + } > + for (i = 0; i + ctx->delta_qp[i] = MFS_DELTA_QP; > + > + ctx->mfs_params = (VAEncMiscParameterBufferMultiPassFrameSize){ > + .max_frame_size = ctx->max_frame_size, > + .num_passes = MFS_NUM_PASSES, > + .delta_qp = ctx->delta_qp, > + }; > + > + av_log(avctx, AV_LOG_VERBOSE, "Max Frame Size: %d bytes.\n ", > + ctx->max_frame_size); > + } > +#else > + av_log(avctx, AV_LOG_WARNING, "Max Frame Size is " > + "not supported with this VA version.\n"); > +#endif > + > + return 0; > +} > + > static av_cold int vaapi_encode_init_gop_structure(AVCodecContext *avctx) > { > VAAPIEncodeContext *ctx = avctx->priv_data; > @@ -2475,6 +2534,12 @@ av_cold int ff_vaapi_encode_init(AVCodecContext *avctx) > goto fail; > } > > + if (ctx->max_frame_size) { > + err = vaapi_encode_init_max_frame_size(avctx); Is this feature supported when the given rc mode is CQP ? Thanks Haihao > + if (err < 0) > + goto fail; > + } > + > vas = vaCreateConfig(ctx->hwctx->display, > ctx->va_profile, ctx->va_entrypoint, > ctx->config_attributes, ctx->nb_config_attributes, > @@ -2618,6 +2683,8 @@ av_cold int ff_vaapi_encode_close(AVCodecContext *avctx) > > av_frame_free(&ctx->frame); > > + if (ctx->delta_qp) > + av_freep(&ctx->delta_qp); > av_freep(&ctx->codec_sequence_params); > av_freep(&ctx->codec_picture_params); > av_fifo_freep2(&ctx->encode_fifo); > diff --git a/libavcodec/vaapi_encode.h b/libavcodec/vaapi_encode.h > index 1b40819c69..72f9256a8e 100644 > --- a/libavcodec/vaapi_encode.h > +++ b/libavcodec/vaapi_encode.h > @@ -60,6 +60,11 @@ enum { > PICTURE_TYPE_B = 3, > }; > > +enum { > + MFS_NUM_PASSES = 4, > + MFS_DELTA_QP = 1, > +}; > + > typedef struct VAAPIEncodeSlice { > int index; > int row_start; > @@ -191,6 +196,9 @@ typedef struct VAAPIEncodeContext { > // Desired B frame reference depth. > int desired_b_depth; > > + // Max Frame Size > + int max_frame_size; > + > // Explicitly set RC mode (otherwise attempt to pick from > // available modes). > int explicit_rc_mode; > @@ -271,7 +279,9 @@ typedef struct VAAPIEncodeContext { > #if VA_CHECK_VERSION(0, 36, 0) > VAEncMiscParameterBufferQualityLevel quality_params; > #endif > - > +#if VA_CHECK_VERSION(1, 3, 0) > + VAEncMiscParameterBufferMultiPassFrameSize mfs_params; > +#endif > // Per-sequence parameter structure (VAEncSequenceParameterBuffer*). > void *codec_sequence_params; > > @@ -331,6 +341,7 @@ typedef struct VAAPIEncodeContext { > int idr_counter; > int gop_counter; > int end_of_stream; > + uint8_t *delta_qp; > > // Whether the driver supports ROI at all. > int roi_allowed; > @@ -470,7 +481,11 @@ int ff_vaapi_encode_close(AVCodecContext *avctx); > "Increase this to improve single channel performance. This option " \ > "doesn't work if driver doesn't implement vaSyncBuffer function.", \ > OFFSET(common.async_depth), AV_OPT_TYPE_INT, \ > - { .i64 = 2 }, 1, MAX_ASYNC_DEPTH, FLAGS } > + { .i64 = 2 }, 1, MAX_ASYNC_DEPTH, FLAGS }, \ > + { "max_frame_size", \ > + "Maximum frame size (in bytes)",\ > + OFFSET(common.max_frame_size), AV_OPT_TYPE_INT, \ > + { .i64 = 0 }, 0, INT_MAX, FLAGS } > > #define VAAPI_ENCODE_RC_MODE(name, desc) \ > { #name, desc, 0, AV_OPT_TYPE_CONST, { .i64 = RC_MODE_ ## name }, \ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".