From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 8EFF34DE4C
	for <ffmpegdev@gitmailbox.com>; Fri, 25 Apr 2025 19:26:25 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE4E868A112;
	Fri, 25 Apr 2025 22:26:21 +0300 (EEST)
Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 441FE687DC4
 for <ffmpeg-devel@ffmpeg.org>; Fri, 25 Apr 2025 22:26:16 +0300 (EEST)
Received: from localhost (localhost [127.0.0.1])
 by iq.passwd.hu (Postfix) with ESMTP id DE273EC7BC
 for <ffmpeg-devel@ffmpeg.org>; Fri, 25 Apr 2025 21:23:29 +0200 (CEST)
X-Virus-Scanned: amavisd-new at passwd.hu
Received: from iq.passwd.hu ([127.0.0.1])
 by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id K9KUE2zhm1eZ for <ffmpeg-devel@ffmpeg.org>;
 Fri, 25 Apr 2025 21:23:28 +0200 (CEST)
Received: from iq (iq [217.27.212.140])
 by iq.passwd.hu (Postfix) with ESMTPS id DA5E2EC7B7
 for <ffmpeg-devel@ffmpeg.org>; Fri, 25 Apr 2025 21:23:27 +0200 (CEST)
Date: Fri, 25 Apr 2025 21:23:27 +0200 (CEST)
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <e73d5f84-f894-4066-b3b2-c8ef41c080c0@gyani.pro>
Message-ID: <3b27394c-77e1-d9b5-17d7-571cf895321b@passwd.hu>
References: <20250423141720.4033649-1-cenzhanquan2@gmail.com>
 <35b7ea21-11fe-2b5a-485b-b6565c87861a@passwd.hu>
 <e73d5f84-f894-4066-b3b2-c8ef41c080c0@gyani.pro>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 1/1] libavfilter/volume: do fade when
 adjusting the volume.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3b27394c-77e1-d9b5-17d7-571cf895321b@passwd.hu/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On Thu, 24 Apr 2025, Gyan Doshi wrote:

>
>
> On 2025-04-24 02:05 am, Marton Balint wrote:
>> 
>>
>>  On Wed, 23 Apr 2025, cenzhanquan2@gmail.com wrote:
>>
>>>  From: zhanquan cen <cenzhanquan2@gmail.com>
>>>
>>>  1. add simple fade when volume.
>>>  2. do fade when adjust volume to maximal.
>>>
>>>  when to adjust volume we hope that the audio sample is smooth
>>>  we need to calculate the gradient step between each sample based
>>>  on the total change of the gradient (i.e. dst_volume - src_volume)
>>>  and the number of samples (nb_samples) and apply it to the target sample.
>>
>>  I don't understand this. Why would you want any fading when you want to
>>  apply the audio gain uniformly over the whole duration of audio?
> It is useful to transition into the new volume level.

The afade filter (or combining volume with afade) can already support such 
a use case, no?

Regards,
Marton


> However, this shouldn't be hardcoded. Add an option for the transition time 
> with default value of 0.
>
> Regards,
> Gyan
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".