From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 620AC426C3 for ; Sat, 25 Jun 2022 02:08:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 659BE68B759; Sat, 25 Jun 2022 05:08:36 +0300 (EEST) Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A593C68B580 for ; Sat, 25 Jun 2022 05:08:29 +0300 (EEST) Received: by mail-oo1-f46.google.com with SMTP id w3-20020a4ab6c3000000b0041c1e737283so809583ooo.12 for ; Fri, 24 Jun 2022 19:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=dFh4q1CJ4778jVfir/it0/E89ERIfStxFGTZK39cnUM=; b=GjHgeYqPj4v6GEV3fdRFXiI1yRMEdLV2M+wJa3nPV6wZdMTHjSczuaF+BxQGVQH+ic RrLi1A/AaITRS6JmIk1ot05536hPUYqapMuXYWustf+m9OTTUzjMjGEw4Qoo3ZA8BcjF HlpqLpjYkSZLbIGHSh/4wLDSKJCtwdrdsvZ8fCiXz7AJWIjtZe0lXo3k7NPh/p0VkxLO JkIdZ7oC5uuyeiGJkuianpqQhMqV3ytiNoTvQ70YJHE5HwOEIjFkSADI8Ts+LG2iM0H5 E7LGF0opiZdvNFwT6m4GqbubnA2Ev+6naalqDvuAH2IbG8TBHEASU33LbxZtwsCGK4Xy qMhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=dFh4q1CJ4778jVfir/it0/E89ERIfStxFGTZK39cnUM=; b=xjvANiBBvo9A/pJyx2rDdgGFqOHUAUH/rF52isKv3qjs7KP8SmV7mVrOnOxZO7TI7i XsbVBAG2NCx3Yi29M/I7tLO4JTNee2YgLIAMFOHCE7JevxeR41OfxK+39F/MCOCE7pxd qNNHhLlpn4MiFotaBuXqvltCaKt5DK6auTu2crJglHeqjKLyA5IZR5WWR61zkGJMHUEu t7Rr96654HeSCRpBACdau4eZxML4WofZRb4i9GbH1nqGsmzW8DX/mTJRDuXoQYRc9A8b VLyEyMEd1xuahDazRLDp7FMzd+55SgHuLybmlz4V/uvtYsR464KZnZfSinwtEC3ZJOWu /X9A== X-Gm-Message-State: AJIora8sf3GQEocziJQdl9AgzsBbvkfO8e3g8AZw/0wY3To2yUX2B08t zgCw9p8WSDJivHj7Or39iA2ogqPP/Ek= X-Google-Smtp-Source: AGRyM1u6gTFhJQTcO1BXBvGCxLdB4+LJy3MPGlOpe4bZqhjAxeCfsK+KX67n5Z/2VfDhvowagVUIMA== X-Received: by 2002:a4a:864b:0:b0:425:71ed:ada7 with SMTP id w11-20020a4a864b000000b0042571edada7mr961983ooh.92.1656122906769; Fri, 24 Jun 2022 19:08:26 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id k12-20020a4a2a0c000000b0041bcf7c8414sm2229673oof.48.2022.06.24.19.08.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 19:08:26 -0700 (PDT) Message-ID: <3ae7c743-3215-124a-9af4-1663dbfbde92@gmail.com> Date: Fri, 24 Jun 2022 23:08:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220625020323.16181-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avformat/http: include version.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/24/2022 11:06 PM, Andreas Rheinhardt wrote: > James Almer: >> This is needed to get LIBAVFORMAT_VERSION, used as part of the user agent. >> Fixes a recent regression. >> >> Signed-off-by: James Almer >> --- >> I dislike the fact AV_STRINGIFY() silenced the warning that should have been >> printed about LIBAVFORMAT_VERSION being undefined. >> >> Before: >> ./ffmpeg -h protocol=http >> -user_agent .D......... override User-Agent header (default "Lavf/LIBAVFORMAT_VERSION") >> >> After: >> ./ffmpeg -h protocol=http >> -user_agent .D......... override User-Agent header (default "Lavf/59.25.100") >> >> I suppose this is a regression since the recent work to split the library >> version defines into separate headers. >> >> libavformat/http.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/http.c b/libavformat/http.c >> index f80ea7bf35..c5c48c7900 100644 >> --- a/libavformat/http.c >> +++ b/libavformat/http.c >> @@ -41,6 +41,7 @@ >> #include "network.h" >> #include "os_support.h" >> #include "url.h" >> +#include "version.h" >> >> /* XXX: POST protocol is not completely implemented because ffmpeg uses >> * only a subset of it. */ > > LGTM. > > - Andreas Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".