From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 019874E524
for <ffmpegdev@gitmailbox.com>; Sun, 4 May 2025 02:58:56 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1645F68BA4B;
Sun, 4 May 2025 05:58:09 +0300 (EEST)
Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com
[209.85.214.173])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 758BC68B9BE
for <ffmpeg-devel@ffmpeg.org>; Sun, 4 May 2025 05:58:07 +0300 (EEST)
Received: by mail-pl1-f173.google.com with SMTP id
d9443c01a7336-227b828de00so35974415ad.1
for <ffmpeg-devel@ffmpeg.org>; Sat, 03 May 2025 19:58:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1746327486; x=1746932286; darn=ffmpeg.org;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date
:references:in-reply-to:message-id:from:from:to:cc:subject:date
:message-id:reply-to;
bh=pxjhzbbUyvZsAW4Fyk124j5RDnHMWaIRnLwyzWW+03g=;
b=ExUkL1+xiavp0tNtMZJuWHBlvA+l2hRl7TLghNru5sfrOG2axWvSIVaFAvskLJoADm
H84EsJ8uaDHzdjoIRgUXBB3ceuxooSDShJDWB5xrTJQBJhm7k8CGWBLYUQblwhqjbwdD
pHrONYmjMsguTYJGG7e54vK1LxevCI2YEcs5xcDVGEF6wI8gwHYoql9C2N8X6TqX5AlS
DGHfmlxbK3SdeJY6sPki5BUhV130A2OqOg2odWnX6OkTBGWRP8W64rquYLfD+pj4LOFG
SvRO81NFu4hjA6Cn6aWvYYS3EDctUc+OdD56kRIgathEk5u7ClMsCm51kCX8j3UhNzbE
OKxg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1746327486; x=1746932286;
h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date
:references:in-reply-to:message-id:from:x-gm-message-state:from:to
:cc:subject:date:message-id:reply-to;
bh=pxjhzbbUyvZsAW4Fyk124j5RDnHMWaIRnLwyzWW+03g=;
b=Nd+22qLDOTOsZ7VzKdvci3m/4IdA6KZDwUPktZ0Me5BnawsLGwweSUeiWHZ3A+zp1b
d/oFMp/6AMRLcbH7IE98tEgpSnRMPbm5uVQCuBmeMJ8UcKycKBaGzRmwPb3S7rIvhLRs
PqVUfZ6oIk2rTWDaQvP7QWbL9ADE0M4TsZmV83um14nw+yhx9rLK1KhtYnBCW/jovkAx
18XiE1/Vd+dKDdSf+Cw3eqibrnyTw8JmcfnTUV1AOyyBZkAE3uBSuafAaI+SIo5NtINL
XdZizlWRIStVLtA8E1++0bUe0AlPJVy5AME9Zus/f7dC6Gg7UBLuNhwMswhWBqwZsYs0
MdFw==
X-Gm-Message-State: AOJu0YwCRetZWm9zl2KtGAC2Pcx6EXN4BnHN9L5cCpgMLAd0lcVlT/5j
JWaS2LYj4HrjIVo7AmdkQjL1ME4HYIJbTki/tbNpB4rVLmjYrCql0xU9mg==
X-Gm-Gg: ASbGnct0E3MmYGr4/y65kGkH3U4OR9/lq1/mlZK5qb5NQqrHOTa1FdXj0PRJ6he1M1K
x3nfMTnmej9hMMk9B48CsVi6FBqS43Sly8A83xIh7vjhQs2eji+EXmcrQ5gHK161DqqnlO5ldtN
PvRWwGeZ2ozkp7b3vRMcHd+w+i2nQeeh/PdddotWGVyWtL5TmC8JDTNU3rxbgNanwwW5Tb4F9hL
eudT6bYBcKsLc5CixU6LO4OOMljyDQSn1ws29Rxl8HbJJ4lWxpTTsDngoxaDVbjw5wc3iMGhT72
brkofv/+0wYWbRsr6IFWs1XjmVQcAJ4Uh+dVCCzOV3yFRIq0AZm0+EFrQ84=
X-Google-Smtp-Source: AGHT+IEMDivqqQEKxN+Hqe3pSIA7zwj9OJzRGws7DLZiCUYiwcAfWNcDTJlkrp+dSmnkXg+0dmTcPQ==
X-Received: by 2002:a17:902:f54e:b0:220:c63b:d93c with SMTP id
d9443c01a7336-22e18c4f10cmr75748555ad.44.1746327485601;
Sat, 03 May 2025 19:58:05 -0700 (PDT)
Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-22e1521fc27sm30762815ad.151.2025.05.03.19.58.05
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Sat, 03 May 2025 19:58:05 -0700 (PDT)
From: softworkz <ffmpegagent@gmail.com>
X-Google-Original-From: softworkz <softworkz@hotmail.com>
Message-Id: <3aa16bc39f30554808c946673dd3862380314788.1746327446.git.ffmpegagent@gmail.com>
In-Reply-To: <pull.66.v10.ffstaging.FFmpeg.1746327446.ffmpegagent@gmail.com>
References: <pull.66.v9.ffstaging.FFmpeg.1746260565.ffmpegagent@gmail.com>
<pull.66.v10.ffstaging.FFmpeg.1746327446.ffmpegagent@gmail.com>
Date: Sun, 04 May 2025 02:57:17 +0000
Fcc: Sent
MIME-Version: 1.0
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce
AVTextFormatOptions for avtext_context_open()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: softworkz <softworkz@hotmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/3aa16bc39f30554808c946673dd3862380314788.1746327446.git.ffmpegagent@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
From: softworkz <softworkz@hotmail.com>
This allows future addition of options without
changes to the signature of avtext_context_open().
Reviewed-by: Stefano Sabatini <stefasab@gmail.com>
Signed-off-by: softworkz <softworkz@hotmail.com>
---
fftools/ffprobe.c | 13 +++++++++----
fftools/textformat/avtextformat.c | 21 ++++++++-------------
fftools/textformat/avtextformat.h | 16 +++++++++-------
3 files changed, 26 insertions(+), 24 deletions(-)
diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
index f5c83925b9..1277b1e4f9 100644
--- a/fftools/ffprobe.c
+++ b/fftools/ffprobe.c
@@ -3168,10 +3168,15 @@ int main(int argc, char **argv)
if (ret < 0)
goto end;
- if ((ret = avtext_context_open(&tctx, f, wctx, f_args,
- sections, FF_ARRAY_ELEMS(sections), show_value_unit,
- use_value_prefix, use_byte_value_binary_prefix, use_value_sexagesimal_format,
- show_optional_fields, show_data_hash)) >= 0) {
+ AVTextFormatOptions tf_options = {
+ .show_optional_fields = show_optional_fields,
+ .show_value_unit = show_value_unit,
+ .use_value_prefix = use_value_prefix,
+ .use_byte_value_binary_prefix = use_byte_value_binary_prefix,
+ .use_value_sexagesimal_format = use_value_sexagesimal_format,
+ };
+
+ if ((ret = avtext_context_open(&tctx, f, wctx, f_args, sections, FF_ARRAY_ELEMS(sections), tf_options, show_data_hash)) >= 0) {
if (f == &avtextformatter_xml)
tctx->string_validation_utf8_flags |= AV_UTF8_FLAG_EXCLUDE_XML_INVALID_CONTROL_CODES;
diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
index b2c3aa3fc7..91469ef576 100644
--- a/fftools/textformat/avtextformat.c
+++ b/fftools/textformat/avtextformat.c
@@ -125,13 +125,7 @@ void avtext_context_close(AVTextFormatContext **ptctx)
int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *formatter, AVTextWriterContext *writer_context, const char *args,
- const AVTextFormatSection *sections, int nb_sections,
- int show_value_unit,
- int use_value_prefix,
- int use_byte_value_binary_prefix,
- int use_value_sexagesimal_format,
- int show_optional_fields,
- char *show_data_hash)
+ const AVTextFormatSection *sections, int nb_sections, AVTextFormatOptions options, char *show_data_hash)
{
AVTextFormatContext *tctx;
int i, ret = 0;
@@ -154,11 +148,11 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
goto fail;
}
- tctx->show_value_unit = show_value_unit;
- tctx->use_value_prefix = use_value_prefix;
- tctx->use_byte_value_binary_prefix = use_byte_value_binary_prefix;
- tctx->use_value_sexagesimal_format = use_value_sexagesimal_format;
- tctx->show_optional_fields = show_optional_fields;
+ tctx->show_value_unit = options.show_value_unit;
+ tctx->use_value_prefix = options.use_value_prefix;
+ tctx->use_byte_value_binary_prefix = options.use_byte_value_binary_prefix;
+ tctx->use_value_sexagesimal_format = options.use_value_sexagesimal_format;
+ tctx->show_optional_fields = options.show_optional_fields;
if (nb_sections > SECTION_MAX_NB_SECTIONS) {
av_log(tctx, AV_LOG_ERROR, "The number of section definitions (%d) is larger than the maximum allowed (%d)\n", nb_sections, SECTION_MAX_NB_SECTIONS);
@@ -201,7 +195,7 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
av_dict_free(&opts);
}
- if (show_data_hash)
+ if (show_data_hash) {
if ((ret = av_hash_alloc(&tctx->hash, show_data_hash)) < 0) {
if (ret == AVERROR(EINVAL)) {
const char *n;
@@ -212,6 +206,7 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
}
goto fail;
}
+ }
/* validate replace string */
{
diff --git a/fftools/textformat/avtextformat.h b/fftools/textformat/avtextformat.h
index 8ff503401a..87f57d8c24 100644
--- a/fftools/textformat/avtextformat.h
+++ b/fftools/textformat/avtextformat.h
@@ -117,17 +117,19 @@ struct AVTextFormatContext {
unsigned int string_validation_utf8_flags;
};
+typedef struct AVTextFormatOptions {
+ int show_optional_fields;
+ int show_value_unit;
+ int use_value_prefix;
+ int use_byte_value_binary_prefix;
+ int use_value_sexagesimal_format;
+} AVTextFormatOptions;
+
#define AV_TEXTFORMAT_PRINT_STRING_OPTIONAL 1
#define AV_TEXTFORMAT_PRINT_STRING_VALIDATE 2
int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *formatter, AVTextWriterContext *writer_context, const char *args,
- const AVTextFormatSection *sections, int nb_sections,
- int show_value_unit,
- int use_value_prefix,
- int use_byte_value_binary_prefix,
- int use_value_sexagesimal_format,
- int show_optional_fields,
- char *show_data_hash);
+ const AVTextFormatSection *sections, int nb_sections, AVTextFormatOptions options, char *show_data_hash);
void avtext_context_close(AVTextFormatContext **tctx);
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".