[FFmpeg-devel] [PATCH] configure: Ignore nullability-completeness apple clang warnings

[FFmpeg-devel] [PATCH] configure: Ignore nullability-completeness apple clang warnings

[Dmitriy Kovalenko]

Some of the versions of Apple Clang produces a ton of the warnings
related to the missing nullablity specifiers on the existing codebase of
ffmpeg which significantly slows down the compilation becuase of the
produced output size (especially on CI as a part of external build systems
because they usually analyze every single line of the produced stdout).

This patch turns them off when compiling for darwing targets.

And because apple's nullablity specifiers obviously are not used in the
codebase having this warning turn of just makes sense.
---
 configure | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configure b/configure
index 89a766b403..54dd54360f 100755
--- a/configure
+++ b/configure
@@ -5860,6 +5860,9 @@ case $target_os in
             test ${clang_version%%.*} -eq 11 && add_cflags -fno-stack-check
         fi
 
+        # Apple Clang has by default enabled nullability warnings that 
+        # create a ton of output noise and significantly slows 
+        add_cflags -Wnullability-completeness 
         # Xcode Clang doesn't default to -fno-common while upstream llvm.org
         # Clang (and GCC) do. This avoids linker warnings on Xcode 16.3 about
         # "reducing alignment of section __DATA,__common from 0x8000 to 0x4000
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: Ignore nullability-completeness apple clang warnings

[Marvin Scholz]

On 5 Jun 2025, at 23:06, Dmitriy Kovalenko wrote:

> Some of the versions of Apple Clang produces a ton of the warnings
> related to the missing nullablity specifiers on the existing codebase of
> ffmpeg which significantly slows down the compilation becuase of the
> produced output size (especially on CI as a part of external build systems
> because they usually analyze every single line of the produced stdout).
>
> This patch turns them off when compiling for darwing targets.
>
> And because apple's nullablity specifiers obviously are not used in the
> codebase having this warning turn of just makes sense.

Hi, thanks for the patch.

Which version did you saw this with as I did not notice those warnings yet?

> ---
>  configure | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index 89a766b403..54dd54360f 100755
> --- a/configure
> +++ b/configure
> @@ -5860,6 +5860,9 @@ case $target_os in
>              test ${clang_version%%.*} -eq 11 && add_cflags -fno-stack-check
>          fi
>
> +        # Apple Clang has by default enabled nullability warnings that
> +        # create a ton of output noise and significantly slows
> +        add_cflags -Wnullability-completeness

You can not unconditionally add this, it will break older compiler versions that
do not support that flag.

>          # Xcode Clang doesn't default to -fno-common while upstream llvm.org
>          # Clang (and GCC) do. This avoids linker warnings on Xcode 16.3 about
>          # "reducing alignment of section __DATA,__common from 0x8000 to 0x4000
> -- 
> 2.49.0
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: Ignore nullability-completeness apple clang warnings

[Martin Storsjö]

On Thu, 5 Jun 2025, Dmitriy Kovalenko wrote:

> Some of the versions of Apple Clang produces a ton of the warnings
> related to the missing nullablity specifiers on the existing codebase of
> ffmpeg which significantly slows down the compilation becuase of the
> produced output size (especially on CI as a part of external build systems
> because they usually analyze every single line of the produced stdout).
>
> This patch turns them off when compiling for darwing targets.
>
> And because apple's nullablity specifiers obviously are not used in the
> codebase having this warning turn of just makes sense.
> ---
> configure | 3 +++
> 1 file changed, 3 insertions(+)

I don't remember ever seeing such a warning; is this something that only 
appears in some specific build configuration? Can you elaborate on what 
build configuration that is, and give an example of such a warning? (Such 
data would be quite relevant to include in the commit message.)

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".