From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 628EC4CD8D for ; Mon, 1 Dec 2025 00:19:53 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'ztl8uCNvTBHfisl+RZnUhJxrnL1j6yyOgka1yww3jvU=', expected b'RR95wFMPjt5VOCN8n5gnCv7aZU2eceZKGTFUfxA5m2g=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1764548320; h=mime-version : date : references : to : in-reply-to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=K/R9TMX/c1u22VQ4TSO0/EXQB9E4s7s4umLhDSEsIBs=; b=aX76+YnACw1MQwCTmvTO5JL8FbwF+GONNwtumxCLxTvpCe20Q0vN7c75AVd0eYR011753 rP2vadTk8dMveFZKYLPW6CyZAGk7iMjPKTAuzPd+uFWS4xJYguv95neI+O3diNZyOZusA9o I0NkAQATLk5XI7Zu6a0sVKIWwF1EWGvPyvvnfYDU60TEhTe5NKSL+KlW1KnNBkNTh0R4JXQ OmRpPnTLUkL8HAFevzOv94xU0JPoQ8xBdag0FzuBFc5su55KoCyUrlf5/7jIuxR9hSKjis2 cxxC87JrEIobYaA1UnGjLOTosNxeqtYj3PbXiZzvYNQE5AvDScUmT6SQMZxQ== Received: from [172.19.0.3] (unknown [172.19.0.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 206AE6902F5; Mon, 1 Dec 2025 02:18:40 +0200 (EET) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1764548291; b=QgMs57Rlj5s43qLJTs8QRfnuahG24qesUB4SvT6Gn+UzROg6KAKTbK0WtgzcFtwKVZ2h7 fIheW9RRqreU+4/g6s0C897yhYsLtK6Ka9TfYYaPOEg3giV4+MRsFv1klyN/XJYfBeTP7os tA1+H1Zl3v0AII43hGsQB49WgR1n0OpzbbWOHB7bhxwYEOAv6J/ePU0NgSntwQVQtiBkhm1 F1D8QLvs4+hIMNSvVe8sp6BL2nVVEEL82tG5MiSxoRzAbw5WLSQd3yQrS4AXho+ZiAwkG29 1W71iYXWF1vScMmHGG4wcbmCKhJindxgrjNCDwdzidS7hZKksF7Uwyzz8tPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1764548291; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=ztl8uCNvTBHfisl+RZnUhJxrnL1j6yyOgka1yww3jvU=; b=cL8LI81rTMbOVSvPonAcrqjE8D0HvwK8LQNa6L8r21LT1Y1C5YFjoY5cYR1vaWqRTkRY0 fYE+uYZy3Y+mxbwQIhj3adcDyOtNecemQAhmtWCIob+zgnExxYcdohok+uNdQyrA504/fGY PbBdogTTsHFSRkY/vzBo73LFknn5Ok4z4c5lTjIHMNj+L3sIT4m1i0Cf+10f8YBKb3Y0TAD dkfdaTRKho4RFf4DOrEMcZ9lqXZPd4Cz8/E54QmV/fcUXlvowlD47ensJRswM3lyIjkENXu aZYXi1P9Cy4+tHMO+68Kfn+fBz0e1i+0AIlpglAXzIyh1qvP3+cdQhhfbbyg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id ACBB468EDAC for ; Mon, 1 Dec 2025 02:17:57 +0200 (EET) Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b99bfb451e5so2279301a12.2 for ; Sun, 30 Nov 2025 16:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764548275; x=1765153075; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=RR95wFMPjt5VOCN8n5gnCv7aZU2eceZKGTFUfxA5m2g=; b=ESezalFEy5O3KVkSrKumxwm1zYxGn7o+QVfohwVnwdIdMygST+Cfe+C68c4pmW/VWu pO2btE3+ovv97ouyyJHJPq7TkcHMVknb8uXXA9EMvkxeLOW33L3kE9YedIcye0irm/au nWinzjPgsaukCzIHe4pFq7aklt9xzRJhnWRGyDGleiqGcQEEP6PBiu8EFg2nqZJWh3tv IFlgaX/qxBK4Epf3vf3ocW1KK8M2/vozGz1mI2Xp2ZodU+VJyjM3mWowekflbTl56wzR +dIPt+TTkXDZKYWsendd8UX6AxOD/NcrfqaGv3U8eaHpGWUvsUjsHWEPp5bGCo+jM4bV c57A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764548275; x=1765153075; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RR95wFMPjt5VOCN8n5gnCv7aZU2eceZKGTFUfxA5m2g=; b=iyDnaawBdByr79fCvv7JiOB4DKzrCnDlyzGD+nVZcuMMGgAWBj/k34OXCT8b9alQpH 8mQM/2d/3Jg59M7/MSRZ1LMgpdITK6T15817ZXwdadSRV556AH0Vc8jvHr1sqyvUt8wL Gghqk2ziBBgBmA9nbqfIB6m1E3p+p88J8WjglCYIUGH+dCJco1Pm0vhkgsntZyzmon+h 00B5OoCkRKCy2b14W/5BcXSYn+LRTZ3H85ppbW0ePKoXNQMhl5Xorw9O5X7jEijyF5F7 e/DsjRGJwT3Qj/Pl30d5hLOpeT+oHGmzE/0zefaKoUAlvTTLBMgHdDWCc2Pnk/28Nsls 66UA== X-Gm-Message-State: AOJu0YyIQi8sKKd9ziI3AUjlCpMDfF02u1gD8+Y/MZGWwo4Nkvhyaw29 AGfrhKglY60ReNbL8h8mR1EapKKaaclFTzfFY8t2fVfOR1c7sEHHMG3cqUnKcw== X-Gm-Gg: ASbGnct5Bxe1iUUyfWXRQt3cLeAZa2pESwALLhTzUwXDebTCgC21tAJxfCJgYjzG84w ZiNG56hMp0TLsbWkLnmBIiqc8kCM+LXLoapgYRJZk3RKkDK/TV+gF3oQhhIjSN6FdcsYWxu0dSW z+78InkM/p88nrXK5UinUGnLyzdVnHGvsoV7XbqMKrfPDx8Ztp+wohDB4wuBYcnTZMlvMle1Ctc 8MaStLo02577vfHDvpCPkClsMakB/sPWzfiFDysdjIg/JuPRotHCATUsNwScD+vP1QL4xZQ0wMx UvfEctvl7UA2wXPkffqOLMuB89oPA1yNce6jWjlhhBcLllTLEViu1F4SAhaLhWDw+J2PCNg3AWO yf2mcredH8PCDi/8xtrbzmDh+KshJ0vN6/3dPSlS27vuhqpwrH/eYpxrxQkYOC3xZtHKtBIjkT8 MYpmLLKgszx2e/72skHsCd3JSZ+7ntxrguGg== X-Google-Smtp-Source: AGHT+IFbPyHcJq9eSYekqiJk0d6y8bQaJx3iN4oUDO+o3NKtfFH5JJliCRMtqMfUHvpsMqYEEJswrw== X-Received: by 2002:a05:7022:f684:b0:119:e56b:98c0 with SMTP id a92af1059eb24-11cbba53775mr18296185c88.39.1764548275161; Sun, 30 Nov 2025 16:17:55 -0800 (PST) Received: from smtpclient.apple ([23.247.137.216]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcb067088sm36165381c88.10.2025.11.30.16.17.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Nov 2025 16:17:54 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\)) Date: Mon, 1 Dec 2025 08:17:41 +0800 References: <20250808001741.23533-1-jiashengjiangcool@gmail.com> To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <3C30B1D2-11F3-4BC0-AFB2-5033A5F2DF17@gmail.com> X-Mailer: Apple Mail (2.3826.700.81.1.3) Message-ID-Hash: CLHM64KDCZEU7SVFIJSBAH5Z7LQD7WFV X-Message-ID-Hash: CLHM64KDCZEU7SVFIJSBAH5Z7LQD7WFV X-MailFrom: SRS0=k1Sd=6H=gmail.com=jacklau1222gm@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Content-Filtered-By: Mailman/MimeDel 3.3.10 X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] libavformat/whip: Add av_freep() to avoid potential memory leak List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: > On Aug 8, 2025, at 19:07, Nicolas George wrote: > > Jiasheng Jiang (HE12025-08-08): >> I found that after the success of avio_alloc_context(), buffer is >> assigned to rtp_ctx->pb->buffer and will be freed in whip_deinit(). >> Therefore, I think moving av_freep() after end would cause a double >> free. > > Indeed, you are right, I had not checked that. > > With your change, if somebody adds an extra operation that might fail > between allocating the buffer and using it in the avio context. It might > be better to free the buffer at the end and set it to NULL if > avio_alloc_context() succeeds to avoid the double free, but that is very > minor. Hi Nicolas, I guess this patch https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/21069 is what you described. Thanks for your helpful suggestion! > > So no objection to the patch, just take half a second considering my > suggestion. > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". Best Regards, Jack _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org