From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2D9ED410C6 for ; Fri, 23 May 2025 20:23:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2707E68DF2B; Fri, 23 May 2025 23:23:48 +0300 (EEST) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 33B5F68DF13 for ; Fri, 23 May 2025 23:23:45 +0300 (EEST) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-441d1ed82faso1339585e9.0 for ; Fri, 23 May 2025 13:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748031825; x=1748636625; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hg6oRlvRSTYt/gJCb08J/GGmhCSXv7pLb96dEP1cx+A=; b=LUoGKmJKqpH8XiwJx9Zpey8fR6DvrHHMvkd/0F2zLuohEbfsNpcv6fOObKrASYDJW+ 2OEgKkXYR7wr8k/wEnf2QRTbyGVeBElbeCwMt6dM6SJEQf4wMPSffhlDAejPKLnLEpvL /HPCtrU82E/DmPrqECRglyhj/8lBMNrC5/wJF+VbDAVYL0EPY6Dl83DErJ2FB53ugVxA z6GStZ8drdc+kH1UwjmIyy76c7ExQNIiEnqzfuumwvIXGrbYNTMvuNGLwW/U8rz16n39 fVYe2oHoqPdZIQFf6LrzL49w7r4j+GZPPewE6SQNOkVtl2rrZ9zb/DyhqF1fy7u1GFVq P1Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748031825; x=1748636625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hg6oRlvRSTYt/gJCb08J/GGmhCSXv7pLb96dEP1cx+A=; b=rAARUoCAWs5a0mhw0Vy6jAhbjQF+mh6LmFJBP8th3mNfoHqxRnm9rtSIF3KdyMIPkk ogXZzO07iEvnVlb2+Bmj6UlY/4gvQAIbsZh8QOsnEix+zKLOnnYB8fdmuRpSQch+j5w/ t4IzhNd2zsQjT9bcFSFHcHHOpal4n/21b+f5sgnZS47hFOAwVZ08hDWFYThHgdBB5wRV jndXOUdhud6i677tEHp7JFSN3Ujvur9eQR7JSWCmmhZE33lLeKfTyuDjXs/tRPKNum86 3AqGu6F1BLSm8dBpPYmPshu5jZ2dGitPAXWOOPaz6W5Nf8Hb183XCDYzlQ4jkHXJIF6D Zizw== X-Gm-Message-State: AOJu0YxXkYW1hTWOnTD+BE6cxmIUooj9sp58KOZ3QK8bzysUmgyX6ps6 mYGk+TqrrjWOeZZMKkABtbrMMPM4hGA0f/TiyjSQBX0//rxe+ZASnsaRJjfb/A== X-Gm-Gg: ASbGncuWDya9JX/6zAsAaYDTHAetDp52wzKHloCD1ZhvrGqotFxNFKEp4EgQIXFONSx mtY8Fv4IW8c6SA0rmYJ0UD40gKrNXMsAn+Snby4mTey9StrNZUwc8WFYGJKT2hA+CllydIp9/a7 1ga9PDRwVSSjrjMxDcJV7VJm9ML8ghynK3JsuMZBXh11fUKsf4PqENg8vVE08LTHxR2ZdELtJw2 iakTp6vl4KJF7Ed9IezXxfM1tisNesjmNRQn3RS8ll+GEMB9bI/JFwR9VBUc4oriv2IMGxUMu4f tBIUFvU5I0ugjJTgWP26S+FGOShwFwSSg+N32wl5eUkupBN6koH22AmW3t0dXKK4ooPbz8mvb2p UpXB0/HGOlZv33yZMiBJZMBmLCSNKzQmpzqs9pZXorDzMtOl71F51mkNTJOvTpVxlYNJMe6Vj X-Google-Smtp-Source: AGHT+IEVnB0ebuMXakEvmlnpud9BhLlkfWpW/qEKWz6uf6z2Akhmb1C2Qbm+0Z2k7Pci7O+evvdBIw== X-Received: by 2002:a05:600c:698c:b0:43c:fd27:a216 with SMTP id 5b1f17b1804b1-44c9493ec0amr3183395e9.23.1748031825021; Fri, 23 May 2025 13:23:45 -0700 (PDT) Received: from [192.168.178.57] (p200300cccf0693000481753c52e895c0.dip0.t-ipconnect.de. [2003:cc:cf06:9300:481:753c:52e8:95c0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f7baaf2asm153844205e9.34.2025.05.23.13.23.43 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 May 2025 13:23:44 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Fri, 23 May 2025 22:23:42 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <3991CD1D-4745-4B4B-9D17-D4FB553E01A6@gmail.com> In-Reply-To: <20250523185309.GG29660@pb2> References: <20250523001124.38155-1-epirat07@gmail.com> <20250523185309.GG29660@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/sdp: add framerate entry X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 23 May 2025, at 20:53, Michael Niedermayer wrote: > Hi Marvin > > On Fri, May 23, 2025 at 02:11:24AM +0200, Marvin Scholz wrote: >> --- >> libavformat/sdp.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/libavformat/sdp.c b/libavformat/sdp.c >> index 215e38f8fc..21ada5d1ce 100644 >> --- a/libavformat/sdp.c >> +++ b/libavformat/sdp.c >> @@ -867,6 +867,9 @@ int ff_sdp_write_media(char *buff, int size, const AVStream *st, int idx, >> if (p->bit_rate) { >> av_strlcatf(buff, size, "b=AS:%"PRId64"\r\n", p->bit_rate / 1000); >> } >> + if (p->framerate.num > 0 && p->framerate.den > 0) { >> + av_strlcatf(buff, size, "a=framerate:%g\r\n", av_q2d(p->framerate)); >> + } >> >> return sdp_write_media_attributes(buff, size, st, payload_type, fmt); >> } >> -- >> 2.39.5 (Apple Git-154) > > breaks fate: > > TEST lavf-mov_rtphint > --- ./tests/ref/lavf/mov_rtphint 2025-05-23 14:14:31.476447585 +0200 > +++ tests/data/fate/lavf-mov_rtphint 2025-05-23 20:51:14.221038582 +0200 > @@ -1,3 +1,3 @@ > -d3d0b0a15e2207e1d69b7de5c0ff845c *tests/data/lavf/lavf.mov_rtphint > -365745 tests/data/lavf/lavf.mov_rtphint > +e5e994cd3885a28304229f5e277c1917 *tests/data/lavf/lavf.mov_rtphint > +365761 tests/data/lavf/lavf.mov_rtphint > tests/data/lavf/lavf.mov_rtphint CRC=0xbb2b949b > Test lavf-mov_rtphint failed. Look at tests/data/fate/lavf-mov_rtphint.err for details. > make: *** [tests/Makefile:316: fate-lavf-mov_rtphint] Error 1 > Indeed it changed because it includes the SDP. Sent a new version that updates the ref accordingly. > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Many that live deserve death. And some that die deserve life. Can you give > it to them? Then do not be too eager to deal out death in judgement. For > even the very wise cannot see all ends. -- Gandalf > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".