Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: remove always false condtion

[Steven Liu <lq@chinaffmpeg.org>]

> 2021年12月24日 下午5:58，Zhao Zhili <quinkblack@foxmail.com> 写道：
> 
> 203b0e35 made duration unsigned.
> ---
> libavformat/mov.c | 11 -----------
> 1 file changed, 11 deletions(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 63483740a0..636cfce400 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -3972,17 +3972,6 @@ static void mov_build_index(MOVContext *mov, AVStream *st)
> 
>                 current_offset += sample_size;
>                 stream_size += sample_size;
> -
> -                /* A negative sample duration is invalid based on the spec,
> -                 * but some samples need it to correct the DTS. */
> -                if (sc->stts_data[stts_index].duration < 0) {
> -                    av_log(mov->fc, AV_LOG_WARNING,
> -                           "Invalid SampleDelta %d in STTS, at %d st:%d\n",
> -                           sc->stts_data[stts_index].duration, stts_index,
> -                           st->index);
> -                    dts_correction += sc->stts_data[stts_index].duration - 1;
> -                    sc->stts_data[stts_index].duration = 1;
> -                }
>                 current_dts += sc->stts_data[stts_index].duration;
>                 if (!dts_correction || current_dts + dts_correction > last_dts) {
>                     current_dts += dts_correction;
> -- 
> 2.31.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 

Yes, this is a warning when compiling the mov.o module, but not sure if the duration is unsigned can small than 0,
Because there have some way about unsigned int use way,not sure it corect or not:
Eg. unsigned int example = -1;

Thanks

Steven Liu

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".