From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI Date: Tue, 08 Jul 2025 20:26:21 +0200 Message-ID: <39784A97-A26B-47EA-9570-9DFE8B4AB382@gmail.com> (raw) In-Reply-To: <aG1giO9Fv-ytBky1@phare.normalesup.org> On 8 Jul 2025, at 20:16, Nicolas George wrote: > Marvin Scholz (HE12025-07-08): >> --- >> libavformat/tls_openssl.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c >> index 7614caf089..e65914f11a 100644 >> --- a/libavformat/tls_openssl.c >> +++ b/libavformat/tls_openssl.c >> @@ -928,7 +928,11 @@ static int tls_open(URLContext *h, const char *uri, int flags, AVDictionary **op >> ret = AVERROR(EIO); >> goto fail; >> } >> - SSL_set_tlsext_host_name(p->ssl, c->host); >> + if (!SSL_set_tlsext_host_name(p->ssl, c->host)) { >> + av_log(h, AV_LOG_ERROR, "Failed to set hostname for SNI: %s\n", openssl_get_error(p)); > >> + ret = AVERROR(EIO); > > AVERROR_EXTERNAL > Indeed, will send a new set with the error code changed. We should probably eventually change most of the other ones to that as well, as right now nearly all are AVERROR(EIO) even if its not an IO error at all. >> + goto fail; >> + } >> } >> ret = c->listen ? SSL_accept(p->ssl) : SSL_connect(p->ssl); >> if (ret == 0) { >> -- >> 2.39.5 (Apple Git-154) >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > -- > “I dont see why” isnt an argument. Proposing better is. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-08 18:26 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-07-08 18:06 [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification Marvin Scholz 2025-07-08 18:06 ` [FFmpeg-devel] [PATCH 2/3] avformat/tls_openssl: verify setting hostname for SNI Marvin Scholz 2025-07-08 18:16 ` Nicolas George 2025-07-08 18:26 ` Marvin Scholz [this message] 2025-07-08 18:33 ` Nicolas George 2025-07-08 18:06 ` [FFmpeg-devel] [PATCH 3/3] avformat/tls_openssl: load default verify locations Marvin Scholz 2025-07-08 18:16 ` [FFmpeg-devel] [PATCH 1/3] avformat/tls_openssl: add host verification Nicolas George 2025-07-08 18:17 ` Marvin Scholz 2025-07-08 18:21 ` Nicolas George 2025-07-08 18:24 ` Marvin Scholz 2025-07-08 18:33 ` Nicolas George 2025-07-08 18:50 ` Marvin Scholz 2025-07-08 18:53 ` Nicolas George 2025-07-08 18:28 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz 2025-07-08 18:28 ` [FFmpeg-devel] [PATCH v2 2/3] avformat/tls_openssl: verify setting hostname for SNI Marvin Scholz 2025-07-08 18:28 ` [FFmpeg-devel] [PATCH v2 3/3] avformat/tls_openssl: load default verify locations Marvin Scholz 2025-07-08 18:53 ` [FFmpeg-devel] [PATCH v3 1/3] avformat/tls_openssl: add hostname for verification Marvin Scholz 2025-07-08 18:53 ` [FFmpeg-devel] [PATCH v3 2/3] avformat/tls_openssl: verify setting hostname for SNI Marvin Scholz 2025-07-08 18:53 ` [FFmpeg-devel] [PATCH v3 3/3] avformat/tls_openssl: load default verify locations Marvin Scholz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=39784A97-A26B-47EA-9570-9DFE8B4AB382@gmail.com \ --to=epirat07-at-gmail.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git