From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 56E4348FE3 for ; Fri, 1 Mar 2024 22:31:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4165668D2B0; Sat, 2 Mar 2024 00:31:08 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D40E468D19D for ; Sat, 2 Mar 2024 00:31:01 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 9C1D4EA0C8 for ; Fri, 1 Mar 2024 23:31:01 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VmTPNBLDFt1u for ; Fri, 1 Mar 2024 23:30:59 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 5319AEA026 for ; Fri, 1 Mar 2024 23:30:59 +0100 (CET) Date: Fri, 1 Mar 2024 23:30:59 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <38e79b44-521d-7788-e5d8-4f289f475621@passwd.hu> References: <20240226004525.4321-1-cus@passwd.hu> <20240226004525.4321-4-cus@passwd.hu> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/wavdec: dynamically set max_size by default X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 29 Feb 2024, Marton Balint wrote: > > > On Thu, 29 Feb 2024, Andreas Rheinhardt wrote: > >> Marton Balint: >>> The wav demuxer by default tried to demux 4096-byte packets which caused >>> packets with very few number of samples for files with high channel >>> count. >>> This caused a significant overhead especially since the latest ffmpeg.c >>> threading changes. >>> >>> So let's use a similar approach for selecting audio frame size which is >>> already >>> used in the PCM demuxer, which is to read 25 times per second but at most >>> 1024 >>> samples. >> >> 1024 samples seems to be quite small, in particular for files with few >> channels (like stereo). > > 1024 is kind of a historical default. Also having multiples of 1024 is > beneficial for some codecs which encode this many samples per frame. > > In any case, I am not against somewhat increasing this, but it should be done > for both PCM and WAV, it can be a separate patch and discussion. I will apply this set soon unless there are other comments. Will send a patch after that to increase the default sample amount for wav and pcm. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".