From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 73963459EA for ; Tue, 28 Feb 2023 23:30:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 238BA68B115; Wed, 1 Mar 2023 01:30:28 +0200 (EET) Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0F38868A13D for ; Wed, 1 Mar 2023 01:30:22 +0200 (EET) Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-1755e639b65so1246634fac.3 for ; Tue, 28 Feb 2023 15:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OGzUMO9667+S8322KprRwKPlg1jJH6nP6vJ6u7EjWLo=; b=jqiPVHsPvL0a2k4Onn0OvVMhterOk9uETTFbSOcxwcDCIOii7wARtE9b6TGnFSSq80 dt+WEHFuDACx4SbQBNKumsfsSwLjWQA7gv48YIUhhE63hqo7TUyNHi26d0n2GvgP4VWP MbsrWM2vnZgS4w3kUEkYNj0t2R6bzKBQ1SEArh/HY+426lvBx8aDAtgyL1yQxBAfoVXK Ct8CzpWkj6ddWbFgpH50FeQplN7oNJ876XgnZ8L1AjbSHak2ZqBZXpPpz0z9MZYzuKlb ZUQcbzzuX1G5eC19umoSivXV3XkfjBsv2RHH1cPQVByiaAojmrrzkYRbmy7UNMhLMxrZ QE3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OGzUMO9667+S8322KprRwKPlg1jJH6nP6vJ6u7EjWLo=; b=Vnbh91U9ug8a6DVBGSQaZkkuXXC3u6uw2IQ9BRp1CjMCWhKlaW4oX3I5AzTkmhkQll 1f76LBug235FJ1Bj8Jaj31iOeXsoJ0qVpnFljcteGmSDT0XqW1AMIERl39X6aKKGCX33 Dep8zSCMiMw8eBCoxQuIi5XhXYuy1nCpvRkDqxh7tbInAcJvgtobgb2ZiWZk8pLELAgC EhG1iNwxf3gHMDhcHSafw3fo7JFVSQJBQhr0D2pXpdVIDkYx1s4Fm+a64wgOiBKOZHYF ybEPudbzvCsya66PK1nbAwiYi51ryrSa+H9Iucf1RZv1jLlZTq+kR0mxfsLG34DUFx61 WehQ== X-Gm-Message-State: AO0yUKUZwsgCJi983ZUmhcgwBjF7wFm8jqQpKHRT6GQCUp8tz3LDPHmq qT/OV2x0ERamnwSehHypCEeSVT+BLRs= X-Google-Smtp-Source: AK7set8J2NqoKFm23P+speDrrUVV7t3kDqqaYag2AO+ukBayJztxHOzIfOZLey3RBHApE98F0Yi4dg== X-Received: by 2002:a05:6870:700d:b0:176:228a:95b7 with SMTP id u13-20020a056870700d00b00176228a95b7mr254658oae.17.1677627020321; Tue, 28 Feb 2023 15:30:20 -0800 (PST) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id u13-20020a4ad0cd000000b0052037988717sm4307581oor.4.2023.02.28.15.30.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 15:30:19 -0800 (PST) Message-ID: <38425125-6eb2-67b2-ebc9-6dac16e3b5f9@gmail.com> Date: Tue, 28 Feb 2023 20:30:25 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230228120104.2347-1-anton@khirnov.net> <20230228120104.2347-5-anton@khirnov.net> From: James Almer In-Reply-To: <20230228120104.2347-5-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 5/8] lavc/libvpxenc: handle frame durations and AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/28/2023 9:01 AM, Anton Khirnov wrote: > +#if FF_API_REORDERED_OPAQUE > +FF_DISABLE_DEPRECATION_WARNINGS > + avctx->reordered_opaque = fd.reordered_opaque; > +FF_ENABLE_DEPRECATION_WARNINGS > +#endif If this was not being set before this patch, does it make sense at all to set it considering it's a deprecated field? I remember for example we would not fill avctx->coded_frame on new encoders after it was deprecated. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".