From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 791B34CAEF for ; Thu, 26 Jun 2025 15:43:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id AF7B368E1C7; Thu, 26 Jun 2025 18:43:06 +0300 (EEST) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A5A3468DD10 for ; Thu, 26 Jun 2025 18:43:00 +0300 (EEST) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-607b59b447bso1866361a12.1 for ; Thu, 26 Jun 2025 08:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750952580; x=1751557380; darn=ffmpeg.org; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=AJsCrI3sPrdjm/QD4HL0GcmzhvHawqRtF8IMTPHLSqg=; b=ncBoPZMB7tPgvWvwTfsbWW00+PDVQ2YPi9AMIMR9tW6z/TLk4IE4Y0vlLawiGFIJi+ VjWKnjVTLu0KsJsDMRNcbVwQwn9M23o9isPIHmMGTnDkKRLFbZkRK+sZpZIZPITnHxSQ 7x9jbVcc3t1zjViEYqttfcH2b98jLgU3QyYn7Ylhh05EpytzQyvtt9OcznGhBcGpJEa6 6t/PnbvZAtmhsVoRFgLFKfKyvotH0KRlrvUDPUrj4qz1H9vLRgKblSY04Hyei8K76tM8 qtr0mZYnXti51QB1GOjr9y4YgaOVDRv6sCPJV8y7PiKj52b/Uwza+NkSJ3KG2Yb+DvFd qdAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750952580; x=1751557380; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AJsCrI3sPrdjm/QD4HL0GcmzhvHawqRtF8IMTPHLSqg=; b=YPr47qpnS/E4LYamWlgu967/lCSHBB0uWetc5RbqLitM3AJ9/IXr1TVfj7L01hhKuF B7V+jUaOX5StF9lSR0Rmb82JpEN/MUysP/wb6WfqCnc+lJy5vvSqkjlFwGL6cCFhHb// EjAguPXgBlh9GYI72E1TheVtwbX4l7DVa7RsC2L7yajQxRtQ5fDKCA+tJGP34CaxgCk9 5CBhqCSG022gx9qxdgrje8x42YTbiV53p9YvYGdvqfvCBaDNzXd+XjIIViSEMb+hGW6k M9YxAK4Cun2SU73vo8z3nZ9/FCvmIxAQC9L3nPdr0oQYMKnmDs30g/5aIOrrFp2RcHJy KXtA== X-Gm-Message-State: AOJu0Ywdbe6LbrIOxV5y1Zk6LFZdpVudIcdC1FXXA9M0TmHlBtgQYlzY CS/20f9mipakSEESvfus4S9950KqtNE262DhJhinsQViFJDCreENVcfXl5FBBw== X-Gm-Gg: ASbGncudmJcr72mNzdarFOFkOpgYcEGFtnquNISErfW2dSi94Lat8ypV1nEIO1uyAJ2 F9Hf2vV73+Xnq5BSY6S4OH2637bA/kgrpi54Mm4tB+y1ZIIEKkknzSDfCXGQ4hJfZ5zttGV9BjD swLeyrbTF7q+aEG7c/H3YaGf3F9jNCe5yO2+PEs74C0O99tlVJvS833sgSv1ChB+jgBZSEXuZyL jvbSBbBMR1+RcdPR0/Qk3fKn6ksx53aN9+mudnCP72BEGC1klpbbTvbsOeeVaGF2hzOVUiHas9+ lq3EgU1F6ObPW2+piGYzkwHh9y+iFllt99U5bZiQ8c964BtNuT39Hsj9Jb9Y+Y4AbKEyXx0MvDd ZwXa/aB6TCnfzkfHiW5rz/wY1BYFAXPLVD9T1akKtOHuybXq2P4K+STCoYgZi/wDUQYqk6OSxK8 8= X-Google-Smtp-Source: AGHT+IHpLbC7yz5qrnVoYCOlbQHJNi+M5TunZFvPRZDw6qbpCfxnJPnh6p8KXmnCEGAEadjyLa13Cw== X-Received: by 2002:a05:6402:40c5:b0:602:36ce:d0e7 with SMTP id 4fb4d7f45d1cf-60c4dc28757mr7491082a12.14.1750952579783; Thu, 26 Jun 2025 08:42:59 -0700 (PDT) Received: from [192.168.178.57] (p20030102370045007d7f230e46ac5795.dip0.t-ipconnect.de. [2003:102:3700:4500:7d7f:230e:46ac:5795]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60c8290eaefsm152720a12.34.2025.06.26.08.42.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jun 2025 08:42:59 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Thu, 26 Jun 2025 17:42:58 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <37EDA6CE-6E8B-4E84-A9EF-753B60078E7C@gmail.com> In-Reply-To: References: <20250624220805.50371-1-epirat07@gmail.com> <20250624220805.50371-2-epirat07@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/tee: fix multiple bsfs in tee X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 25 Jun 2025, at 11:56, Nicolas George wrote: > Marvin Scholz (HE12025-06-25): >> Since 155508c6e925f4f2f5e77087a7e1925b3de735ff specifying multiple >> bsfs for different streams was broken: >> >> "[bsfs/a=h264_metadata:bsfs/v=h264_metadata]out.mp4|..." >> >> This incorrectly only parsed the first bsfs specification. The reason >> for this is that the dictionary is modified in the iterator, hence >> invalidating the iterator. The simplest fix for this is to simply >> iterate from the beginning in each loop given that the previous entry >> is removed. >> --- >> libavformat/tee.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Sould be ok, thanks. > Pushed as f744584f7160db99c1003ef938c53d26eb427b00, thanks. > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".