From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/tee: fix multiple bsfs in tee
Date: Thu, 26 Jun 2025 17:42:58 +0200
Message-ID: <37EDA6CE-6E8B-4E84-A9EF-753B60078E7C@gmail.com> (raw)
In-Reply-To: <aFvHxKfdz5A_tWXF@phare.normalesup.org>
On 25 Jun 2025, at 11:56, Nicolas George wrote:
> Marvin Scholz (HE12025-06-25):
>> Since 155508c6e925f4f2f5e77087a7e1925b3de735ff specifying multiple
>> bsfs for different streams was broken:
>>
>> "[bsfs/a=h264_metadata:bsfs/v=h264_metadata]out.mp4|..."
>>
>> This incorrectly only parsed the first bsfs specification. The reason
>> for this is that the dictionary is modified in the iterator, hence
>> invalidating the iterator. The simplest fix for this is to simply
>> iterate from the beginning in each loop given that the previous entry
>> is removed.
>> ---
>> libavformat/tee.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Sould be ok, thanks.
>
Pushed as f744584f7160db99c1003ef938c53d26eb427b00, thanks.
> Regards,
>
> --
> Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-06-26 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 22:08 [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing Marvin Scholz
2025-06-24 22:08 ` [FFmpeg-devel] [PATCH 2/2] avformat/tee: fix multiple bsfs in tee Marvin Scholz
2025-06-25 9:56 ` Nicolas George
2025-06-26 15:42 ` Marvin Scholz [this message]
2025-06-25 11:23 ` [FFmpeg-devel] [PATCH 1/2] avformat/tee: refactor option processing Nicolas George
2025-06-25 12:04 ` Marvin Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37EDA6CE-6E8B-4E84-A9EF-753B60078E7C@gmail.com \
--to=epirat07-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git