From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C617E47A61 for ; Fri, 29 Sep 2023 17:37:21 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 43AC368CCA7; Fri, 29 Sep 2023 20:37:19 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C4F668CBEE for ; Fri, 29 Sep 2023 20:37:13 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id A967B41F221 for ; Fri, 29 Sep 2023 19:37:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1696009030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eH6TWzMKMpPdm97CIOKtvxiBLd5/HeILuo6tGiHiJYE=; b=kdJR4whUmpvX3efTAMTuqDbiB5/7p3CFOv5U6nfFgQx2Z4qdlRbOqd0rvtG3BVQ5BpNDRr Iufzly0rXTfvHorH3irarzSPwgbC4lgT5UvIgMw7E2kFrXd5jt342XNvNFZ2M3EYnu2zbI UmmclYjdFDP4h0yYu3Ws/3v4hb7zD/YB0/xBfKZlQpYC9RL08cDS8nopMvfums8FLnMuPh XnQWVwJcnwiN99+j/+kxQWX/Z6ktQDNGxkqu2/OjVsQJ4DmpI6r3UErYWUKNCz7gtbDhEX Q2dEqFqlQRNOKtbou3b+QCUWFAVPMcJ/zZdBEyVCkbPZmS/Kyz6z0Exdg+cgdA== Message-ID: <3694123b-a86d-400f-b8a2-6efdb19d5786@rothenpieler.org> Date: Fri, 29 Sep 2023 19:37:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20230929135254.2607031-1-tmatth@videolan.org> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: <20230929135254.2607031-1-tmatth@videolan.org> Subject: Re: [FFmpeg-devel] [PATCH] configure: disable vulkan if min version insufficient X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 29.09.2023 15:52, Tristan Matthews wrote: > Fixes: https://trac.ffmpeg.org/ticket/10596 > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 20db1801ed..50ba6f772f 100755 > --- a/configure > +++ b/configure > @@ -7154,7 +7154,8 @@ enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if. > > if enabled vulkan; then > check_pkg_config_header_only vulkan "vulkan >= 1.3.255" "vulkan/vulkan.h" "defined VK_VERSION_1_3" || > - check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)" > + check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || (defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)" || > + warn "Disabling vulkan" && disable vulkan > fi Doesn't that just always disable vulkan if any of the previous checks succeed? The logic looks weird to me. Also, shouldn't all of those check_* calls disable vulkan already? That's what the first argument is for. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".