Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] configure: Remove a leftover comment about MSVC C99 support
Date: Thu, 27 Oct 2022 13:17:48 +0300 (EEST)
Message-ID: <369365a-3fd9-2186-c995-ddc181ec4f5@martin.st> (raw)
In-Reply-To: <20221019085351.59862-1-martin@martin.st>

On Wed, 19 Oct 2022, Martin Storsjö wrote:

> Support for building with older versions of MSVC (with the
> c99wrap/c99conv frontend) was removed in
> ce943dd6acbfdfc40223c0fb24d4cad438e6499c.
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> configure | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/configure b/configure
> index 6712d045d9..ed52212f93 100755
> --- a/configure
> +++ b/configure
> @@ -4368,12 +4368,6 @@ case "$toolchain" in
>         esac
>     ;;
>     msvc)
> -        # Check whether the current MSVC version needs the C99 converter.
> -        # From MSVC 2013 (compiler major version 18) onwards, it does actually
> -        # support enough of C99 to build ffmpeg. Default to the new
> -        # behaviour if the regexp was unable to match anything, since this
> -        # successfully parses the version number of existing supported
> -        # versions that require the converter (MSVC 2010 and 2012).
>         cl_major_ver=$(cl.exe 2>&1 | sed -n 's/.*Version \([[:digit:]]\{1,\}\)\..*/\1/p')
>         if [ -z "$cl_major_ver" ] || [ $cl_major_ver -ge 18 ]; then
>             cc_default="cl.exe"
> -- 
> 2.37.0 (Apple Git-136)

Will push later today.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2022-10-27 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19  8:53 Martin Storsjö
2022-10-27 10:17 ` Martin Storsjö [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=369365a-3fd9-2186-c995-ddc181ec4f5@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git