From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E856149669 for ; Sun, 17 Mar 2024 08:06:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9551E68CC9F; Sun, 17 Mar 2024 10:06:01 +0200 (EET) Received: from ms11p00im-qufo17281501.me.com (ms11p00im-qufo17281501.me.com [17.58.38.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EF39668C75C for ; Sun, 17 Mar 2024 10:05:54 +0200 (EET) Received: from smtpclient.apple (ms11p00im-dlb-asmtpmailmevip.me.com [17.57.154.19]) by ms11p00im-qufo17281501.me.com (Postfix) with ESMTPSA id 51493B61C3F for ; Sun, 17 Mar 2024 08:05:52 +0000 (UTC) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Date: Sun, 17 Mar 2024 16:05:38 +0800 References: <465c2b3e-219f-4074-95c9-66e6109f43f7@evermeet.cx> <941BFC58-C890-4900-98E2-2EB53B4E05C1@me.com> <1d136e20-c05f-49b2-8bbb-6fa7e1e9390b@evermeet.cx> To: FFmpeg development discussions and patches In-Reply-To: <1d136e20-c05f-49b2-8bbb-6fa7e1e9390b@evermeet.cx> Message-Id: <36042735-9AED-421A-A197-9C46226E5720@me.com> X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Proofpoint-ORIG-GUID: FnoID5XrbLMRQoS9W84FGBT2jaIkxIRL X-Proofpoint-GUID: FnoID5XrbLMRQoS9W84FGBT2jaIkxIRL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-17_04,2024-03-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2403170061 Subject: Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Gnattu OC via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Gnattu OC Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? > On Mar 17, 2024, at 05:09, Helmut K. C. Tessarek wrote: > > Hi, > > On 2024-03-16 10:26, Christopher Degawa wrote: >> Seems the conflict comes from >> https://code.videolan.org/videolan/libbluray/-/blob/master/src/libbluray/disc/dec.c?ref_type=heads#L287 >> and >> https://github.com/FFmpeg/FFmpeg/commit/c4de5778bceab3c15f1239f1f16816749a7fd3b6 >> Perhaps you could also try asking libbluray if they could use an internal >> prefix. Otherwise you might need to do a rename of that function on >> ffmpeg's side. > > Hmm, this commit in ffmpeg broke the possibility to link ffmpeg with libbluray. Just to make this perfectly clear, before that commit it worked without issues. > > This means that nobody is able to use libbluray and ffmpeg from this point forward. I am sorry, but this commit should be reverted. > > The commit message reads: Rename dec_open to dec_init(), as it is more descriptive of its new purpose. > > Who cares about how descriptive it is as long as it works. Now it doesn't. This was not a change to implement a feature or fix a bug, but a simple refactor, because somebody didn't like the name. > > In reality I agree with you that it might be better for libbluray to use a prefix/namespace or whatever. But until then, ffmpeg should still be able to be linked with libbluray. > > Is my standpoint unreasonable? If so, why? > > Cheers, > K. C. > > -- > regards Helmut K. C. Tessarek KeyID 0x172380A011EF4944 > Key fingerprint = 8A55 70C1 BD85 D34E ADBC 386C 1723 80A0 11EF 4944 > > /* > Thou shalt not follow the NULL pointer for chaos and madness > await thee at its end. > */ > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".